From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00CDA4499BD for ; Tue, 11 Aug 2026 16:52:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786467164; cv=none; b=m1t5AkZ8Yspdri/nK1u3EnQHxg+sBOf5/LtVIt5CBAvGkAhkA+RMITifRXTkneE5EwqiVZmZF80eDQOZikytsm4rweqiO5+qfF/GdVE5lELEAW7AzD9ABWIFys6jKiCg5UMFlJNIvm2nFsONGp4mkwLk0tTWcJllZrVDEoPvq60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786467164; c=relaxed/simple; bh=Jyhur9BtevRiPzfznp1j/Pj5hzr7oi1T1dCMXSy1pG0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hg8n5GygkeOLWDOEgVqevLkaAtzWhENId4AEBGHjXuKDZtkwDTUQ7ZLMJhI40jUjPccH8sSvxKFQRur8tA+mg/99mfRps00k3Hr03b14hKR41NY8+2+gxjYenox08TrgdyjUVFiYCePrmPg/fin/23vAoRW5ocx55lxcKDXx6zw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=emOiD/mJ; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="emOiD/mJ" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so20745e9.1 for ; Tue, 11 Aug 2026 09:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786467158; x=1787071958; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=sVCfGD0PlR6xK5qm0z7xLg2t4uabVyupoEAwJ2u3L+o=; b=emOiD/mJnrZquRd9FzYLS9lwC8gJ32xlSr9R0hmLxlNlRDH0Dz+OR8xamSyqJHkmOq SXvof0NI5bU+cY0104DjBZBt8RVruHYHa34r7ACMWGXCwwMb7Qh3kov0NN7BpNWPVKMd HIISeYHMcZRhhdR4LYmlUtsOs7V+015AQ5I+lH1tyHib1cXrErB9saxtZb05uVcyRtbn ocdRcvekWu3ztmfkCudS660EQnU0HD+Q+pcjSt81qjFs43pqAcd8OTpZqf9YXn/q+sEN TS6027wvTCyNZ6QUhOIP4hjIgH71BpTz13gLeBzINJPSqia8PrgGKna60+hBS0cFRG7X Daiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786467158; x=1787071958; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sVCfGD0PlR6xK5qm0z7xLg2t4uabVyupoEAwJ2u3L+o=; b=asK56PSJD+EmdpK9VfE39hPREgF2anafxU49EX7WMd2HkfX1JNMxisYjbiqXaglzCT wx8MkqDQFoygLiKpkDZ9eZH65netBsqXx598XS2HCjIsJOPBAo1qg3X1J6lx/Vp7Qrso KaxUkirEbCqrYEBkOszW3lO4ZpjFujbHJ3qaZNQbXrmrPDbyr4B9kG05/mMQrJQ16Erc 4ss5YRdxC9kdqwIohcG3f7C7FmOMOs3mstiFlGUjVUr+xLK+xotjwH1cbm6GTFJtDbBA Pw0vIPhlCWOTX+7TKVBge5lffn91bzPsoz5CUB0MwA7o59rQyA7TU0K3oIS9gMrfXAGr /X3A== X-Forwarded-Encrypted: i=1; AHgh+RrPpQMhWp3eh1931xigOGevy9/TBIXLVn0Ix3mzJkxmYcaFyW35yhsv1Touunq5Y+ccIEQEY49pKUXg4mI=@vger.kernel.org X-Gm-Message-State: AOJu0YzgofP8Wckau4WhD0zUBBOGwIZ4Jz7/8/EwgL99iZYzy6q/0vAs xaa1ELLNLpMr2fGzmBCxBKtWfKcbKZJkqStJ2PwNpaTpAqDqxjPQv2bl X-Gm-Gg: AR+sD11PqxOWGmL9UhfFPYBIgOXxSzyeMniLx2VmuUi23ovDptSiiIRyddnGrYtuXXR B5EF9Iv0bYko5mtT3recfniuyAbr+f8EXrjMfhYaIL1J98PUnvfqzgbwd+FmA3tCns1CKGOZZuu OZDx9haqqekmbcQHKYwyeB2v6KOKy2REBcObQsva7Gh4H5shr9lr50iz6Lq9RTrNhB1YABhX7nd 4yslyyzDnGlqItWCf88+LSo2WS+4aHUQ4f/peewLeIId6Nkw43g6ouQVZcMlf+quOuPY798N0ut eZ6AQBq9028Amwi31Qjanz6JhL4kvnJ/9RdDUkpY6MeoDu1Lbq++Vcq4jWnrA6U9Zb/4pmyLgpa 3KSe5XobBdMZa9+O5wfWuXbDb+mfb9LJTFjTTpZeUzaIFy3ClJcVSkmMJTiQbFjjUFTRSovCpj8 xeqCZdfyi7uHY3OwC3omFw37iXhvgB7NdkFVygrniuSGvRq6Na3Kvf3bdUMRX38MbA40kV8eWXg vZY0F/CqnSgkXtsVdmyIyoQSoBAQZaK X-Received: by 2002:a05:600c:1d24:b0:495:503f:cf9a with SMTP id 5b1f17b1804b1-49978460326mr65825205e9.9.1786467157921; Tue, 11 Aug 2026 09:52:37 -0700 (PDT) Received: from osama ([2a02:908:185:7e40:434a:d6cf:4fd1:90b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997ad79e0csm987065e9.1.2026.08.11.09.52.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 09:52:37 -0700 (PDT) Date: Tue, 11 Aug 2026 18:52:35 +0200 From: Osama Abdelkader To: Javier Martinez Canillas Cc: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Ondrej Jirman , Michael Trimarchi , Michael Walle , Dario Binacchi , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] drm/panel: Use devm_mipi_dsi_attach in Himax and Ilitek panels Message-ID: References: <20260811151000.75038-1-osama.abdelkader@gmail.com> <20260811151000.75038-5-osama.abdelkader@gmail.com> <8733wkpthm.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8733wkpthm.fsf@ocarina.mail-host-address-is-not-set> On Tue, Aug 11, 2026 at 05:27:49PM +0200, Javier Martinez Canillas wrote: > Osama Abdelkader writes: > > Hello Osama, > > > Use the managed MIPI DSI attach helper in Himax and Ilitek panel drivers and drop the corresponding manual detach calls from remove paths. > > Please break these at 74 characters max. > > > --- > > drivers/gpu/drm/panel/panel-himax-hx83102.c | 7 +------ > > drivers/gpu/drm/panel/panel-himax-hx83112a.c | 8 +------- > > You are missing a Signed-off-by tag. > > -- > Best regards, > > Javier Martinez Canillas > Core Platforms > Red Hat > Hello Javier, Ops, thanks, I don't know how did I forget that. Thanks for the quick review. BR, Osama