From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 198103148D8 for ; Tue, 11 Aug 2026 17:47:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786470427; cv=none; b=lTMhDB6xb3KARR5RQns7H7TDqlQBShaQu7rGGgJimdO6JaXRXcwBdPoGTkTfGxgCMlApOAEWj4dpht+/kMx4UBMZ4y0L6z7vazUO3p5QzDSJ93Y0WHxf5fVYgEeqCv1b0y+BQ83wL2HRNtdPuEwNwyAhctOdn5Osy7x6/c9odoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786470427; c=relaxed/simple; bh=wihEomTEe3RT0befzU8t+WIMF9QfFXeERIOn9Sq6LKA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HAcxaIEWMzRpYyfjoMj3k1ZSloUvgk0ByWj+WB5N1wMa1XBrwJRsacv97G+CLdh1U3VO4ua4+scfD1RwxSASm+/z5sA6csuu5j7iTzIuJLX4bo7IOPv9cPtk8qjx4V6TQyh2oH11rUXKr9XPpEYal+TRhbZpiXpHZdqBmm7ul5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=AgwMZgsk; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="AgwMZgsk" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 78E341682; Tue, 11 Aug 2026 10:47:01 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.2.213.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 191733F632; Tue, 11 Aug 2026 10:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786470425; bh=wihEomTEe3RT0befzU8t+WIMF9QfFXeERIOn9Sq6LKA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AgwMZgsk23GeYnZ0ies2PnlAYgpICmsVx7Mcec5MGeql68KV0lha3k+1zMnSeW4QU tFOwOF0fNSBF7FS9NaljYL4VeEBFSJhF2Rm3xUBAF2njt5NmUFlBzqcTC6C0UnjoOm /Vo1e1XI+xtdMoLjAmdk/jPPkO68ZTIZ36fAH+ls= Date: Tue, 11 Aug 2026 18:47:01 +0100 From: Yeoreum Yun To: Leo Yan Cc: Yeoreum Yun , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com Subject: Re: [PATCH v9 11/13] coresight: etm4x: remove s_ex_level from config Message-ID: References: <20260725113645.57519-1-yeoreum.yun@arm.com> <20260725113645.57519-12-yeoreum.yun@arm.com> <20260811172517.GI15499@e132581.arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260811172517.GI15499@e132581.arm.com> On Tue, Aug 11, 2026 at 06:25:17PM +0100, Leo Yan wrote: > On Sat, Jul 25, 2026 at 12:36:43PM +0100, Yeoreum Yun wrote: > > [...] > > > -static u64 etm4_get_access_type(struct etmv4_config *config) > > +static u64 etm4_get_access_type(struct etmv4_config *config, > > + const struct etmv4_caps *caps) > > { > > Is it possible to retrieve drvdata from config? Something like: > > drvdata = etm4_get_drvdata_from_config(config); > > If this is feasible, we wouldn't need to modify so many functions to > add the *caps argument. It's feasible, however, I feel it doesn’t seem semantically appropriate. Since, the etmv4_config is a configuration and TBH, it could be not embedded in to etmv4_drvdata. Though the usages where the chnaged fucntion, the config're all embeded. However, If we introduce the etm4_get_drvdata_from_config(), We need to check the drvdata pointer is valid since it passes the config not embeded and this would be more strange. So, I think it seems better to the caps arguments. -- Sincerely, Yeoreum Yun