From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C20C3932D4 for ; Tue, 11 Aug 2026 18:50:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786474213; cv=none; b=XpbWBeZHxHwPrdKak8lqjNCaE3cqTML2uJn0wuunbA0g2mfSjoAlJUST1uHsDHuZkoY+cUxwhI1i5Hq9FtAWODyaDoZsrpuxH610cZz8KeWO+HAxOnvdKM5rOaUTbms77H91niBZqDtL+LDdGB/9pIRtNwafai2G80ZHO8CUnQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786474213; c=relaxed/simple; bh=/XndPrnbkW/+T4iyC4fdQzl3+nRdbMmQ10eWKLyZ1V0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GUilNPJXvfXXV1nAUoODMjXgyiNWMIFy/rzDezJay4SMavgpT/e570j2ENQhoE0iH+CVWXpqYE0C9Xd93sz5nzdxCbR2uwpk2h9u/f95T0HwFLFoKwk+nqREZQVvQCWUc/eeuA2AhLTLk/leUklHia3ZNT63r46r0GPH92IqSvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=L49HxtsT; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="L49HxtsT" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-ca80d708489so149683a12.1 for ; Tue, 11 Aug 2026 11:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1786474212; x=1787079012; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=GnHJCm2ZqOWuDJ2d9OnSHmMgxlAtHC/PNWplMTJtneE=; b=L49HxtsTMObXboaJMXw+WlMDVrSxl5/Us01Vni3cNW+fMBYPmr9m8WFReEHodBYDaP PD/xdbAvE9dNK9UJy42h5xfohGEfoEK7P30YzqGLBlUkwZ/+5FKf6Z7PCOiVBBMRyzSK O3EXPJTIwCxfgCw/ya2wNOY2f3zq8rRXKs33E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786474212; x=1787079012; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GnHJCm2ZqOWuDJ2d9OnSHmMgxlAtHC/PNWplMTJtneE=; b=tAeNVku0t67Lcxh/p0v4GraWznyKhbf8ukTk7EaR4XMyytuGPZDdLayM+gv6Ptlxez 5jgXKDI5D49h7rlsJHXlaKB6OoD/mrUP/jBc9a+W0VkdEjPCa6xCdrpl/gK1n7tzBybn Wx36b68VEMMg6kwnV8KGThWBvT/To9d/k14208DMbXCP6abOUffWnfBsK8pi0uBnYEQe BEBEXxZLLB3dLhSl0r297EQCzJ76apFW3QNtMQRKplTvCwIaWLMmX96c+zfsC/YPZPVP effx9vargspiNkD6ifKmQrLYm9tq4VVYjLmE6ntLhhJsXs9YhwfJiBIldqs3p/c1vupX 5ZtA== X-Forwarded-Encrypted: i=1; AHgh+Ro72SanH/DcEJCG1fZcJCBfiD/g5VFTn+O3YSRzlroUdcENGpXfHYQRRaV0MIB7poLjqepsLWd2r1Xnsdc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxow+5LPKCuDLKBMiMcUkBSSTnhy76tHzy8uOql6ePDXYFjCs2Z xNHlcJp/vk1kj/tpNSqzmKKI+D7AMDBl4Bf23DUD2l3GfvO6uE7ok9HCoKmIZVuK+w== X-Gm-Gg: AR+sD11E5mdNmSVWOilgdw7ChahIcDKutwmnmwY2TRiShX7qdRoRFLeIrgL3apssyM1 OsDXHyEQZc2uE3hqqFExo3GARp+cP8q1oUdsewfYCxak3sR0m9ZwnBTSx7zlmxJlnlF1geXZ33L l9mIrY1dzSZ192k94Yrl+rOIjjjmbM0e3GJB4mbGntGmPGOBlbHC5gKNYCRxaw+zBd/rTzIzdED snvYTXG7H2WeJge1zHWfoyxVtlwKHlaUXvsXoqicPtlW6BZ6f+PoEZX2HGdEBAYltimf2DkjFyt q9DPlvqE+PNo5kFN/Ek5AdwSf7rq/jFQYX6GJ/A3ACGwsAMrSm7a8gyUN8EBskwpaxUyDar7pQD ESS2Vt4s1XSyrqNjk/D3dmBE30glubkZoAAw2RmECnXl/7hA9cb02gdlNVw9f4rY2bVF2bYfjOX 3Vcv0cczDEn2hj0itHRQTn0+TnJl1h3x3mPWlxGch6fqW3blBgie2sUMo7mJsHiAZH6PPKIpIlx 6mI104idBJQhx0U0nbBg9JE1Yg= X-Received: by 2002:a05:6a21:3117:b0:3bf:b7e8:68ab with SMTP id adf61e73a8af0-3cc377db1cemr3285344637.2.1786474211555; Tue, 11 Aug 2026 11:50:11 -0700 (PDT) Received: from localhost ([2a00:79e0:2e7c:8:79fa:d268:80cb:4947]) by smtp.gmail.com with UTF8SMTPSA id a92af1059eb24-1412458a390sm1677688c88.14.2026.08.11.11.50.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2026 11:50:10 -0700 (PDT) Date: Tue, 11 Aug 2026 11:50:07 -0700 From: Brian Norris To: Sean Rhodes Cc: chrome-platform@lists.linux.dev, corentin.chary@gmail.com, luke@ljones.dev, denis.benato@linux.dev, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, prasanth.ksr@dell.com, jorge.lopez2@hp.com, mpearson-lenovo@squebb.ca, derekjohn.clark@gmail.com, josh@joshuagrisham.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, florian.fainelli@broadcom.com, chenhuacai@kernel.org, mst@redhat.com, wenst@chromium.org, tzungbi@kernel.org, jwerner@chromium.org, tzimmermann@suse.de, javierm@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch, krzysztof.kozlowski@oss.qualcomm.com, andersson@kernel.org, geert@linux-m68k.org, dmitry.baryshkov@oss.qualcomm.com, arnd@arndb.de, ebiggers@kernel.org, luca.weiss@fairphone.com, michal.simek@amd.com, sven@kernel.org, u.kleine-koenig@baylibre.com, bhelgaas@google.com, dakr@kernel.org, o-takashi@sakamocchi.jp, titouan.ameline@gmail.com, kees@kernel.org, dri-devel@lists.freedesktop.org, oliver@liuxiaozhen.dev Subject: Re: [PATCH v12 4/4] firmware: coreboot: Add CFR firmware attributes driver Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Aug 06, 2026 at 01:28:39PM -0700, Sean Rhodes wrote: > coreboot can publish a CFR tree in its coreboot table to describe > firmware setup options. Add a firmware-attributes driver for that table > entry under the coreboot firmware driver directory. ... Kind of a large driver, but in a partial pass, nothing jumps out as too scary to me. > diff --git a/drivers/firmware/coreboot/coreboot-cfr.c > b/drivers/firmware/coreboot/coreboot-cfr.c > new file mode 100644 > index 000000000000..54aae1442bcc > --- /dev/null > +++ b/drivers/firmware/coreboot/coreboot-cfr.c > @@ -0,0 +1,1208 @@ ... > +static int coreboot_cfr_apply_runtime(struct coreboot_cfr_setting *setting) > +{ > +#ifdef CONFIG_X86 What's X86-specific in here? Are you just needing inb()/outb()? That seems like you could 'depend on HAS_IOPORT', or #ifdef CONFIG_HAS_IOPORT. > + u8 status; > + > + if (setting->runtime_apply_method != CFR_RUNTIME_APPLY_APM_CNT) > + return -EOPNOTSUPP; > + > + outb((u8)setting->runtime_apply_id, COREBOOT_CFR_APM_STS_PORT); > + outb(COREBOOT_CFR_APM_APPLY_CMD, COREBOOT_CFR_APM_CNT_PORT); > + status = inb(COREBOOT_CFR_APM_STS_PORT); > + if (status) > + return -EIO; > + > + return 0; > +#else > + return -EOPNOTSUPP; > +#endif > +} > + Brian