From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8521345EBF for ; Tue, 11 Aug 2026 18:52:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786474376; cv=none; b=ZfhZZgV8RIArPS02kfeNrijnJ0LG9EbFmSBEWhIuc4gnOg5KW57ciFWfuIGugplZ1NrFEF3vQ5ENBdsW6xdGJqU0MhIwQsVE3rOnYyU783gX4G0riVGjJDtP58nxUABhIBjKIxax932aQ4fDuHtAh7T/rL6wO5ZNGwLVDxDjR4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786474376; c=relaxed/simple; bh=JR5HHb27zLtgTE3jEjvE5O4QP0G2THjkTCSY0L3E8eo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EpJa/sQqMV6t/zE389a3I97Ywhb26fVP+hHjGHQjrYZAdE1QFVL1fx4HPsq8yvnqBmUSZ9QboGUOfQgavpoxHyLWcPcaHCt2i7wz+2csgUVTRqZihHkK47nrA7o3bOmv7pa3mrN52WvwENUV6y/SaUUIdz63p+9nGCZxUr6e9Go= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=IOnYtbli; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="IOnYtbli" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-cbee3777e1cso77535a12.3 for ; Tue, 11 Aug 2026 11:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1786474373; x=1787079173; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=/A62uLpxfiS9evE/MOrYEJH336pQ9QO0r0n78qP4dLA=; b=IOnYtbliaqu+7xdBzneiM/93LZYG6WvEEKZRB5AZSDnsoc5Oy0miX4Wjv0jxS0/PZ4 KcGoW29sqwS907I7CiQxcSmV6PssyypRxFPv/scw3R/LfbHIllyWfX5OrTMNAYYALHt6 hcIAJzXTEzNLyB9zSoLfJKAR3INMUAu7mWQDs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786474373; x=1787079173; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/A62uLpxfiS9evE/MOrYEJH336pQ9QO0r0n78qP4dLA=; b=DGkD9qi8BpHQp+RJbOZFxPnVixhmk++P5HOBVlSDzkpa+l7dgZTZalNuKNksLU5e4J AwsXyx15iuX6FUxY62B4vdld+nd63zQsmP18WpES4ghd7vQ1VHK8PHsFf6UkDE63NeP2 DHdSnO8d1Vw5LteBLRCDT+uwoGXOUiSlOdemiN1URvy7G7tCBhbzpW1e1M1shYtQ7zF3 5UZliOnGa7ah6mSXVf3AMqJMOZafQ4dZObBimR40wcx0hetoWqzEexMyBQLqjNZKfrkL 4uO4VgrUG7Vz3Gl9RW3WoA+ew//vXcD08eSVTdXHyM2CXPt3b2sxqL/mvvRbZlCQyiZg A+Jw== X-Forwarded-Encrypted: i=1; AHgh+RqkIAtSpA9908GDdEJzYkP40Fn3gJ5TtOL37xqwkdyIRyqoDRZsKsATUpKzuHfENfhogjEs4YSER0qvgKY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyj4WiinLiN/tbCqmOlgE5wrLF28myhEYQKa6D1T6Unh9d7ERQA eqlakLFmrHlS9iYfV+0YJ8pNb3UoUa/00mdvAlkBNsCKGWKd/Ng08iTTAIK+eR7ykg== X-Gm-Gg: AR+sD116x5yhev0hmLWK4Dn8g2GrflkUL2PLF3vClRNBInZRkTtlSUnDalm7A65TwyQ i4PPxp9mCcrRcADuPCGOWuEndQcAb1LGMc1ZOYfd/J+uiguRwheMFXIS3FAgAs63h8EiWvCVk0U G/xbZ4ME6rH6uWj3NzJ8EiVU8fcFwNLyfe//1QQipTIZ2RZrLhPuQSO/JGE/TP7D2g2Edv5dR2B qj9PK1vOOA0w+Z3Q5im0A6q8FRb6hR8nTtpk4xoPq50Z0RTTHt3x1WJlGRlyVqBTt8ciPu8fBPS 4rD254tmWMy0FeeSMebo9O0gstJYB2zxpe57N9b1bCF3U1FWvcKpnxxaifUMxkjdbI5c+HopBPO IE20rgQsWysJzWu9MnTyD+9f251u9SzY6JQCx4rbup4LEtVQYUZyEba8RVbx7K9rcS0DzYbWTli nnbM5T1XYYYEbEaELPsleWUGDv2oMiUoiJrCBUfnppCQDW9EjNf3c96EXRU3aW5iFA7pUMqcoPK qbG59+URRwcDKYBPPOmcIc8KI4= X-Received: by 2002:a05:6a21:699:b0:3c4:396d:4a7f with SMTP id adf61e73a8af0-3cc2ba20ae3mr7611480637.15.1786474373068; Tue, 11 Aug 2026 11:52:53 -0700 (PDT) Received: from localhost ([2a00:79e0:2e7c:8:79fa:d268:80cb:4947]) by smtp.gmail.com with UTF8SMTPSA id 5a478bee46e88-31cf6d7a3c7sm2872543eec.29.2026.08.11.11.52.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2026 11:52:52 -0700 (PDT) Date: Tue, 11 Aug 2026 11:52:49 -0700 From: Brian Norris To: Sean Rhodes Cc: chrome-platform@lists.linux.dev, corentin.chary@gmail.com, luke@ljones.dev, denis.benato@linux.dev, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, prasanth.ksr@dell.com, jorge.lopez2@hp.com, mpearson-lenovo@squebb.ca, derekjohn.clark@gmail.com, josh@joshuagrisham.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, florian.fainelli@broadcom.com, chenhuacai@kernel.org, mst@redhat.com, wenst@chromium.org, tzungbi@kernel.org, jwerner@chromium.org, tzimmermann@suse.de, javierm@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch, krzysztof.kozlowski@oss.qualcomm.com, andersson@kernel.org, geert@linux-m68k.org, dmitry.baryshkov@oss.qualcomm.com, arnd@arndb.de, ebiggers@kernel.org, luca.weiss@fairphone.com, michal.simek@amd.com, sven@kernel.org, u.kleine-koenig@baylibre.com, bhelgaas@google.com, dakr@kernel.org, o-takashi@sakamocchi.jp, titouan.ameline@gmail.com, kees@kernel.org, dri-devel@lists.freedesktop.org, oliver@liuxiaozhen.dev Subject: Re: [PATCH v12 3/4] firmware: Rename google firmware directory to coreboot Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Sean, On Thu, Aug 06, 2026 at 01:28:26PM -0700, Sean Rhodes wrote: > Most drivers in drivers/firmware/google are coreboot table drivers rather > than Google-specific firmware drivers. Rename the directory to coreboot > and update the Kconfig prompt, build path and maintainer entry. > > Keep the existing CONFIG_GOOGLE_* symbols to avoid user configuration > churn in this mechanical move. > > Signed-off-by: Sean Rhodes > --- > MAINTAINERS | 4 ++-- > drivers/firmware/Kconfig | 2 +- > drivers/firmware/Makefile | 2 +- > drivers/firmware/{google => coreboot}/Kconfig | 6 +++--- > drivers/firmware/{google => coreboot}/Makefile | 0 > drivers/firmware/{google => coreboot}/cbmem.c | 0 > drivers/firmware/{google => coreboot}/coreboot_table.c | 0 > drivers/firmware/{google => coreboot}/coreboot_table.h | 0 > .../firmware/{google => coreboot}/framebuffer-coreboot.c | 0 > drivers/firmware/{google => coreboot}/gsmi.c | 0 > drivers/firmware/{google => coreboot}/memconsole-coreboot.c | 0 > .../firmware/{google => coreboot}/memconsole-x86-legacy.c | 0 > drivers/firmware/{google => coreboot}/memconsole.c | 0 > drivers/firmware/{google => coreboot}/memconsole.h | 6 +++--- > drivers/firmware/{google => coreboot}/vpd.c | 0 > drivers/firmware/{google => coreboot}/vpd_decode.c | 0 > drivers/firmware/{google => coreboot}/vpd_decode.h | 0 > 17 files changed, 10 insertions(+), 10 deletions(-) > rename drivers/firmware/{google => coreboot}/Kconfig (94%) > rename drivers/firmware/{google => coreboot}/Makefile (100%) > rename drivers/firmware/{google => coreboot}/cbmem.c (100%) > rename drivers/firmware/{google => coreboot}/coreboot_table.c (100%) > rename drivers/firmware/{google => coreboot}/coreboot_table.h (100%) > rename drivers/firmware/{google => coreboot}/framebuffer-coreboot.c (100%) > rename drivers/firmware/{google => coreboot}/gsmi.c (100%) > rename drivers/firmware/{google => coreboot}/memconsole-coreboot.c (100%) > rename drivers/firmware/{google => coreboot}/memconsole-x86-legacy.c (100%) > rename drivers/firmware/{google => coreboot}/memconsole.c (100%) > rename drivers/firmware/{google => coreboot}/memconsole.h (82%) > rename drivers/firmware/{google => coreboot}/vpd.c (100%) > rename drivers/firmware/{google => coreboot}/vpd_decode.c (100%) > rename drivers/firmware/{google => coreboot}/vpd_decode.h (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e6a8c271e79d..62ddee473f55 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11069,14 +11069,14 @@ S: Maintained > F: Documentation/networking/device_drivers/ethernet/google/gve.rst > F: drivers/net/ethernet/google > > -GOOGLE FIRMWARE DRIVERS > +COREBOOT FIRMWARE DRIVERS I won't weigh in on the Google-to-Coreboot naming, but if you're doing it... ...this leaves MAINTAINERS sorted incorrectly. You'll need to move this entry between "CONTROL GROUP ..." and "CORETEMP ...". > M: Tzung-Bi Shih > R: Brian Norris > R: Julius Werner > L: chrome-platform@lists.linux.dev > S: Maintained > T: git git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git > -F: drivers/firmware/google/ > +F: drivers/firmware/coreboot/ > F: include/linux/coreboot.h > > GOOGLE TENSOR SoC SUPPORT ... > diff --git a/drivers/firmware/google/Makefile > b/drivers/firmware/coreboot/Makefile I think something about how you sent v12 has broken a few things: 1) some aritificial line-breaks; the above 2 lines should be 1 line. This breaks `git am` 2) the email threading seems missing v11 and most (all?) previous versions didn't have this problem. Brian