From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 177AF3B47E5 for ; Tue, 11 Aug 2026 20:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786480200; cv=none; b=NN/8qf3eUAqXwcwQG5U/1EpNMdpOmwRoV6kUYQx0ikJU2NI3hgantDSrWG3+1Y6WJYM/MyRbWwTSASiSvzi4k480nLOHwEt49FT+dkRHmaT0wsZtqPnGqCgqgsRZEnZLrSRAX8AWxnaB/7EaDXo5tIXcye3CdhKDjsXjhZlNSt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786480200; c=relaxed/simple; bh=hxGqZ8OqhiZUT9g5By3twhe2aIYif6OP6YW3nUAHHLw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LlClv3/iV8edzaZEAUBrtuBBt664xjXszOUbcEzMGwebjoW43mIH/xLBW8zpOS/ixpxJQjf014YvgsnBu6HgOK+SzAcgdD6CJ7+eJFL+4OIhfjQbCydc0IIsxViry7mYgVH6RIbpmG3K2TwTamt0zxVXHjhKyxYzRn1FwU1KCMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LqjKCUEY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LqjKCUEY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B1311F000E9; Tue, 11 Aug 2026 20:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786480198; bh=hxGqZ8OqhiZUT9g5By3twhe2aIYif6OP6YW3nUAHHLw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LqjKCUEYCrsXAD0qSJw/TY2MKEaRvqIkdosgZe54vDIXlmqJJ+3GhQpRnyLGiQsp4 hCn4HL1vreO1yVzsLK56Y9fRaP4xbog6xxwr+g2C3NWL2HJHcwvkgKAc4+UGTS8RIP 1+mtxq2q+RFOLIvlIST+TIPE0FxRcHFviiuI8NVbtKqH2t8Vy/2otW1uB0Idcs8N8o LUTv6rZMFd4HWVj/fV5OJKtB87mw3N4eChi0Ze54qtLO49lKHPCn3xtXSF3KRBZMCp h9Fcl60+E+0tvJkPPPJzexn4urjzs0BPiTwiIK/yj0kXJscbEBbzOUnlQjJMkiOwYm SbCUA9YDcF7JQ== Date: Tue, 11 Aug 2026 14:29:56 -0600 From: Keith Busch To: changfengnan Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Guzebing Subject: Re: [RESEND RFC PATCH v2] nvme-pci: add adaptive interrupt polling Message-ID: References: <20260806031058.40176-1-changfengnan@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Aug 11, 2026 at 10:32:35AM +0800, changfengnan wrote: > The code looks much cleaner when using dim, I'll see if I can replace the > sample-and-poll logic I wrote myself with the dim library.  > I ran a quick test on the POC patch and didn't see any performance > improvements; in fact, there were quite a few regressions. Maybe some > parameters need to be adjusted. Yeah, I'm just now testing mid-tier devices and it's also performing a bit worse for high throughput workloads. But I hadn't really tried to tune the settings here, and maybe my criteria is all wrong. I was mainly trying to see if we can utilize the dim library before honing in on the right implementation details.