From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D15F357CEA for ; Tue, 11 Aug 2026 23:36:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786491420; cv=none; b=VV2Ixtff611n5AqoewKjfdU+6cLEMWwQqigOpCkw2AQvPOum8UKxUNj8EZibhmNp5F7w4SUSJEJzqXHnUIAnR234NZ2luLcO/7v/droku/B+T5rMu/8Y7qKg1Hdsh4GEPQpExTLpiOlP+1kL6OerCAt4yvH8EGXl5K04C1HZhLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786491420; c=relaxed/simple; bh=a3TpYWJWdTe/MyuHxHwsshUEyW8k8b8pCD3lfq0uAYk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gdjTL18wezK5Cf0431MaGGiDwQsUIcTx3LikiFdg3fnZgIl+toN7mCI6Ea9c9giKkzNNB0301ZSSy62Z7zGkPdVbW+KbmHJ8PuSq4KG/PpxeJv5h49GhsuOdkbKWuJmt1xLu2uYYon4Rn3I77EeNmKhDHUjcZ5c5x2qOBL6exUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CK0/SYbY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CK0/SYbY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5260E1F000E9; Tue, 11 Aug 2026 23:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786491419; bh=GFX016VZdFBU7HNnvD6yh2FXR6VJUV1as4xnHM0gksc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=CK0/SYbYW7X65D1Qel0r4HLPbZGiJ2w8Y41Pdxgelv/tpdDtbI4L3hN9IA8T6brH7 vuUlLCFWPz6e9wJ9hiFi9UMmyBHoJ6LKyYqk35oBxxYs4jb7EZyV4cYzioOUbmGgfF IcjpGmOqiQhiDUGPsA8xeKFCm7UQTNNK+pK8bOnydmtZQGJRoXQeLWR3iDY6SyOr5w v/0l2amSn4DEVLYc9DO2tCY14Gu4xLPyAODEEocj5RVXt0cSBjnUoW3qlf2wm7Bdkv k4v5KB95uTnqtFa4Y0iYjFMREA0/HDhn2Msh8cCIKuoWpzFbQ3ZqB/H5wZ9JVoJuyG Shm8kcaRbPXEQ== Date: Wed, 12 Aug 2026 07:36:52 +0800 From: Gao Xiang To: Michael Bommarito , Geert Uytterhoeven , Guenter Roeck Cc: Guenter Roeck , Geert Uytterhoeven , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , SJ Park , Gao Xiang , Gao Xiang , Yue Hu , Jeffle Xu , Sandeep Dhavale , Chunhai Guo , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, Chao Yu , David Hildenbrand Subject: Re: [PATCH v3] erofs: cap LZMA stream pool size Message-ID: Mail-Followup-To: Michael Bommarito , Geert Uytterhoeven , Guenter Roeck , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , SJ Park , Gao Xiang , Gao Xiang , Yue Hu , Jeffle Xu , Sandeep Dhavale , Chunhai Guo , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, Chao Yu , David Hildenbrand References: <20260728065447.91511-1-sj@kernel.org> <87853c96-cc8f-49e6-81b1-02bfe409e372@roeck-us.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi, On Tue, Aug 11, 2026 at 03:37:38PM -0400, Michael Bommarito wrote: > On Tue, Aug 11, 2026 at 3:35 PM Guenter Roeck wrote: > > > Any progress with fixing this for v7.2? > > I would like to fix this since I started the problem with the original > patch, but I feel a bit stuck. My v1 and v2 patches would not have > triggered the build failure, but Gao made valid points about the > trade-offs that led us to this v3. Maybe it would be worth your > opinion on the config approach in those earlier patches? > Sorry about the late reply. As I said, I really dislike hardcoded range, but it is an issue that no NR_CPUS definition on CONFIG_SMP: I wonder if the following diff resolves the m68k issue (I'm not an Kconfig expert but it seems to work on x86_64 !CONFIG_SMP): diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig index 8ca1767dafb6..2dfc313588d2 100644 --- a/fs/erofs/Kconfig +++ b/fs/erofs/Kconfig @@ -134,7 +134,8 @@ config EROFS_FS_ZIP_LZMA config EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS int "EROFS LZMA default maximum decompression streams" depends on EROFS_FS_ZIP_LZMA - range 1 NR_CPUS + range 1 NR_CPUS if SMP + range 1 1 if !SMP default 16 help By default EROFS allocates one LZMA decompression stream per CPU. Thanks, Gao Xiang