From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 930D93AD52A for ; Wed, 12 Aug 2026 09:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786525604; cv=none; b=dL9Pn38Ww15dmlM+uxaRzh1YifAHeLpZIQEgmKFVEwrV2+7XWhdRDfPXHTzwI4bzOzV5QotgIf3eE8Ryb3OxI0aNaX/Mj6zoc9U/cN8FtDb2oePytBBe19mvZeOcCo0bd4+7KLFsJ2cDhoRyjEHg0cVvOkbEYVAdydD47k870aQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786525604; c=relaxed/simple; bh=X5S9E4X5047qg4IL1t6gHrjXkXNH7oUBhBJAJFc0drs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u2tRE80STSJGqdvPBYA4J3EOmf1OoPupyzeT7KmTmSGvEUXSDBLZ4SVP9iB3sOK6UXCcKwTtEWKoKxG9QYyJembSNbBimQl4/jvgTM4eBO5GSiEVR3JEitIxguzw/mTdUrKgeac+SAZI62fZSuUTmpOC7W7lDDBu370Ovv5HkAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bFJa4/WC; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bFJa4/WC" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4957eefd361so5066805e9.1 for ; Wed, 12 Aug 2026 02:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786525601; x=1787130401; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hq1fRISwW1tZw3dG9wLdONLNZyIJDDT4CwKD1KvT68Q=; b=bFJa4/WCk2va8bPBFp+fu0p8MNVF496Dw5Tr6UTwkLOQLxf2NKl/9FfrXW44W6pjl+ LnRyy7rzs3VO+SGiReXBZvVtf2MGqpwYlE+Rxmjv+80BXBa2ThGaeSWjijFej6EqTTys IgYDTmEFd3Xpmm2FK3QG6/pqyHcMaUROAS/hVMKNPHJuSBZ65SF4tuvZ/4SEt8D0UWRF +KhVy8pchBwKqxs+vkz07PJg6SeMmInfcHDpcKjUgzeuhgmoPQ0m46mxgoyUM0aod/yJ fE9GwvH3dhwZ+/2jwIf0GHYp8Ki60qOToBUF6nlmmQTLgnkmnEsTJ9EHrWBtNTpuedHM WDHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786525601; x=1787130401; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hq1fRISwW1tZw3dG9wLdONLNZyIJDDT4CwKD1KvT68Q=; b=HA4IgNPeTzGlxeUi6b1Qg1zsAZSmWmP3zyWvJIFUoGpSmxx9btlqJFnl2nv/IXqOOZ FVVN1AarZf2FeRyvPIrPzmC1bbD9pBsCNHNaudhosEbHyBiYTDvB6wATqdzDVTgbHvox u5SayJQTJ41RXP+RoHUQTmZFGBtpcFaJ+trz/NEZ8bp/UiM7BZ+YQz5c854Jcdcb3VNU KpVHvh2YOL7Bh0YAYW/xSG29duWk5YY1gyLWMnJZUdnPeunH85m80bjPuFalw3o+6GgT BNeDdx59P8KsBZ3iv2QMEUeU6M9cUyqR7QPBh8UUOkO+9Bl4FCXP26HT6CJ7BW0dZ/Q/ DU8w== X-Forwarded-Encrypted: i=1; AHgh+Roh89tibP8K08nm2das1axvjjjez4Rju+ssx/Py3IXj8V+1oMUyD/tzCs1R0uBvTmxJ53kXH7pcrgI7CiQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxOhNDOLDlnkzo2oT5HhWJGUOAemdOawDJArk/tZXCalPTVJQ// 21u34hsW854+MkoM+8l8L0wbLXIhLIXF8cjzu3TgPaZNLVw+vDzZu72GTPTGJZxv4oDcmw== X-Gm-Gg: AR+sD10dDDVxysDdfsz2alNquxrFLtdFopyzy0Ynmp1VzYknp21fh9nKY14VLkiAnN+ ZSeIvjpcH2wPB0OC+9cG9SKQ0h4rOJ7AzSjtg2lHi/i0HI/eQfPZGCXR9IF7k6zYHhjxql3Bd4D +VFnS58leqUw+CHfaGtvv2kBzebDHU6xFUXVInevx5h+BqgN61BopbpT29vu0WGVk1nCe7hoJzg 9fMeoXH3DXVy5UelnzjIHrHN+qFw/mLFOvNUaYW/MX+NHDeMKIhNsjKs4jmStPrkiiXKS1j5ZvV pUQBnT82P8P5y1aA1mjI2XcLb0pdcRhAqqaOYRvn5R2gP1l0MX9WCzfDCcVpDkSI8fuRZV2+BMu 91Bo3c7SCIsYnLpdP+ndZ+wuxfuWsj9wfhC59E/gLa1qc4gW6qT3RhrZJfg2MS1Njw/8jha5lgf +nQdjaqsHmjYzmfrwCgft+fWE/imYkWr04qfXQLF4TO+o8ZtnbTxs1TJ82 X-Received: by 2002:a05:600c:a05:b0:493:a613:56b2 with SMTP id 5b1f17b1804b1-4997c1256c6mr39626405e9.8.1786525600743; Wed, 12 Aug 2026 02:06:40 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49977e882d8sm75480805e9.4.2026.08.12.02.06.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 02:06:40 -0700 (PDT) Date: Wed, 12 Aug 2026 12:06:36 +0300 From: Dan Carpenter To: Raushan Kumar Cc: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: add missing newline to sysfs_emit() calls in audio_manager_module.c Message-ID: References: <20260812085117.103875-1-mitramaurya80@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260812085117.103875-1-mitramaurya80@gmail.com> On Wed, Aug 12, 2026 at 02:21:17PM +0530, Raushan Kumar wrote: > sysfs attribute show functions are expected to terminate their > output with a newline. Add the missing \n to the format strings > in gb_audio_module_name_show(), gb_audio_module_vid_show(), > gb_audio_module_pid_show(), gb_audio_module_intf_id_show(), > gb_audio_module_ip_devices_show(), and > gb_audio_module_op_devices_show(), as flagged by checkpatch.pl. > > Signed-off-by: Raushan Kumar > --- No, this is user visible API. It's too risky to change once it's been released. regards, dan carpenter