From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A2EB3AC0F1 for ; Wed, 12 Aug 2026 09:13:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786526018; cv=fail; b=CjAWrbYgXR+SCl5R3E6iAVcDE/5VyrjJMT9A+HvAy5zVLBoliuowonbNNUh9jrTDU763B6vK+QBgsEOu+qQ/HkOf0ox30Ogiu051A3TST5vY/VDHiDi1Jw0/DU+pbK2pplOK08ZtIwJdLDVxTMvn07ftrT1T5xkugIK2ZhmbR0M= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786526018; c=relaxed/simple; bh=7xR7XdWMfqb5/7GDWxk3XnF7lsnCaDk+rTTOTp+E6zE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aL4J5sp4l1HBZQIrHR6OpxVMFHNnhrFTO6e23eTCFWEHBJf+YItpqM3Ar2UY18elXsXtILc9FXirkCSpKHp/SxByxfCq0sJL0+wXzpEwr6snr/GIihloHSUIc73trWQ5RLQibJKBSwx+5o1oaV321fScadLDzsUS/90p4JdWGZg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=Woz/KOCq; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=yT7xu5WG; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="Woz/KOCq"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="yT7xu5WG" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67C7odJ4006663; Wed, 12 Aug 2026 04:13:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=PODMain02222019; bh=eGobjrGvXTwpRpl0xL erM7BiUNtERWSJbrwOUXCOYYc=; b=Woz/KOCqj5m6P0OlDxV7qDFoiXXsCtK+zt 5h3dw/wDnF0tmbIJPQu44I46kVzpkYw5Ze1PS/HRnABgIpRpTXgVLs7gooTyktFR uSW1YB9tXZvZ7O2VzPQfCXT/0BWNk4tPYnWwveVmklasGRgMNQuUKGub4OP1D4ec DLnYpgUViKBN6mLiu9FFjGdEd1WjsaJkyV/AU8QesQbecoC2p5QSfGjUSKQum+rK TPSb7M6yvNKM57CFJ4dEFIdSzRgJ7N7ji/i1VbeVwIO8kQ4tgSraETycWrQmWSPP sUyfH3zAFoBLMIKOWy8glH2Mn/sqlJsSngNMAROWgQuBUXErwttg== Received: from ch1pr05cu001.outbound.protection.outlook.com (mail-northcentralusazon11020136.outbound.protection.outlook.com [52.101.193.136]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4g0msjr2r2-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 12 Aug 2026 04:13:30 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wpC+HGy7ejm/o/DEX5aZMCzk+FH5d7kYyByBcZINg/Sdv4Y6MfugAgrN0LuSCQThHGGCaq+OIKH+nYd2vzBEANmGvLKQ8THOqAdF9zmLHVL3ymKMWd+c3hXeDM749Us3Ec9u+3NKsnz0VsR656N92JjJVosjhsUk8GCbclgqqYLd9nEpO+Jqsum+AYWt3USI3m0dqv0iAIl2fMIovo+9p41oAYghLbHjTtbZgDtulicPt2KpKL62LThl8KzL0hXQVWdZGt7PZPi8wxqu8GQ5b0nrWjJV3QWoiLCGT/aV27RmNLgTRKgxGOHJ97DNBaQDXxaQSLN6wDVh51FsE1pJaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eGobjrGvXTwpRpl0xLerM7BiUNtERWSJbrwOUXCOYYc=; b=yrWh9GrJugOYDTUTGleLA3eg0cONgS6AiUGYG37oeozlD5Nb5r9pgmtSZigbdcI+ZUflonWqOit4V6ASeT8f8piB/hOe+dvhC6w8k1uEpLjNb13B5+ODc8jqbJiIyi11i5I7Sa0MM3Fc49ToZ6pn6WQZEtxnx5Sx4PvVt6pF2BtcUCBYPH2t27r1LAKaEfVBJsBzUX4+7u6FM0yoEJCR/xW8i0WdzIkoHmr45VrYKKGQfQRIS2U98b/v5BQhu4/6jMMcK1TZ0MCjNbfI+0lomBRMGd9t6t3T/FcSava05/kby454jrUX3ZtKRST/7xBDfoOMbluaBagVYxeSE0M/aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=gmail.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eGobjrGvXTwpRpl0xLerM7BiUNtERWSJbrwOUXCOYYc=; b=yT7xu5WGBqkKGKZIHT6H+a0sivPYTGbkF2g3E7PF+50emRwYZGxMc39bBtIZFkfTy/LlDsL0+5iZ3nBxDxQ1nu6sOnJ/HgcPgpVwu/k0hXF6+qTJdH3AApijxCQ6irKBHoDC6gOQ27QymiNdi91mlJWIGXRKjiLfyzbNAoOwSWw= Received: from BLAPR05CA0040.namprd05.prod.outlook.com (2603:10b6:208:335::21) by BLAPR19MB4625.namprd19.prod.outlook.com (2603:10b6:208:29b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.14; Wed, 12 Aug 2026 09:13:27 +0000 Received: from BL02EPF0001A100.namprd03.prod.outlook.com (2603:10b6:208:335:cafe::2) by BLAPR05CA0040.outlook.office365.com (2603:10b6:208:335::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.339.3 via Frontend Transport; Wed, 12 Aug 2026 09:13:27 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BL02EPF0001A100.mail.protection.outlook.com (10.167.242.107) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Wed, 12 Aug 2026 09:13:27 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 4B7CC406544; Wed, 12 Aug 2026 09:13:26 +0000 (UTC) Received: from opensource.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 36DB782025A; Wed, 12 Aug 2026 09:13:26 +0000 (UTC) Date: Wed, 12 Aug 2026 10:13:25 +0100 From: Charles Keepax To: Andrey Golovko Cc: Mark Brown , Pierre-Louis Bossart , linux-kernel@vger.kernel.org Subject: Re: [PATCH] regmap: sdw-mbq: don't call an unset readable_reg callback Message-ID: References: <20260811184500.5312-1-andrey.golovko@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260811184500.5312-1-andrey.golovko@gmail.com> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A100:EE_|BLAPR19MB4625:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f9f8831-ef3d-44a6-944d-08def851f82b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|36860700016|61400799027|376014|56012099006|10067099003|11063799006|18002099003|16102099003|22082099003; X-Microsoft-Antispam-Message-Info: eiVXjrF9OOvPX92lgDNMv2GyUb1frGv3BN2zN1rziCfbBhGlNTou5jICJIIoNEdZU0eH7BXrggoRcS8fW+7bf5nBea9rpKYhZA8oab9eZLN4chDTkROROaWRFlSpR5VfE2Sw4nkjrdwKeYHaanLrb+4ah6pF636nk/aeSb1W160uj7N8xAs7wWaA831qwleMRn8lvhNLwF98qomTic2lcqdpxDPPzhtBwiVVD3+GxvRWPmstgexSKQ1SRDBJ3P3bVJp9Foo43r/QJW/BoXhvAf5Vyu6ZyQ9sxW97hmAETpD4pW5FM+GyVIzMpiBoUN5ZYgf8w0DhNRmICXZz1JAg+ojqKL6ExpnTzSz6DjYFBmdquZs8WwhGMiVW1YegglaVyqwTJW1TPZUrdbmjK437dyZqvvsurkKiKuiK5N64qvtNThYdk/fxb19dNxu+mSD13rK0hjVebqKgkaRjdAuTRJAQJQKylNJhTct1NOy1aMdQK6zax4Zo56Me52H+CjICAIJ3WVTzCHI2ICznJGhOY0XyijwYiOpd5QNWRrrh+rsJVxEt0q5YZ/blHc2pS6it7rP8lCBqNJlC04MxdYX01IAOvFqAkdLA3udWvNI0HuJy4IFg35DEx+a8JY0lRpOZNaUf+76GsoBs0yAf8dnMLl6Ma2sCm7zx/zqUb3RldJ3P5Zs4Vm67r/XN00qtvdpllQw/vydrhhixP0K9jRaH+Q== X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(36860700016)(61400799027)(376014)(56012099006)(10067099003)(11063799006)(18002099003)(16102099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: //wFYMNOYm4I5LGzpVoscDtt1FUG3klPvAkvBUC5XMMJSdaWtKy4bwvi3JOCu87pjtb4gF6BiE4yYDZv7akZZ+ITcv4RIWgvfPPRyLxNPs1+Xw/m43fq+Zp1IUqhkeZBPRP+pli0pSTOPGEjiE634XJeqh9aoa1Vb+qMgDp9jZ7e5S/sJ3ESQr50Swn5CA2UKWxRri61XD1d9tMPHRYlTOsgK//OEoS+L4FAfpDS7V5DiaXMxcEbA4wh8dB6ZMN5aYnkTT8h3ZNDWLuVD04UlboAd6SST6lqvVQ3ic0PtdClKf75IWTgxzBcf+AHhvXrDgEfRfQo1Th5oc/pInEsRuoKultMgU1ZnRoSiIayJURXVSF1iS9Se0E6+WAzxItkeaJbW7bDA+UzMZjJnaJkCkPLhoQE3nk68Ol+rDnuV8oA3jBj3+Jr98J99WX3zIZt X-Exchange-RoutingPolicyChecked: tLmE/eiStz9CidmbtBsT7g6HbyvfH6TdYA0Iiib5Z6cX5m32p3pY4CeSD2wYR7knqKNXqIb/0TQVL8XCKHG6Jxu4Vq51jYGzu/YA9wr1e6p6xJqE3PaIwfiIvBs2jQ8JcLRqEWaEstc/WxX2wLFFi1h5cHl1F7EAnDvxoRe7BAzYtwcMDvGCTv9SnUbOIGi5ImFtMvf785QaJqFH4EfJ3DxjIwjXhUHtcdGUMYkrGfBc6EIbyTma75JAG6orOyUa34XVikYVnODDAAWpHHaNl8518wywztdn9VCLp0bUWYTGc81B5wdI6M882hoZhcj2RU4MDX8gW9C55E7u9Ep4iQ== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2026 09:13:27.0770 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f9f8831-ef3d-44a6-944d-08def851f82b X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BL02EPF0001A100.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR19MB4625 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDA3MyBTYWx0ZWRfX+/w5bA5/B9Ny /dM89QQXcnvAwEYwqb+6UYrbY4Jo+2VnjKVGKLHCqdk7K6Uv32cBjb63A5jgwD2BgDk4rr+JuQo +CgBgnr8oIvWQNz0O4c7YJQfYTkRR3uDtMddd18JTFITzqdaTOQnIf9WdparkZcL10R0UIfqzg+ 7CnalG1QZif5sYwSVg4BcZzjTxDiPpiHfO/JL6VhkvavsoIz3JxvDd3paKSHrnaZlDuHiizIK5g kqpbe7WlK/+Jl0qIlaolo/TQYy3Y0p9lrdjVc40AMQdgPtRXH2CEtLoqBvkrdtDfBl7L6uD2CyS /eUILatUiOyJTEmOUo4xPfCobe1EAJivHt5St0mZbrBDR1nPh9MGADocb0LyEk0wPsi6KyUbBU0 HeihAK1wujBiAtD/63Ks3D1O4fSvec+GIuFEPzRWuOKEmsVfXmVSMzMMvh7kOa83Jsb3IW293yy SDjGrqPGpGSc4LTQkqA== X-Proofpoint-GUID: dXg4j1-y6A3_KOaoX4rioJhn6EjZcTCL X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDA3MyBTYWx0ZWRfX4dYuOtZVFPt9 EPffInzQpJQ6rsqUWodAFu3wHkKnQiIbkBj1ErIUj8wsQV/5ACcCK129a9lKEndS3fW7TgrXEvI njR0356OaaXutqi+s6xx5/mYes5TQ6M= X-Authority-Analysis: v=2.4 cv=VdTH+lp9 c=1 sm=1 tr=0 ts=6a7c393a cx=c_pps a=7KKYEoKmDP67vAiH5G4Tpg==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=KfkQE9S9VqCBgivYGm0O:22 a=pGLkceISAAAA:8 a=w1d2syhTAAAA:8 a=40dnUBctthzn2g40UdgA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-ORIG-GUID: dXg4j1-y6A3_KOaoX4rioJhn6EjZcTCL X-Proofpoint-Spam-Reason: safe On Tue, Aug 11, 2026 at 10:14:35PM +0300, Andrey Golovko wrote: > regmap_sdw_mbq_poll_busy() decides whether to poll the Function Busy bit > by calling ctx->readable_reg(), which is a straight copy of > config->readable_reg. That callback is optional: regmap_readable() treats > a NULL ->readable_reg as "every register is readable", and drivers rely on > that. es9356 and tac5xx2-sdw both build an MBQ regmap without one. > > Since commit ca1b11b36d82 ("regmap: sdw-mbq: Allow defers on undeferrable > controls") the poll runs on every -ENODATA, not only for Controls the > driver marked deferrable, so any of those devices answering > COMMAND_IGNORED takes the kernel through a NULL function pointer. > > Treat a missing callback the way the rest of regmap does and poll. > > Fixes: 5bc493bf0c37 ("regmap: sdw-mbq: Add support for SDCA deferred controls") > Signed-off-by: Andrey Golovko > --- Reviewed-by: Charles Keepax Thanks, Charles