mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Baojun Xu <baojun.xu@ti.com>
Cc: broonie@kernel.org, tiwai@suse.de, 13916275206@139.com,
	alsa-devel@alsa-project.org, shenghao-ding@ti.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	k-yi@ti.com, henry.lo@ti.com, robinchen@ti.com,
	niranjan.hy@ti.com, pin-hao.huang@hp.com,
	Syed.SabaKareem@amd.com
Subject: Re: [PATCH v1] ASoC: tas2783-sdw: add firmware download status check
Date: Wed, 12 Aug 2026 10:12:23 +0300	[thread overview]
Message-ID: <anwc1w5oCiU8qKMN@ashevche-desk.local> (raw)
In-Reply-To: <20260812052124.1843-1-baojun.xu@ti.com>

On Wed, Aug 12, 2026 at 01:21:24PM +0800, Baojun Xu wrote:
> Currently, the firmware download is unnecessarily triggered on every
> system resume from suspend, causing significant wake-up latency. However,
> this step is redundant if the AMP remains powered on. Furthermore, certain
> memory pages (addresses > 0xc60000) are skipped even after an AMP reset.

...

>  	} else {
>  		tas2783_update_calibdata(tas_dev);
> +		/* Mark the AMP firmware download as complete. */

> +		regmap_write(tas_dev->regmap, TASDEV_REG_SDW(0, 0, 0x07),
> +			     0x22);

Make it a single line.

> +		tas_dev->first_hw_init = true;
>  	}

...

> @@ -1102,7 +1108,6 @@ static s32 tas2783_sdca_dev_resume(struct device *dev)
>  		regcache_mark_dirty(tas_dev->regmap);
>  		return ret;
>  	}
> -
>  	return 0;
>  }

Stray change.

...

>  static s32 tas_io_init(struct device *dev, struct sdw_slave *slave)
>  {
>  	struct tas2783_prv *tas_dev = dev_get_drvdata(dev);
> -	s32 ret;
> +	s32 ret, val;

Why is 'val' signed? It should be unsigned int (which is what API requires).

...

> -	usleep_range(2000, 2200);

> +		usleep_range(2000, 2200);

While at it, replace with fsleep().

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-08-12  7:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12  5:21 Baojun Xu
2026-08-12  7:12 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anwc1w5oCiU8qKMN@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=13916275206@139.com \
    --cc=Syed.SabaKareem@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=henry.lo@ti.com \
    --cc=k-yi@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=niranjan.hy@ti.com \
    --cc=pin-hao.huang@hp.com \
    --cc=robinchen@ti.com \
    --cc=shenghao-ding@ti.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®