From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AB142D94B5 for ; Wed, 12 Aug 2026 14:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786544006; cv=none; b=LiLeolh0pReIjxkxx2U6+ORiwRaIiylFhGmjC++27HfzB1/f8J4NTgEAG6A6PrmojA+2B8kAVVvsT8QGUOovYtfQRlY+19EDbAlFhG2ABqRlfqOLOvIjq+YXKV/75AaXNEyFCRrPwZ5UgXewECdZ8t39CN/PxQX/qaFW+lsbmCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786544006; c=relaxed/simple; bh=nqNZd4luLVskLFGaMfZKB6GSUaspmYyT0opsNtcUAvw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nsWqD6TW7HQ/rIhYWx/MWZK48pzLm9uoi+5N3DBrsnTVM0eJLmJuzQEna6JwRXGlUZmDxm0UO2IDKsf5eSP39VRlFg9rMFx5Dkz+pfkI26m7q3LoDYW47jF5hdegWvTqNWYa1N88zBozWNHjbjrq9v8gyFim1v9eXYVE3JZYsqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DBIOqa+F; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DBIOqa+F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EB2A1F000E9; Wed, 12 Aug 2026 14:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786544004; bh=S4MtQJyf6vxe1tj+uu4KyqLyWiap9ANUV+nmt4DryVU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=DBIOqa+Fp8d+VPNyunya13/Z6aaMGm8OKA6TokkV79wrEc2wVtPuaYcrXFLoINZaD 2FKrm2a8ZvGTwv0G0WLF+z/cBFvgjpmqR0xqhAhIepnzNd588PWyB1G5V3foWWN8es y0mb3U6h479rZmD0A6+2v4sZ9h3aRTQMfoOiBv/vOM1DTSKc3OdCsoAL8+iFibgQMd /pMpLJ2DNA9mDA+0vZHS//Y+Ra2s3QaMmyH9qJM9pQ6ZOSO7i1kOU39VJS65mWYEIl obgy0D0h4/0kfj0mM1Gb6f3aGbGUAQ6irKf4F+tCTHFWFRRXJx5x+IuTliVyZNT7Zr +xX30vIipG23Q== Date: Wed, 12 Aug 2026 22:13:14 +0800 From: Gao Xiang To: Geert Uytterhoeven Cc: Gao Xiang , Linus Torvalds , linux-erofs@lists.ozlabs.org, LKML , SJ Park , Guenter Roeck Subject: Re: [PATCH] erofs: fix EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS on some UP platforms Message-ID: Mail-Followup-To: Geert Uytterhoeven , Gao Xiang , Linus Torvalds , linux-erofs@lists.ozlabs.org, LKML , SJ Park , Guenter Roeck References: <20260812131144.30802-1-xiang@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Hi Geert, On Wed, Aug 12, 2026 at 03:34:58PM +0200, Geert Uytterhoeven wrote: > Hi Gao, > > Thanks for your patch! > > On Wed, 12 Aug 2026 at 15:12, Gao Xiang wrote: > > CONFIG_NR_CPUS doesn't define on some UP platforms (e.g. arm), so this > > can cause make oldconfig to loop indefinitely when CONFIG_SMP=n: > > > > $ make ARCH=arm allmodconfig > > $ sed -i "/CONFIG_SMP=y/d" .config > > $ sed -i "/CONFIG_EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS.*/d" .config > > > > EROFS LZMA default maximum decompression streams (EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS) [0] (NEW) > > EROFS LZMA default maximum decompression streams (EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS) [0] (NEW) > > ... > > This also fixes EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS silently becoming > zero (and thus breaking decompression completely?) for "automatic" > configs like "make allmodconfig" or "make olddefconfig" on architectures > where NR_CPUS depends on SMP (which is most of them). Yeah, unfortunately.. > > > ... > > > > Reported-by: SJ Park > > Closes: https://lore.kernel.org/r/20260728065447.91511-1-sj@kernel.org > > Reported-by: Guenter Roeck > > Closes: https://lore.kernel.org/r/87853c96-cc8f-49e6-81b1-02bfe409e372@roeck-us.net > > Fixes: c9b47e6b2311 ("erofs: cap LZMA stream pool size") > > Cc: Geert Uytterhoeven > > Signed-off-by: Gao Xiang > > Tested-by: Geert Uytterhoeven Thanks! Thanks, Gao Xiang > > > --- a/fs/erofs/Kconfig > > +++ b/fs/erofs/Kconfig > > @@ -134,7 +134,8 @@ config EROFS_FS_ZIP_LZMA > > config EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS > > int "EROFS LZMA default maximum decompression streams" > > depends on EROFS_FS_ZIP_LZMA > > - range 1 NR_CPUS > > + range 1 NR_CPUS if SMP > > + range 1 1 if !SMP > > default 16 > > help > > By default EROFS allocates one LZMA decompression stream per CPU. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >