From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A3D32F764 for ; Wed, 12 Aug 2026 13:06:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786540019; cv=none; b=dQiDLSNFdsjMFsHSe/j5E4db8xBrk5h+hYfi8mQvU2ZjnrQG7pdiOdoW470ExHMhUow1GmTxGSZ9UNn2Hpt3ERM/njmfHEKAYAwrDUMgVlhvC+GVUSCi4W8vnkONkfU9VHFjF0gnricNxju+EIQWSdFGK/RGY6QG1JEsgFJHSGo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786540019; c=relaxed/simple; bh=VN9nETLLM49uk9K+kGpFqBjucgEsy3vN/n2HkUefNRc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mQzjP7HIGQfC84L3LDRLV4Gpg1jnGRmk3Nj4hYiCBwXIyWBW37pzrwW+f6jxQhIJsZfJfO9h3nEp+FOLarazrVldRMBmtAzcDmt9KpCbDO6Yxeko5HC02vknZiTGroJ3I8phjzZhvdIZduW9345yQRJCFL0bwZkwSjD2MC2C26s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ok7X9YeY; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ok7X9YeY" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4953de5be0aso6489545e9.0 for ; Wed, 12 Aug 2026 06:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786540016; x=1787144816; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=teFT6NRTXr4zIRuGi3t1INSLzXK+rPxsyQcQYNZ+t2Q=; b=ok7X9YeYxz4faKYQ8pM9rQUwK7BTzp5F8EeHL83K6zGU9h+S5BKylOXtCDgTNCAxU2 kHvmIiQdci/7tfCZifWAqh0XjymGnorzMB/ov+CXeO4VcJvY/x+yMZxKKL1mBzKybMom omANZ680+I2LE/99icE4rO3Hu8gGK82yr4AXejW4eqC8zsQoG8udToMhvY+GE1zoIJ5s hXIk5M7xbKLUs0X0juTIaRKEkiB8wmzcrSMpNaGYap7hy9hjs0HLefMk7qskSQl0tc0F H2+DW3KBnLB6Yqh874q8Q5+1zdRp08GJeHrmzDzlr0v7zMKR2clhi16+Teh79q1Wpwu/ o/FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540016; x=1787144816; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=teFT6NRTXr4zIRuGi3t1INSLzXK+rPxsyQcQYNZ+t2Q=; b=nDzZIM6JnTQ2R1tH8mMJQiY7ELDBDpm0REHFrqgwRQ8IGxDMMA1roZFQAGuGn4uKS0 yA+Xf0ykEZ2SWqIN4E5pG99jJAK8NJEXFeoI1MadAzjjtZLNY0771M4kWU3GkObo6err zx9jx9BPeYruxu55IZWzUhvCjbfMWcRUFHhm+Ath2AXtOZ+Ce0RUPzhNQYSctYRu7ZKD KF9UJBU226MlGW/FEE5NKCVMYU7kDQq4cSgxHio+TdvV+7UQHfm8DXEUJWlQpxsnEGvU ELpzpWF37Gup48qyVtx52Kfp7hPagqDhxhqy1djPRaEE/iMDwxl57OjT017HLd0m+Fcy rhyA== X-Forwarded-Encrypted: i=1; AHgh+RoYqjv5YW4Q+nsKG3TfWSUnhc+tbjW6gqtkpXUArz3t7V+zccHU/Q6WMtH+X8tWr/w142lB6/3bzflv2vA=@vger.kernel.org X-Gm-Message-State: AOJu0YznxaVcKA+ZAko2crC92yoV0b6vpkDY24WG/spFGFugMNuY2r+w oS9fpHdbse0Ys8ib7VZaiVcjeNLZ4cp1leknqwJApMZ+T70jKYRXMtif X-Gm-Gg: AR+sD13Dj44Qia1Vqz8mN6F84gbMMxgw/P7253/TaAfHZdcr/DCVTMlxEmKnGIQvit5 +TmXwydb/DYJHHIcxKaLGc9OvfBf8JEmrVKFWC4GmXdiUaTbRbfoaiwOaNU3s3zhQVhpEN+HXIF AcELBS9IDFPyqI9UglPhg7zs+Fgnbz0hXTwSZ4KsPL0e7xOtTR/otx0NWHorXiTqZDnEG/P0ng3 lj9uyN1wneXfdmWe4AUp/wuTV507gh6bkdQHNrqATp8kkzFAvHkWlLkYS3XrCsDiu/RHiN6yE3t 2EosAlnFI2dWJjSFfOLNQ0LkJLU+j/CzALqqZozMnb0OWJ6M1yjE0aHNKtXbZ+VcAP+KRnB2sGp BhfmmAMW1cJ1SEoivrbkPf0axa+H6sBuLw/IqfFpkd86EL+gehBxgtmj1sgatNSgBS6zsNyKxKL Erk0DFwDYNIxgslJXMbFdNlNZ6aHLm5eVOQ4jd+0R7sx8flGEJ4K/7QzoT8f7HX5fKw/sGz4HEO 3A3zsEfwdHjPo86zEVG33dM8Pt4JBvxBQ== X-Received: by 2002:a05:600c:3b20:b0:493:f318:3bc6 with SMTP id 5b1f17b1804b1-4997c15729cmr62919945e9.13.1786540015739; Wed, 12 Aug 2026 06:06:55 -0700 (PDT) Received: from osama ([2a02:908:185:7e40:3d2e:78f3:cfb2:413d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997ad79e5csm38582755e9.3.2026.08.12.06.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 06:06:55 -0700 (PDT) Date: Wed, 12 Aug 2026 15:06:53 +0200 From: Osama Abdelkader To: Neil Armstrong Cc: luca.ceresoli@bootlin.com, Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerry Han , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] drm/panel: Use devm_mipi_dsi_attach in BOE panels Message-ID: References: <20260811165037.12437-1-osama.abdelkader@gmail.com> <0510ced7-7c91-4b00-bc7f-773a9b6517eb@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0510ced7-7c91-4b00-bc7f-773a9b6517eb@linaro.org> On Wed, Aug 12, 2026 at 01:50:31PM +0200, Neil Armstrong wrote: > Hi, > > On 8/11/26 18:50, Osama Abdelkader wrote: > > Use the managed MIPI DSI attach helper in BOE panel drivers and drop the > > corresponding manual detach calls from remove paths. > > > > Signed-off-by: Osama Abdelkader > > > > v2: > > - break long description lines. > > - add Signed-off-by tag > > Please move the changelog after the ---, or use a tool like b4 to handle that > automatically. > > > --- > > drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c | 8 +------- > > drivers/gpu/drm/panel/panel-boe-himax8279d.c | 8 +------- > > drivers/gpu/drm/panel/panel-boe-td4320.c | 8 +------- > > drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 4 +--- > > drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c | 8 +------- > > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 7 +------ > > 6 files changed, 6 insertions(+), 37 deletions(-) > > > > diff --git a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c > > index 84c21c62a43e..6a74523a6614 100644 > > --- a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c > > +++ b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c > > @@ -359,7 +359,7 @@ static int boe_bf060y8m_aj0_probe(struct mipi_dsi_device *dsi) > > drm_panel_add(&boe->panel); > > - ret = mipi_dsi_attach(dsi); > > + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); > > if (ret < 0) { > > dev_err(dev, "Failed to attach to DSI host: %d\n", ret); > > return ret; > > @@ -371,12 +371,6 @@ static int boe_bf060y8m_aj0_probe(struct mipi_dsi_device *dsi) > > static void boe_bf060y8m_aj0_remove(struct mipi_dsi_device *dsi) > > { > > struct boe_bf060y8m_aj0 *boe = mipi_dsi_get_drvdata(dsi); > > - int ret; > > - > > - ret = mipi_dsi_detach(dsi); > > - if (ret < 0) > > - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); > > - > > drm_panel_remove(&boe->panel); > > } > > diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c > > index 4a8560b4b899..ffcb63f65b75 100644 > > --- a/drivers/gpu/drm/panel/panel-boe-himax8279d.c > > +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c > > @@ -881,7 +881,7 @@ static int panel_probe(struct mipi_dsi_device *dsi) > > if (err < 0) > > return err; > > - err = mipi_dsi_attach(dsi); > > + err = devm_mipi_dsi_attach(&dsi->dev, dsi); > > if (err < 0) > > drm_panel_remove(&pinfo->base); > > @@ -891,12 +891,6 @@ static int panel_probe(struct mipi_dsi_device *dsi) > > static void panel_remove(struct mipi_dsi_device *dsi) > > { > > struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi); > > - int err; > > - > > - err = mipi_dsi_detach(dsi); > > - if (err < 0) > > - dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err); > > - > > drm_panel_remove(&pinfo->base); > > } > > diff --git a/drivers/gpu/drm/panel/panel-boe-td4320.c b/drivers/gpu/drm/panel/panel-boe-td4320.c > > index 23558a76dd72..704d5a9c13e7 100644 > > --- a/drivers/gpu/drm/panel/panel-boe-td4320.c > > +++ b/drivers/gpu/drm/panel/panel-boe-td4320.c > > @@ -204,7 +204,7 @@ static int boe_td4320_probe(struct mipi_dsi_device *dsi) > > drm_panel_add(&ctx->panel); > > - ret = mipi_dsi_attach(dsi); > > + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); > > if (ret < 0) { > > drm_panel_remove(&ctx->panel); > > return dev_err_probe(dev, ret, "Failed to attach to DSI host\n"); > > @@ -216,12 +216,6 @@ static int boe_td4320_probe(struct mipi_dsi_device *dsi) > > static void boe_td4320_remove(struct mipi_dsi_device *dsi) > > { > > struct boe_td4320 *ctx = mipi_dsi_get_drvdata(dsi); > > - int ret; > > - > > - ret = mipi_dsi_detach(dsi); > > - if (ret < 0) > > - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); > > - > > drm_panel_remove(&ctx->panel); > > } > > diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c > > index a70a2e58f88c..94cc675973e6 100644 > > --- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c > > +++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c > > @@ -393,7 +393,7 @@ static int boe_th101mb31ig002_dsi_probe(struct mipi_dsi_device *dsi) > > drm_panel_add(&ctx->panel); > > - ret = mipi_dsi_attach(dsi); > > + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); > > if (ret < 0) { > > dev_err_probe(&dsi->dev, ret, > > "Failed to attach panel to DSI host\n"); > > @@ -407,8 +407,6 @@ static int boe_th101mb31ig002_dsi_probe(struct mipi_dsi_device *dsi) > > static void boe_th101mb31ig002_dsi_remove(struct mipi_dsi_device *dsi) > > { > > struct boe_th101mb31ig002 *ctx = mipi_dsi_get_drvdata(dsi); > > - > > - mipi_dsi_detach(dsi); > > drm_panel_remove(&ctx->panel); > > } > > diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c > > index 20b6e11a7d84..2ab7764d4094 100644 > > --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c > > +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c > > @@ -200,7 +200,7 @@ static int boe_tv101wum_ll2_probe(struct mipi_dsi_device *dsi) > > drm_panel_add(&ctx->panel); > > - ret = mipi_dsi_attach(dsi); > > + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); > > if (ret < 0) { > > drm_panel_remove(&ctx->panel); > > return dev_err_probe(dev, ret, "Failed to attach to DSI host\n"); > > @@ -212,12 +212,6 @@ static int boe_tv101wum_ll2_probe(struct mipi_dsi_device *dsi) > > static void boe_tv101wum_ll2_remove(struct mipi_dsi_device *dsi) > > { > > struct boe_tv101wum_ll2 *ctx = mipi_dsi_get_drvdata(dsi); > > - int ret; > > - > > - ret = mipi_dsi_detach(dsi); > > - if (ret < 0) > > - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); > > - > > drm_panel_remove(&ctx->panel); > > } > > diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > > index 150dff3ab6c3..7d2672578dd8 100644 > > --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > > +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > > @@ -1765,7 +1765,7 @@ static int boe_panel_probe(struct mipi_dsi_device *dsi) > > mipi_dsi_set_drvdata(dsi, boe); > > - ret = mipi_dsi_attach(dsi); > > + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); > > if (ret) > > drm_panel_remove(&boe->base); > > @@ -1775,11 +1775,6 @@ static int boe_panel_probe(struct mipi_dsi_device *dsi) > > static void boe_panel_remove(struct mipi_dsi_device *dsi) > > { > > struct boe_panel *boe = mipi_dsi_get_drvdata(dsi); > > - int ret; > > - > > - ret = mipi_dsi_detach(dsi); > > - if (ret < 0) > > - dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); > > if (boe->base.dev) > > drm_panel_remove(&boe->base); > > Otherwise looks good. > > Thanks, > Neil Hi Neil, Thanks for the review, I just sent v3 for that. Thanks, Osama