From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D73038F620 for ; Wed, 12 Aug 2026 18:40:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786560051; cv=none; b=eDDh3prMx8XAEBFoPAxt0Qqg4043U3tysD1Jwqhi4UH28JmcVmrKUhegtHGAXhfp4k1g/kJJUVuB2AE/oJ45MaMazEczhY1XtxTA5tQt7Fajp7xSJDriQLXa4OyS+SZPP165TI/JY+1CPIfBhELXkn2TavKYZXMnBy85KLH9P1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786560051; c=relaxed/simple; bh=AJ0HFagxwXLhWGH0bMMMUlIBm8aIOuEXdITySVjzsno=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fnMgEWhEdT3jX0TS/qq0uTGPGQtsbkJHCjwRKxccLbYY7klUAIItn8NBcudxBZ4Cn4v+NUhYSPUSROD2zlCkhssym2cnHOXNfWruHDxg7wAgGiOkMB6oJ/K9WyIJJhGR9XW65eqyiSuv3QS9e3HyAVkow/P1RgMDNCQwzw4Vbq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=JxHPyft4; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="JxHPyft4" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2caea3f742bso18551105ad.0 for ; Wed, 12 Aug 2026 11:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1786560049; x=1787164849; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/r0/dZU9327lVW9vWBLzNVNNVeObkOD7Ru+Xu9UxYCw=; b=JxHPyft4xlROG9XMIqAKsYFr6VfhrA4BUd+4aSqW79K64FcH5ZbQWNXQbGw3GiRCHE ceo460PvN0k6m364nNzscXZVbadh+iwQRXLNvV9I54QOAtDYJGBIhJAn2UrxRFKukJDw NwsGveaoC96eYJ35eE6afO0kI3Yw3MEfrMcpSr8JEWmXg2BlvG+yRFcQDmJL8nxLKfNj NPRV7Pw//qqEfHNngv2DcHYS/uD6pAIDPO9YZrMa4sJEpkxhskDgYxT6lSw4wZmKhS98 fTg3iz9bUPCTygqiwXLZbiIVVPpcr7FabEbZlK/UYLO4HUPfiGtJ8DyFNaK++JUth2J8 PrjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786560049; x=1787164849; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=/r0/dZU9327lVW9vWBLzNVNNVeObkOD7Ru+Xu9UxYCw=; b=fTqUy7nqnHqb5qxHbd1o6Klyl0UURJBEIFTD7m7nNoyNpkOSY4ayTAtBOkeRbg1VwA +VTRO0OCP/Ws9Gd/M/olUCdw8fMiEalrJaCvWcXNdql2c12T6ebTxVAqgOAGCxKVNrM5 CN1Ul6D47Zmw6efSWQTOE43A8UqMgwZ3By0JIJBkzXsdI3Mm83mH1UoiJ8cJq7YylZq3 Gbk/rtdgDRdecqw5bkZ02AqM4gdiT5cXnrryZmzkEQmspcWZwlOVMwvW7uD5nrVdTcAr dU5pmJBaazIHT53sVWe0LawkfubtQGNYYECjCjUl5FKCr/AZdiFKs4t1dAhpwXtE0EGJ rR4A== X-Forwarded-Encrypted: i=1; AHgh+RqAkIplLoIWSr+lQczx+l0LcpzxxY5tYCE94ZOIxe41Ahw5cJeq4837rBn5UZRUPKiHgy1/ER++q4JHBto=@vger.kernel.org X-Gm-Message-State: AOJu0YwA0AJTnga5CTHIuJcBn4niejMe0kAYRZTvu44FZR6HtpkqhgL8 fmE8jVNxcfbSZdJ/KXd9petjHJ5K4RV1jMfWzaXE8mw/dh2qNoprH+PuYitegZgKPY8= X-Gm-Gg: AR+sD11SsJWbvUMVupAv2DRKZDhKBZZCSKm7xcjS1cn/IwKqeyoK+7GqxIjxLCcnQ18 +8rxEWFsQ6UBJkX9pxoqlcM5z/JNmMsLy/6AKXRnhi6PxD9xZV5+LvkCk7HCyEpoSeYh8W22g03 lR28G2/VFRCr2M2Z/pqERxiBwy9zJXaXCaTjgV5/EKeKNh1M35EPbcgGm7mb+MY1knfYzpTP8vC rFENr6Rx0QYk8s1obScRZEJAK/+Bv0P1EscTy40yW7ADRyHjgilD7EaqIa3ovYQt1awRrLQWl8a T37llmrgsjAWEmAbHNK0Z/3/9SlCg6Ky9ffw8Ipl6ruASRnx9j5SKito3W7dKaENHpqOgUYM+GL omLzUdIZZkgG/HwWakHOgnNUqjAMQRW6fC5Ge+2rMVdVzFCugqfcabFi3xMcldvEkYodtsDPrAF 9e/pD2PBcKtyl0ORqSAL+5HUWi0R7ktpuzrVblsNvO3Q== X-Received: by 2002:a17:903:1d2:b0:2c9:bf82:dd11 with SMTP id d9443c01a7336-2d37d57393fmr130535ad.7.1786560048672; Wed, 12 Aug 2026 11:40:48 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:40::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d37c413294sm593745ad.51.2026.08.12.11.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 11:40:48 -0700 (PDT) Date: Wed, 12 Aug 2026 11:40:47 -0700 From: Joe Damato To: Kai Kuang Cc: netdev@vger.kernel.org, andrew@lunn.ch, olteanv@gmail.com, f.fainelli@gmail.com, linux-kernel@vger.kernel.org, kk47yx@gmail.com Subject: Re: [PATCH net-next] net: dsa: drop explicit NULL comparisons Message-ID: Mail-Followup-To: Joe Damato , Kai Kuang , netdev@vger.kernel.org, andrew@lunn.ch, olteanv@gmail.com, f.fainelli@gmail.com, linux-kernel@vger.kernel.org, kk47yx@gmail.com References: <20260812060644.210997-1-kuangkai@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260812060644.210997-1-kuangkai@kylinos.cn> On Wed, Aug 12, 2026 at 02:06:44PM +0800, Kai Kuang wrote: > Replace explicit NULL comparisons with the boolean form to follow > the kernel coding style: > > dev->class != NULL -> dev->class > user_dev == NULL -> !user_dev > > No functional changes intended. > > Signed-off-by: Kai Kuang > --- > net/dsa/dsa.c | 2 +- > net/dsa/user.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Joe Damato