From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 959E633D4F0 for ; Wed, 12 Aug 2026 14:23:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786544598; cv=none; b=Z7i67fxZyzgZtu5fBfGMovRVQ61RLKAxLb63K0TSac+pcQWKn4KvelaNUoAHozXIW69gku7kXzwiuwTkWykuGBNVKQuX2icWWKiQiNrDS4U+p5qYFAT4Ffx7b0NcDmYDQNa5c6Rt6QixqnJgCbKLlQ87FWRWH/ggCuYsTzSnwqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786544598; c=relaxed/simple; bh=+aqoWCt2K9Ga7Svg8jlwYEwvu2yhc0Demkr/jv7uhcI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A+4IqvCJ3e8Iqin5nPbwXMdzcOzrjG5yEtYev1MFEzcXdk6nfxiU6NZsbEUGssiNxngG7yCJg511qBUd8UNG0USPyp1/pweOcG/YRoSZjAT3N+ny6Bb6ZBbatSesr63C6gYg5kc9wVj1xXLcjIgpmuavRcaq5XtfA4pr8GKwMXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bK1Uow2O; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bK1Uow2O" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4953de5be0aso7236345e9.0 for ; Wed, 12 Aug 2026 07:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786544595; x=1787149395; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=UtdUb75BaWpEKGv7DkEH6NaI+7V5a5qgQY9Sk2+HEG4=; b=bK1Uow2OzpHu0j4wqh60G0SSN5AXzXXP2WaJ90dsJaxdoVFyZIoqqNhkNNtKOpwgS1 wHGDCwD347vBW2pZHE85esaoK4dqdgwwJFob7eM0pg26ysZsUhOw+7KWtlly7xT5AHWv NI2mmkXEex9IwR+WqNqvdaOXe38Db7a14s7d3HccMwSrn1rw9zMdlSitZTQSO+HdWW8U GPRiieMuuWQXa9BxeYzj624tkwCC6vJHaxezh88O78ZUMk5Coj1XpQ9+AV1xenRARZXZ 65FQaMFV8fCF9n3a3w7Z6Ec3zhIgoT3BAcGdV8WVKbIwmmOAOJwDBmSsk7Ony++aFMRM wiTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786544595; x=1787149395; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UtdUb75BaWpEKGv7DkEH6NaI+7V5a5qgQY9Sk2+HEG4=; b=W0V0Gh7d6MFe5DvEgIACv0JYkNr5rw8R8ShgDTVt/tlylONz5J21PvnIBUolN5Z1Jh GwfAU202i04OVRTSMl3XjoE7Qxk3fHu5+5O9niCkI/23dsYtIdavk8EV0M9JOZePOXPg q3P17c1VKbTKOa6h8yg6quEMgrSCwldnAwLu5Hhv8AmUS7bhr7wucNH16AWqUdSNwBkf 2xwAbSCz0ke4J1OAzNTS6r7tkZp07z4UIw90abgqjbn8Q6KZ4odxAN9Or85Wfpg/C5F9 uSKdE1X1AVv1STiEzPOYZVk1JExNLQvDztaEWBEg7M0JaiXMmDwJxQcf0JBPm4nzulRJ BLwA== X-Forwarded-Encrypted: i=1; AHgh+RpDddbSBEwwLwVVbORsanhazfriz8So/sIK/tPMLUH+9we1ECYvGKstrmcAFBVXqYv/A8SPbgr8h1JkX3Q=@vger.kernel.org X-Gm-Message-State: AOJu0Ywvdqclj5vK+eGkAGJrIPqLDUrjGzvVvM4mO0VWY5ti875WOnl9 YUA59CHYE/Emvhn6QfLRVwL8Fz3lANIGACJsnyCRWKmorJvkEANnWnVN X-Gm-Gg: AR+sD103w8ieI41ccDZkkvYnrZpQUu/UbXtR3L6Fsv0JM3jT02+xHDghAUkleejEFQF QeRb4kaUr7g9sqyBYpI1N5V+HaWcut3GNfDuM3TDmhF1n5eolC5cmupqyE6wIYQpRy18hL310gO 3hOawDuh+3CUbPFal36anlU8whHf2ftpiCYblIuBLeiPJX6dvJnoi4xLYxaB/CtCge4wIwzgRr5 D2l5ybMeLr/FrspBP83CU/cBpS6ZpTQc9Onh4tgZZPM72LB5UCZmweVHfCIvGpNwJJXaNHrG1PY vtJTXJB0mQwu47G4omAIVtOUlpH5L2D8viYcbZza38nRAELoktpLTRdZ0IMlVjvhtmJTDcDgJBW cxKh2KOMAcoOtvFPUlWDQGssuQvGhfhgzYcZgC+X1T0IqC89cozKDuG/tIYc/lz8q8ILpg/UW4A uLmT9u0TB624kZrM7+700dYF9nw4pA+uonHsxNbblPtYbsPYgz9KnDviJJBz4w1TlX+AQJBjV0G yhjdWrC/oCGV+C57zZ0g6c= X-Received: by 2002:a05:600c:1f8f:b0:495:5fdf:2075 with SMTP id 5b1f17b1804b1-4997bf83d13mr52851095e9.0.1786544594416; Wed, 12 Aug 2026 07:23:14 -0700 (PDT) Received: from osama ([2a02:908:185:7e40:3d2e:78f3:cfb2:413d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997abf94c1sm73155475e9.14.2026.08.12.07.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 07:23:10 -0700 (PDT) Date: Wed, 12 Aug 2026 16:23:08 +0200 From: Osama Abdelkader To: Luca Ceresoli Cc: Maxime Ripard , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Jerry Han , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] drm/panel: Use devm_mipi_dsi_attach in BOE panels Message-ID: References: <20260812130429.16850-1-osama.abdelkader@gmail.com> <20260812-psychedelic-accomplished-swift-4f0081@houat> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Aug 12, 2026 at 03:45:59PM +0200, Luca Ceresoli wrote: > Hello, > > On Wed Aug 12, 2026 at 3:26 PM CEST, Maxime Ripard wrote: > > On Wed, Aug 12, 2026 at 03:04:18PM +0200, Osama Abdelkader wrote: > >> Use the managed MIPI DSI attach helper in BOE panel drivers and drop the > >> corresponding manual detach calls from remove paths. > >> > >> Signed-off-by: Osama Abdelkader > >> > >> --- > >> v3: > >> - Move the changelog after the `---`. > >> > >> v2: > >> - break long description lines. > >> - add Signed-off-by tag > >> > >> drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c | 8 +------- > >> drivers/gpu/drm/panel/panel-boe-himax8279d.c | 8 +------- > >> drivers/gpu/drm/panel/panel-boe-td4320.c | 8 +------- > >> drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 4 +--- > >> drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c | 8 +------- > >> drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 7 +------ > >> 6 files changed, 6 insertions(+), 37 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c > >> index 84c21c62a43e..6a74523a6614 100644 > >> --- a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c > >> +++ b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c > >> @@ -359,7 +359,7 @@ static int boe_bf060y8m_aj0_probe(struct mipi_dsi_device *dsi) > >> > >> drm_panel_add(&boe->panel); > >> > >> - ret = mipi_dsi_attach(dsi); > >> + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); > >> if (ret < 0) { > >> dev_err(dev, "Failed to attach to DSI host: %d\n", ret); > >> return ret; > >> @@ -371,12 +371,6 @@ static int boe_bf060y8m_aj0_probe(struct mipi_dsi_device *dsi) > >> static void boe_bf060y8m_aj0_remove(struct mipi_dsi_device *dsi) > >> { > >> struct boe_bf060y8m_aj0 *boe = mipi_dsi_get_drvdata(dsi); > >> - int ret; > >> - > >> - ret = mipi_dsi_detach(dsi); > >> - if (ret < 0) > >> - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); > >> - > >> drm_panel_remove(&boe->panel); > >> } > > > > mipi_dsi_detach is now called after drm_panel_remove. Your commit log > > should mention it, and explain why it's not a concern. > > Indeed. Or switch from drm_panel_add() to devm_drm_panel_add(), which would > avoid the issue mentioned by Maxime and cleanup even more the code. > > Luca > > -- > Luca Ceresoli, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Thanks for the reviews, I updated that in v4. Best regards, Osama