From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC05C3655F3
	for <linux-kernel@vger.kernel.org>; Wed, 12 Aug 2026 14:30:51 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1786545053; cv=none; b=us6ANIpy2NnQSZYufnvpaYHWCZ7FBTkjsoHKEfdE4TwFK4nlvHI1Zzzw4D0rvIX6opyOLgUVXli4XpO4c6lIp8G7LQ3bIAW/d8cqGJOY8Nczw9Z7DJyRfCOQIRQB7BnLbYvvHHZVW74Dzmoy5h4FyQsln+5Er4n5DeNt4BWNWL4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1786545053; c=relaxed/simple;
	bh=OOr7Z0TA50IF1lhkB+P3bJKGLUlUUq/DieySUhiBdd4=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=HjJzBbBNmV3wNuUqZEUS4WywHWQFKy1Du+XfxDKaXlci9zbCCR3p/+zyq9APrNR96LiqFweBYQNcek+Ebt4Un50aMjXsRHdIIG9TSlh9Kp1vBGRXnHuDkQX6MtvKPc1JGznGi3Wh8AdzArDKNkq7p26pJlp9U3Fv8SMs4cyMONE=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T3hCstbZ; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T3hCstbZ"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92AE51F000E9;
	Wed, 12 Aug 2026 14:30:47 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1786545049;
	bh=wax1t+J1+D4JHs3MLr//7ZVVQ+YfBVoQOpV29LLh7uo=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=T3hCstbZYue6SXbbFIimZk7VdVvHA4hdrsfN6DNkdEh2EOKsabNjfzLAFc6MVKBOP
	 tWoWc4O9nqPqL1ZgoexiA7uH8eGLFXs8LdM47hrYp7T8qy27x6ct3pJlIOlvnLKDQ3
	 EpwTljn7W2y2AxzgvQz7He4eT9eYkflxBsP+jG58LHwzbB5bJB8K3Y5K9xC80mMCV0
	 TdnlGx0f1rK54NTCvjQFPhIX963VkPVzEF8ybZzuW4NftGe4IwFr1/IZbsPP1VFPzS
	 fD4HrDrFHYdlNYouSVZ0siN6Dcr05QQT9QYeO5GMNGE7RR/Ne8b4fhk45D2IPwM+30
	 w9skhDaDX+isA==
Date: Wed, 12 Aug 2026 16:30:45 +0200
From: Niklas Cassel <cassel@kernel.org>
To: Rihyeon Kim <rihyeon8648@gmail.com>
Cc: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, axboe@kernel.dk,
	justin.tee@broadcom.com, nareshgottumukkala83@gmail.com,
	paul.ely@broadcom.com, kch@nvidia.com,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-fc: fix double free of fabrics options when
 nvme_add_ctrl() fails
Message-ID: <anyDld8md5isTbn6@ryzen>
References: <ansfMnm1WntoQRi_@ryzen>
 <20260812105941.55577-1-rihyeon8648@gmail.com>
 <anyCi32WjlR0hyeC@ryzen>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <anyCi32WjlR0hyeC@ryzen>

On Wed, Aug 12, 2026 at 04:26:24PM +0200, Niklas Cassel wrote:
> 
> To me, it seems like fc.c should simply look more like tcp.c and fc.c.

[...] more like tcp.c and rdma.c.


Kind regards,
Niklas