From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54F561F3BAC for ; Tue, 25 Aug 2026 02:57:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787626673; cv=none; b=WLXzBlXZ8GI1AWEPv+qNF628AAZJGOV4JkoYkUCIHX6tIHve1nw+oS0te3ky6Txbn5T4oAEtyjz+5jMLhmOClS2M9PFfmNvQHH7FdIy94lINoemw1+7/HjSBR0eGBQ7gUEWqol2Ed7XDO2BgC6CCqQv9J/0ERmWZs+jsmpBZCRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787626673; c=relaxed/simple; bh=FXXGAWNeXf6w6ztqs5RsvNveFAADYxKnR0wu60iZDLA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HVfcw/Ci1AECZCbdBjAh8ybGi3R4szRHox/66p8pmi/FElGnl4pKv/sNc3fQYS/daJhkgEiIE+BRNiYNXEtDucy0ymBvIoqrK8ShKRwvq0gchMVZxuisLJgJXlY/lL50nesJ/doj+ecVxuEEb8LBlS/Njirgwt3rGfm5ohJ8Q+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gEx1uHm8; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gEx1uHm8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A42F1F000E9; Tue, 25 Aug 2026 02:57:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787626671; bh=GvQLhOLHeYJKJN1cjIsTMtPcdFE2OhruwkpoQivV+VQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=gEx1uHm8a1VuwiuOrZW/RdciGlXOwBqbGAAdtEfSlWkRDOJsjPg2No/v/7pfQxdY7 eG7MGO68buLG8qKlRVgr6ohDeGP1tcM+SuR/n1f4Du/0vhOAcGj3+Nm+rKLiu9598s 8LGf3I9srSR3Jlb2FJVkyS4dJhwgu8MYCf3oYsjq4HgYLmvuTlFI59cjwMItgvRf9T 58PMOQBkETzq/fOHnp0LHcIDPxDLTMxVy8tYy612FqQcHRe+UpDH+mZHbpHs3x8gRM k3y6KeInWb2zYL2+KBFWNgLBzGIDNCxfVSWHv2MAXnHvY9MxCbmlSB4cewm9wPcHAB hC/zYqBlpedIQ== Date: Mon, 24 Aug 2026 20:57:50 -0600 From: Keith Busch To: Xixin Liu Cc: linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-kernel@vger.kernel.org, hare@kernel.org, shinichiro.kawasaki@wdc.com Subject: Re: [PATCH] nvme-tcp: defer TLS inline send to io_work Message-ID: References: <8803a2bf-3f8e-4ee9-b6d7-5467bfc1b1ce@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Aug 19, 2026 at 08:50:00AM +0800, Xixin Liu wrote: > blk_mq holds set->srcu while queuing and running requests. The kTLS > software send path takes ctx->tx_lock. lockdep knows that tx_lock > nests under elevator_lock which then waits on srcu, so an inline > send from that path under TLS triggers circular locking. > > Skip the inline send optimization for TLS queues so the send runs > from the workqueue instead. The same workqueue already retries TLS > sends on write-space notifications. Plain TCP keeps the inline path. Thanks, applied to nvme-7.3. For future, could you please send new patches as new threads separate from the discussion that spawned them? You can use "Link:" tags for prior discussion if you want to keep it, but this interleaving and changing subjects in the same thread is a bit unpleasant for tracking purposes.