From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E75F3F6C2D for ; Tue, 25 Aug 2026 10:24:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787653464; cv=none; b=OQ8PDzriphJd6pV94/c3en4Z2Nd8XraNHSukhaBrdlrkwbaIIYVxnCMIuxQukoGrh/cd88R2XoUHyJy0+701oNMogI9dQKYdAaJsutAwJNutIytipbpfkU8hPFtrNdJk7bkgzMt17nDzTize/Cdb01Qt7nmqpBNgG8UIN9njU5s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787653464; c=relaxed/simple; bh=lK2BFmWVVl023uFQVfWzK7Q0QzOCzFmm33ddjKEUoBA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F02SoudnmWH/HtTqYWF4qKiwHGHH8w6mqfNWsaK66thbQ5O7l5wlLtbVo0MSvhsnUdtoRVr0jYi7nDZz9mes2CO48jGPn799aWHDnJOR6QROpBL+orrA+uvZJd+vrXUJ1Av1mF/9x9GSFpGkMN/ZqhJov54tuO5KsOsaQ/lqCzQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=PZbPVWtv; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PZbPVWtv" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2d3b440b97aso77675ad.1 for ; Tue, 25 Aug 2026 03:24:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787653463; x=1788258263; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=3wkoXmohD3gha4H5ZeL5zxsjojGVMUQObrPCKo/HBgk=; b=PZbPVWtvWSuRqEWqlfcUjNYuTYBBEDP2iCd40iUS3auNu7IAzSOUQ9jFRd3COW2ob0 O+FXN2hV81ajPg3jHUSNWQF+1lwwhJ8K7jcmuQqQoMd4nbvSwtdMlXkA+3d5gTiYi2tA KbmrdpN/cCIiL+7Mwayw1ODmlvjHcUoLTa6qxtROZjpe7LYaHpIVg2uMPQ2FNmnyoUym W9KSM+OWUJqi6Ugdb7tpmjN1CByL2vxa6xeQdfzU5KKZ8bLxJXBcBWz903TFddPVXCHY BCgHpZ6onXn99zYBYmv1vlzs730/QCNITSOfRv6a3b2HPMQIo838HiBaB1Ly8793BeoO XHcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787653463; x=1788258263; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3wkoXmohD3gha4H5ZeL5zxsjojGVMUQObrPCKo/HBgk=; b=HJOebiJ9LxTX6jBx5DmORXnxEhslztRbZjymp9KUCh/qurGChEQ/ug40oRWY35ODBj uupbh1KMRNeJ/NjdeuhrBV9JR9gy7oNM6NGTo2tYINrZbT/NeNgw9k8xcoGBI3JaAIwk jlgYZ+thJMw0vGcCJJVr4jXz4iN2hdGeBKBDbGA7bkaY+T2zFqvpjyHPQDwVI3uM5vL0 aiKI5sKx/EkFLza7ThBa2RllwOFIR/eFZ3z7+wvJex2jFeZzeMvJUlhg25tjpzcPgw9w M6UZW9LRA6tbR6ShwHUYyuYOzCmu4ixXRUK7kN17zCEv6+++OeQpwaWEcPz4Cy3PofLL mt8w== X-Forwarded-Encrypted: i=1; AHgh+RranoIFKmztd6k9De2SKqBYltxStIJL1IP2VAFk6YFd2MJgOg6tYSJPorSdwFNAJVGW69mEGpLFQ05nEHY=@vger.kernel.org X-Gm-Message-State: AFuF++kagLJavp3hzc/LF3mdS0xWqJjenOTXw52XMBzK1pQxHafYEbfB kgyhzDrEowEvbpqf31pis5xeh3cX0Pw0vM8SkZkJzt+uH9T63Bg4AqjCNf3Ieo3WyA== X-Gm-Gg: AR+sD11wZn6s1/XpgxPteDEAVqOKhMbB8r8A8voqStgfRjjltUBjZR/Kynt++P5XhXx zJ8r5Y8t36DNmwNPIQ/BGGiuCrf1iNKB1r6P5MQgapME3eQIwveJtN9wh7PiAA2L88DeJ8/gENQ HoDwlgOE8PnhYHxd9w8tFJaI4RcQ39hprzW4ns0QKl9DS8SvRridn8AEO05mSjNqDYGVJiPH8cx lMYwSGTHw7ddnxwHk3i1oALkIJo8yV5Txe1aAcx2cwEGQPsNptj1O9XI0lu6ndnVG0gcvUT0Cvf U8OUP4t8WipO/kaSiE9t2vz7gqC6yFZz2C5AI1ZU7abpfgk1CxnUbJTkqrxhBAJ3XkcwHQfca39 U0bhj4LolVc0pGSnnXzA0K94GkTEbRDfVXoUy9tJjDFMkDm7TGU0jT/vnOSaga5zPaAC80/saCz YJFSaF/ryEV1adDsahL25zX8J+dcNsPkrMYq57TYlTkA0ROhiQ2Sh5plYKma0Ga/tC7g8CIUCBa Gt5EbWaWWw1g++ff5ZoO4IkRh4aB+TkmeR2 X-Received: by 2002:a17:902:ef4c:b0:2d5:db38:8010 with SMTP id d9443c01a7336-2d6f2f25ba2mr2716195ad.15.1787653462056; Tue, 25 Aug 2026 03:24:22 -0700 (PDT) Received: from google.com (164.210.142.34.bc.googleusercontent.com. [34.142.210.164]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8520f16d77csm2916024b3a.59.2026.08.25.03.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 03:24:21 -0700 (PDT) Date: Tue, 25 Aug 2026 10:24:16 +0000 From: Pranjal Shrivastava To: Jason Gunthorpe Cc: iommu@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel , Suravee Suthikulpanit , Vasant Hegde , Ankit Soni , Bjorn Helgaas , Samiullah Khawaja Subject: Re: [PATCH v3 1/5] iommu/amd: Refactor device probe and capability initialization Message-ID: References: <20260824122347.1588592-1-praan@google.com> <20260824122347.1588592-2-praan@google.com> <178759520116.3131778.9383172724893797706.b4-review@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178759520116.3131778.9383172724893797706.b4-review@b4> On Mon, Aug 24, 2026 at 03:13:21PM -0300, Jason Gunthorpe wrote: > > [ ... 14 lines skipped ... ] > > @@ -675,7 +675,8 @@ static void pdev_disable_caps(struct pci_dev *pdev) > > * This function checks if the driver got a valid device from the caller to > > * avoid dereferencing invalid pointers. > > */ > > -static bool check_device(struct device *dev) > > +static bool iommu_lookup_device(struct device *dev, > > + struct amd_iommu **iommu_out, u16 *devid_out) > > { > > If we are touching the names driver functions should not be called > iommu_*, it is confusing.. > Ack. So just lookup_device works? > Otherwise looks OK > > Reviewed-by: Jason Gunthorpe Thanks, Praan