From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93A2238AC87 for ; Tue, 25 Aug 2026 10:34:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787654076; cv=none; b=lz39PF/y2lRg2D/LbNid+laFAGELILBKbUE/C+gqLxGK56398NROeDOFiNuCqJwXvKlK5qxAOlpPLsjFkevsXg/Kz2tIPRBjOf8uxwOSqWWh+tCSrTKEyYWBJHyMclVYuRisNigJv/4zDILZillqLI1nktwHdJ63KwlvNRg2bLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787654076; c=relaxed/simple; bh=O+P3xJqQ2iemp3Ulde4Fu2+lem2DE6IjQORZXOXh08Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aN5WAQmz35YZqIyri+eb/c6M50ss9OWe03mdnsBynb+pTMZtYrQUbhXaC641tIMVFTSTukXvLFiTrXcMULTJ7AeU/pcWjqCBbJs7GFHXRiAIJj891vHUrUnjTVapxP7XUPg8jn+8oY96fLhgJaEOkYkSMdqneKzO+zu0eCU9PW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fZhKwnwG; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fZhKwnwG" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2ccdf36f63dso101865ad.0 for ; Tue, 25 Aug 2026 03:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787654075; x=1788258875; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=3I7M6+VDRcRqN+go+MtLjnMG5u02OBvW+7qZt2cSYZg=; b=fZhKwnwGEQ6nnh4puXGL0Jle0DTLv/JYHsZVl2x7U16Bce0kxzIy5dq6HQreiHyutR 3YmlFTH41q+Ui6SzgKBECm+XeZytk6JxnxLB9/esjaCgctxG88qkpobkF0I0K35vX+VK HFvp/K6IgHyIDeyCLJmGhqLzmDEogx6XZUDRAq21m+nBr8evlR3Gn7I85hNvVXgU29Ar YWV3DF0jXANib/lcwr8HJR9Je4+FnOemjlFpB5aGWdMMNxyPELu2bCDED6+3y6bEMUF8 jMXSkeh5t9KFBhZrAD4fGeJSGmvH7mlaRjaUZhFxVbQRYXvgHn5JXB9qJekKXZGQ18G/ E5mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787654075; x=1788258875; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3I7M6+VDRcRqN+go+MtLjnMG5u02OBvW+7qZt2cSYZg=; b=UPMWmXWfJlP6Bq+VE++oXzsXKgUyN/zFHWAP+mXNZ2bYqW42LaZMrY2y5rcfQ4+C4z St5weDrXP6R/hTNDbrOHxCS7mi97WXWZqj4/soWBL2jh8f19VK6PJdnnlh60yHGi+JY+ h2c7/y66B6eRnX6Of9WILMNMjEeejE0frroiBJ+wVhMli5H4BtKDu6/KwcEYVlqaVn5p yyJ/maUzr9n4MSWx5xD+RKqjECOX/8YakyP5WazXuCYrZxTxEHlksMV6ilMm9hIq3o3o ZIucr7GgbyiQPAZBLHYSXsExJ9oig/bQ0U+2nU6NnDzp/0sNfvSJZSc1AejHemD+Lzcj ZPvw== X-Forwarded-Encrypted: i=1; AHgh+Rq5jjwexAOMxdjIzvtbsMpXn9ex6lEvmS/7HlC4M9ePnbEUDWWXdP8Fky3wDY2FZPeF5zEYWf2ZSugj4k8=@vger.kernel.org X-Gm-Message-State: AFuF++nGT+pTCEjk/MBLtvyNxT/OzVvFlRhmf7v9DU9Z+OR1hPmiNzgS JCXeH3hE7JPLPJxEFlPkWvRTvVM6+/IYkfuEBw0ELiYcvaXRy3arCcM/d+exuIzSYg== X-Gm-Gg: AR+sD12zktiQ9jKBCnGVi0+C8QtvNSEYMDyIgYmHmBks6ivNirIclWrMF/UR9UA1sfG VTVG23KNi8q7+Z5F56BfI7TC4y6BLGqwyny/NVVd7MYewUH64RBRhyhclWyuk/VfB5U6v5Mw3UL oOpd5cDkh3p2aQWZE3omGt/fr7zAOj+BOFBp/042mB38N3d0mICcIzo6poJsmMdyDJbW2YddxSb qsK+MZvsjVlYevlc8HmCNAjoW1s59NSWq535P7kzVpRJsKHxXyanRnng+JQEUUnSSsGr1kMRBJt mbfZAQ6/Ph8TVGGX9RIPdncZYIc/QXaWNRXOjhERV33l4ukj7cccIFg95rqWdGqCKovGim13Jaw cnu6sJU5saSC3TkDjtOe9echjnK/vHoymF2Ejy7PSq68oq+NFIwPOpbv2T9aWDujAkVSVcmFeJV DL62rqOShWp2gttw6nya+ZrJxBJS8UL4jIOZh9oRZSEriHE4Lpoe/S1ra/MxD7OuOJCRzD8cUvZ ti4SM0BJhu5Equ3ExFRmy0MQQ== X-Received: by 2002:a17:902:ef4c:b0:2d5:db38:8010 with SMTP id d9443c01a7336-2d6f2f25ba2mr2769375ad.15.1787654074163; Tue, 25 Aug 2026 03:34:34 -0700 (PDT) Received: from google.com (164.210.142.34.bc.googleusercontent.com. [34.142.210.164]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39645d31e74sm3331799a91.11.2026.08.25.03.34.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 03:34:33 -0700 (PDT) Date: Tue, 25 Aug 2026 10:34:22 +0000 From: Pranjal Shrivastava To: Jason Gunthorpe Cc: iommu@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel , Suravee Suthikulpanit , Vasant Hegde , Ankit Soni , Bjorn Helgaas , Samiullah Khawaja , sashiko-bot@kernel.org Subject: Re: [PATCH v3 3/5] iommu/amd: Split probe error paths to preserve IRQ remapping Message-ID: References: <20260824122347.1588592-1-praan@google.com> <20260824122347.1588592-4-praan@google.com> <178759520117.3131778.6953869487486713121.b4-review@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178759520117.3131778.6953869487486713121.b4-review@b4> On Mon, Aug 24, 2026 at 03:13:21PM -0300, Jason Gunthorpe wrote: > > [ ... 15 lines skipped ... ] > > @@ -2540,8 +2540,7 @@ static struct iommu_device *amd_iommu_probe_device(struct device *dev) > > ret = PTR_ERR(dev_data); > > dev_err(dev, "Failed to initialize - trying to proceed anyway\n"); > > iommu_dev = ERR_PTR(ret); > > I would drop this line and fix the return to have the ERR_PTR > > > +err_deinit: > > + iommu_disable_device(iommu, dev); > > out_err: > > return iommu_dev; > > Otherwise this landmine is going to hurt someday since there is only > one flow that would have an err ptr in iommu_dev. > Ack. I'd refactor this. Thanks, Praan