From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A010402B8A for ; Tue, 25 Aug 2026 12:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787659984; cv=none; b=gtlTgYQtyV8tiZx3oCLCTNLGyNMiHr2qQrIKqHqa8kQNj8sjWCZef/kleNFF9xbaVnsbOM1JdXsdmiPyyvmfY8ieqOvOQroMH2VaLFZXhOzhnFuG2TVuQBm2Dy45+8a5y9Qz5GJd/aGWdLSqdQcLo4qtWPTS95Y0YD3R2dsWpwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787659984; c=relaxed/simple; bh=trNVA5gVReYdkFue47keFlPvHc1/Gh0KXZaU+Bnrfug=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a6qQ1xG5iBJOQttrMrB+OokC8KIAfLWhOgyy0bzPJ7eJk1C+F8wiORPh/qrr+VL1I8GebPoFUD0g/utYZJzXwEHq+PMqobQ3VY021fzeV6oqsoBimTkNYI/9QJFYLhxscV/4+zwAx/XVmADFjVt7fFHpjb3dkYd7oJbSJnGgE3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=QnxojTs7; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="QnxojTs7" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-c20ce3c118aso151736766b.0 for ; Tue, 25 Aug 2026 05:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787659980; x=1788264780; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=MBJ/vcOaP1xG+Rh/R0z//WBNgvz+tz7qG49hmmpRSwg=; b=QnxojTs715vQVImJaZZa8CJDtKYbf5Tfyem3O4FAAzZk543Q58Ax8LoIMVUrS7twtT z+Dq/wKNZte+ePvhA0WpfKLwu+hnJHthXLRiE2tC6knEjjLUPv02CVkc5HbkPeLYznEq ItTn3VfF5DlAJtbdcnTuw4ArP5ka4nDU1duxIQOzu0NTIhBFLHoryE9XqTiMLADn6Sr4 c5M8XJ/iZEs2MPkGJFMhVV1hI1SJ8KcSMzh7Cmyp3IXTMbXQ1URTN8ENetPZIoinbiQ7 BlWBBCXKxW3U7gJhnQUzJMk/HmiIqsu0ONKhOiP8JxKMaJLHik6HscbBtkrpGnTeeNkt y67w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787659980; x=1788264780; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MBJ/vcOaP1xG+Rh/R0z//WBNgvz+tz7qG49hmmpRSwg=; b=SMxwWe9BSnFDJZD8DN+k9TVw5U5anTaRcb3Xe0DmhoDluVkequgjIz/G3zpu1RnXAw QAdL8lCVjXaIbZKprGueLdybA85gegos63XQ6IlNHVlmFQuowgUg6aMdPvdtTNaHPKST ldBSekNqDVO+qE28d2FnQ3M8kf4BwMcKYphUP3P1MAcDmeFf8xP8WiEBU9XcWOZaP1EX L+aqNxnBxDWqdTxv19n9SpszGemeyoXlwrS+OI1wpoB9XEAyxizK0C0oohh2ylG0Fhgh z9JXlEPLBugc4sfISEc71qjmPRGCpzwxilUH0P95iTN0AL9R6evl231fonibUHjFUGQB Z8CQ== X-Forwarded-Encrypted: i=1; AHgh+RrpI1kVU0L5rYCWWQMzEJbqD8kbvXDRrZ4XgghR5LYGgvZU/uuFBDtacX3Bsn8KsNyWz8UF0n7Xli9Wem8=@vger.kernel.org X-Gm-Message-State: AFuF++ngmtaF8Tg9YgWdz6bquPHqIu9rJPCjP2kdkzRR9Zv+lmObXiyJ Z+hZ4LSGVeDA6hnREth+G7Er1TFCuQuJJK2yKNBnv9pfd20Y+7cc+NbrxjC/EUg+zIA= X-Gm-Gg: AR+sD10qX+6NlfLik5aPSdmnr2ncMwBNMPwsb3mOvx7PA/kqGF/9mTRzDWgYKXZI53Y 037B/DpgiSSb9rULDKOqxbe9krPfE257m9Jr6z8/11sDb7/45l4ypcMJ98+fffij9bv1p01JV2H OvDkxyVMOCDWXy9mtTdUR29Izs2GNqlksjXPqZRTuxLk8zKy3aRy6KHLfYmWVXIFC+ayBz/mm8i BQiARf8BQCuwDjoGIP1fAFFY7Pi179DG5SsDxQVJpN/m5D1KYtpYuBQ6xvcJMRYZgB3QpjcLp+S sybn1jD4OPedTm79uW6YG3hBNWxQ+u7Pnje6IUUa+ZYt9uH7P7sCnjatyUmxPXwgYJDN2QZBFVc qnx3BGIX9h2W6e16zIOqL8WI+Wm1miXk7v+Y+ziQMEEiV6RQ+QCvqzNf1PIbHq5zEzYFDFAWnZL 28DghrXFWdnYbk/DEppHg+pA2L+OWW1KT/u0DMkftz8tdpBjL9Dtdx65qZ2N0KjNzCWRgYZt5Bd w== X-Received: by 2002:a17:906:eecd:b0:c24:6382:2648 with SMTP id a640c23a62f3a-c24e2cdaa43mr742664866b.5.1787659980407; Tue, 25 Aug 2026 05:13:00 -0700 (PDT) Received: from localhost (109-81-81-112.rct.o2.cz. [109.81.81.112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24966f9c9fsm1859755666b.39.2026.08.25.05.12.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 05:12:59 -0700 (PDT) Date: Tue, 25 Aug 2026 14:12:58 +0200 From: Michal Hocko To: Hongfu Li Cc: hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongfu Li Subject: Re: [PATCH] mm/memcontrol: remove unused memcg parameter in calculate_high_delay() Message-ID: References: <20260825120153.1405-1-hongfu.li@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260825120153.1405-1-hongfu.li@linux.dev> On Tue 25-08-26 20:01:53, Hongfu Li wrote: > From: Hongfu Li > > The memcg argument of calculate_high_delay() is never referenced in > its function body. The delay calculation only depends on nr_pages > and max_overage, and both callers have already obtained max_overage > from the same memcg. > > Drop this unused parameter and update the two call sites inside > __mem_cgroup_handle_over_high(). > > Signed-off-by: Hongfu Li Acked-by: Michal Hocko Thanks! > --- > mm/memcontrol.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 11b85f4b6828..8bdb6988e7f0 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2515,8 +2515,7 @@ static u64 swap_find_max_overage(struct mem_cgroup *memcg) > * Get the number of jiffies that we should penalise a mischievous cgroup which > * is exceeding its memory.high by checking both it and its ancestors. > */ > -static unsigned long calculate_high_delay(struct mem_cgroup *memcg, > - unsigned int nr_pages, > +static unsigned long calculate_high_delay(unsigned int nr_pages, > u64 max_overage) > { > unsigned long penalty_jiffies; > @@ -2594,10 +2593,10 @@ void __mem_cgroup_handle_over_high(gfp_t gfp_mask) > * memory.high is breached and reclaim is unable to keep up. Throttle > * allocators proactively to slow down excessive growth. > */ > - penalty_jiffies = calculate_high_delay(memcg, nr_pages, > + penalty_jiffies = calculate_high_delay(nr_pages, > mem_find_max_overage(memcg)); > > - penalty_jiffies += calculate_high_delay(memcg, nr_pages, > + penalty_jiffies += calculate_high_delay(nr_pages, > swap_find_max_overage(memcg)); > > /* > -- > 2.54.0 -- Michal Hocko SUSE Labs