From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B409F343882 for ; Tue, 25 Aug 2026 16:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787674496; cv=none; b=pQt2Wdg6jRnLg9QrUtBE4BT51zQ/01HoZCNmv97LhMMAjZWGqhFmOZ4qezI0ucDB67lNKa57H5vwR69CqtmqwBJmVmUNGEA0oKVAwb8dmHRSdJaW8+6H4j+X7Yo0If2y/DYe8ezAo9Gjj/cIMDD5brRP4/dGIe7nI6bhAIjZSls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787674496; c=relaxed/simple; bh=GpM8ASnSFiVcBDFxVqOdzWow5DVgYn8Bxd3d9ZX5sAc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nAzFRv5QSuO8H72Z4qA7sFiekEjaZ4jlYQl2XgL2IfAlwjyEHY88A85nSQyyvAA/rmG9VzIL8x0g5yImkNrC16o7pPVM6AUAB+bXGoX4m8JVajMCn9EoHhOUbOfguhu7c8QIdxQo7wJnoV1UXHwWkKoJx1qjj4W95adtdyrfJF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=RwySpcLH; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="RwySpcLH" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-8fcc43c48f7so55611986d6.2 for ; Tue, 25 Aug 2026 09:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1787674493; x=1788279293; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=1YlH5b9PYM7jA11GCLyb7iWudl/SVZb5yXn2BHQRSG4=; b=RwySpcLHfZZCAwSTCy/RmCtTQ8pS873vZtDMg8qDQL+FeD1o6ybd2ssWOdFp+QMFaE /lB5nkQAxrxQDNVWuJ9GIE0Ny+XEi9dIjY5TGEwvjBJ/nkeN/INo0S4IH5momiJb0VQt i2KVQQItZRIEVm0DdGaxvrMXO9Ede37qfkJgExpi/4e81qR3Ebr+I/Zu/CBCOwc8ZxSo lcd6ZJHfNlx9y2FDFWr0IC9BQiLu+CTXHq8SubSFj7NKoL+K1AdzChwPwmfJBTqpw8NJ oFR4W5ecwWjG8mjg8VTUgv9UjIYt7VFO2cIG2JNJeTGVH30XY208o1mUNWtNBZaUyYTf yTjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787674493; x=1788279293; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1YlH5b9PYM7jA11GCLyb7iWudl/SVZb5yXn2BHQRSG4=; b=H36biO4ikIwhXByzHRYkxQYWGJjd9MNt6H7pCp5lPtP5g7MxImyy80F3ypqkvTauvc Bzs0hWnw3acMQnRxPUknwVcLQC4nicCtWgek1AjedbsXFNrjvH345+4lNb9m3zoKQ6CO GwkarJ1d5yabrzwztqUagTXJDIoNgKNIoSiVWDOVLq0rfp57l5KnyBCTc0ncSbkhv1X4 WAhQH+xgtS9BZ0ZHCDHrrmJErA0fprAIDo3ohwZquMowm8shAcN52ZCzFmKxlSuiFsFt k5gtBl2/wz9QeTNGMtVaWjpXiUHD1eVYp8dpGu0QC9zbH/yj4rFkIAogVO10O7kTtcbC 6nbg== X-Forwarded-Encrypted: i=1; AHgh+RpLfGoWa0eaL/8n4Zm4RVymxJTWk7WAmOPRYE+y6qyO8EMfJtCyrWbb4oBlBqEc+6kFukMg8cV7gLs3f6Q=@vger.kernel.org X-Gm-Message-State: AFuF++lSJ2uQvfUnUdmo95Nv8+3XGs2fs8p7dzZPlhd7Ylr7HhRwCxh/ nJnv0k+LEee6A9TtCDQr/ASN5QXdgqE7hyFDv4DuHvZqedHHJED/jVTNcaWnTW5MdPJx2B0er2A pezp336U= X-Gm-Gg: AR+sD10KtwIvA0MWpaOxGBq+Buqm3mtkNDrsG3og15eeADu/wLYsKfZKo5PAtDUM5mi KlXb/wZ824Mwu2+xKGwAU/h9F06CptoxPOno18DuWQX1WGa5bRJZAkaGo1jzD0L9ltVj23uSfUg VTdIwaYbPwiO8kOkCGlKMZiUcV2Bnf0kkoVXRAjOI7Nkj8A9vIE6XhtX22WxCXOFzIcCTYWOv4Y 9QjKe1zK/LwGoc1dgkwIEZExeQfkgKSbOvmBaugwlxOapKi6qFoJSB8wg9v832hTCKrZ5t4jgB6 JBJPWxgC6xSlGzMV48fDNE1bXEOnUN1FkclXSpzlkkHvAFdwjp1Jh04MNCsmM6S6LG+C6oroxPM frDF2wxOU3tB6W6dO0rjTFdlHpzOxyab+GJt5v4lahxyTkQjNVJoaak/h4RAU1PCeZcDF6CCbr4 65MPrft8du/mAm7VSGBIGrU/tSXDFeULVPAsM3hc2sDuN+1clOuTf60ImmUygmsyEHCFPiE5byb rhhucv2/9zAEfZGAMrqOFeczYx//lcqniViF2nXi1aecTBXJ9dxU8Y= X-Received: by 2002:a05:6214:3114:b0:8de:25f7:98bc with SMTP id 6a1803df08f44-90c8fa2ace7mr324838386d6.22.1787674493270; Tue, 25 Aug 2026 09:14:53 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90cc63c68acsm2381676d6.10.2026.08.25.09.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 09:14:52 -0700 (PDT) Date: Tue, 25 Aug 2026 12:14:50 -0400 From: Gregory Price To: Hongfu Li Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongfu Li Subject: Re: [PATCH] mm/memcontrol: remove unused memcg parameter in calculate_high_delay() Message-ID: References: <20260825120153.1405-1-hongfu.li@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260825120153.1405-1-hongfu.li@linux.dev> On Tue, Aug 25, 2026 at 08:01:53PM +0800, Hongfu Li wrote: > From: Hongfu Li > > The memcg argument of calculate_high_delay() is never referenced in > its function body. The delay calculation only depends on nr_pages > and max_overage, and both callers have already obtained max_overage > from the same memcg. > > Drop this unused parameter and update the two call sites inside > __mem_cgroup_handle_over_high(). > > Signed-off-by: Hongfu Li Reviewed-by: Gregory Price (Meta)