From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD635448B94 for ; Tue, 25 Aug 2026 13:44:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787665486; cv=none; b=MgqTXF+72yx8aJqub2WKzv7bq1SiE3SDu2ImWA+F9R/6DTG27BDhPdsJns2qGhEaqMr0yHXCBr0obZu0bseApVahcFL3LA9pn8hKdgnMajand4eLYdIuhgMGx+JTBmna3PRkfm2I4Jy3mgMXWy2T1HxoxnZWsY5N8WN5SX7gx7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787665486; c=relaxed/simple; bh=CBSGTeD2DadqM+3ccULAz5mzpkujH+JD/EiAIxdSvQE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cVf+GwqNnR8hi9f35wEteylGNCvwnMV/+2hjD0IenM2fwFz01uU9pFn8tl/ckErEb3uHK9a4MwI0ZpfSdQwBDMpzOepOGr0C1ZOcpcBeRGo6RgBIqfBC/OVoMTZgJ2PTWnpvA2SXhw/Uols3wE9FVf1itaiR9U3OoxewQVE4eNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MnRhtGXF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MnRhtGXF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2D651F000E9; Tue, 25 Aug 2026 13:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787665484; bh=DkTn0eYyAXDRxvwSqgg0PBN5TH68oAOpRj68mw2xuxc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=MnRhtGXFgQQuiajgEJ6xF+kLWcwLEfjiNk8uA1f6zKX0mg48n3/uNM/Umhw5yFb0u YFV+O/mNYel9XMe0Pr8Ui5B56fgG9K1StqvAjFxxseRy6VU8zK2md1OS2OSl6gjdDe n+wKzinXMY6Dn1da34X7BpAOScT8OQPdJVJGm25IfbzYingxl8+h4loSdHDE8xHnhG GBeBMYxieMxUnAEkykLkXl6faeNdLpjLIHfVcHpOuav7pDPQnMn5iqDBRVjrQVhMjj sZeQYhWsgQZzwp5QQrVvMKCAeM/u+eVJsbcm/Md8ttiQdthr47ae3FwTuU+PnNfVFv 8HllCvZkmCSwQ== Date: Tue, 25 Aug 2026 15:44:40 +0200 From: Andi Shyti To: Andy Shevchenko Cc: Andi Shyti , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter Subject: Re: [PATCH v1 1/1] drm/i915/gem: Use simpler versions of min*() Message-ID: References: <20260825093552.4088094-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260825093552.4088094-1-andriy.shevchenko@linux.intel.com> Hi Andy, On Tue, Aug 25, 2026 at 11:35:52AM +0200, Andy Shevchenko wrote: > Instead of harder to read min_array() and prone to mistakes min_t() > use min3() and min(). No functional changes intended. The types of > the values are unsigned, no side-effects are expected. > > Signed-off-by: Andy Shevchenko > --- > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c > index ef9440166295..bf9e7480f0f5 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c > @@ -153,11 +153,8 @@ int shmem_sg_alloc_table(struct drm_i915_private *i915, struct sg_table *st, > } > } while (1); > > - nr_pages = min_array(((unsigned long[]) { > - folio_nr_pages(folio), > - page_count - i, > - max_segment / PAGE_SIZE, > - }), 3); > + nr_pages = min3(folio_nr_pages(folio), > + page_count - i, max_segment / PAGE_SIZE); thanks for your patch, but there is another patch involving (and fixing) this line of code[*]. You are welcome to join the review. Thanks, Andi [*] https://patchwork.freedesktop.org/patch/746877/?series=172332&rev=1 > > if (!i || > sg->length >= max_segment || > @@ -168,8 +165,7 @@ int shmem_sg_alloc_table(struct drm_i915_private *i915, struct sg_table *st, > st->nents++; > sg_set_folio(sg, folio, nr_pages * PAGE_SIZE, 0); > } else { > - nr_pages = min_t(unsigned long, nr_pages, > - (max_segment - sg->length) / PAGE_SIZE); > + nr_pages = min(nr_pages, (max_segment - sg->length) / PAGE_SIZE); > > sg->length += nr_pages * PAGE_SIZE; > } > -- > 2.50.1 >