From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B044A3B6BF1 for ; Tue, 25 Aug 2026 19:00:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787684409; cv=none; b=LtHftIZu93tccg722lWYjHF8RylO/nSqAX09rM+j1gf+hP2LryJjJZh8BChXLe+Iq8zg7I6zRfgjjUyV+Z38gUELVmXF7A1TvokOK4IWhy7wb5oskgGhn6RDGkrYX4QqQdt+PJ7F2fqcShyP/xrz1bPO2wzCEa+2hI4HGjJOqIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787684409; c=relaxed/simple; bh=EvjzQ2JgourrV5hTDBfbWkDyqNCFUyc46HJ6jsUzS5I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oQhfIEV4Fsm+slsQR5nYuhVxeQPcLaVo7tBldyOd0CYyaKAwqn0vfIF8q5lPLMLE6spyvbF7VdIVm0BeoifBz/EjKC9HRYLbCHZQVyAtfaiDyUrlPl57cj/Ks6KftcXITylEIN+FGS6VXVuQoE3O9PtYzyBCssdsvKyYUWsp/us= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BjLaWUIf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BjLaWUIf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED6911F000E9; Tue, 25 Aug 2026 19:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787684408; bh=Q8NRlw8mgX5Y5GcLyGQnNmSW02HpPrzPblnKZxDaYac=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=BjLaWUIfE1RQnPoXpD+zx7gZNFniGNX24P91ICPb9WE7SQNmxsmx/jy+uS3ei7iQt acfJNV/PvgPcvfQj3bvkf5wjJSaKmY2yKZd+1eMumDdpsSXbGnEo++uw4okXcufVJH zoTJRjPAXP2iOl++y3Ma9q2EpXbreh2kGGPY18w5Y8cx8BCXFlQSUHchrbdiNfJrz5 m3DxJmMfDVKKC90m0F9BrK0lmCgian1kE+cc+oMbGC5rS0fSce/WKs43ABW/tsVkD/ 8F00dQwx1JWz0MNtkWLdaB0ANJ/8yBhGIkSg38C+g5aDMyWL9pcyCoEFaD481DAG5d ySeSSEc8uWXIw== Date: Tue, 25 Aug 2026 13:00:06 -0600 From: Keith Busch To: Yao Sang Cc: linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, dwagner@suse.de, hare@suse.de, johannes.thumshirn@wdc.com, martin.petersen@oracle.com, javier.gonz@samsung.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: fix command effects log lifetime for multipath heads Message-ID: References: <20260814070651.3973067-1-sangyao@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260814070651.3973067-1-sangyao@kylinos.cn> On Fri, Aug 14, 2026 at 03:06:51PM +0800, Yao Sang wrote: > @@ -4132,6 +4125,12 @@ static int nvme_init_ns_head(struct nvme_ns *ns, struct nvme_ns_info *info) > } > > mutex_lock(&ctrl->subsys->lock); > + ret = nvme_get_effects_log(ctrl, info->ids.csi, &ns->effects); > + if (ret) { > + if (ret > 0) > + ret = blk_status_to_errno(nvme_error_status(ret)); > + goto out_unlock; > + } The effects should be the same for every path, so it's a bit wasteful to copy it for each one. Perhaps it should be just one effects log per subsystem, per command set, and the head points to that.