From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Wenjie Qi <qwjhust@gmail.com>
Cc: chao@kernel.org, qiwenjie@xiaomi.com,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: don't leave the hashed inode while it's unlinked
Date: Wed, 26 Aug 2026 00:11:49 +0000 [thread overview]
Message-ID: <ao4vRT_SbvNfSUTD@google.com> (raw)
In-Reply-To: <20260825173111.1151141-1-qiwenjie@xiaomi.com>
On 08/26, Wenjie Qi wrote:
> Hi Jaegeuk,
>
> Yes, that's true for the normal path.
>
> What I meant is the rollback case: err is non-zero, but __do_unlink()
> may still return ret == 0. If the preceding f2fs_add_link() has already
> been checkpointed, a crash before the rollback deletion is checkpointed
> could expose the incomplete symlink again. Should we run f2fs_sync_fs()
> for !ret && IS_DIRSYNC(dir), while preserving err?
I get the point, but I feel that we don't really need to guarantee unlink, since
we're going to return an error anyways?
>
> Regards,
> Wenjie
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-08-26 0:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 20:01 [PATCH] " Jaegeuk Kim
2026-08-19 2:56 ` [f2fs-dev] " Chao Yu
2026-08-21 15:23 ` [f2fs-dev] [PATCH v2] " Jaegeuk Kim
2026-08-22 7:37 ` Chao Yu
2026-08-23 9:56 ` Wenjie Qi
2026-08-24 15:12 ` Jaegeuk Kim
2026-08-24 13:16 ` [f2fs-dev] " Chao Yu
2026-08-24 20:12 ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim
2026-08-25 2:15 ` Chao Yu
2026-08-25 2:39 ` Wenjie Qi
2026-08-25 15:29 ` [f2fs-dev] " Jaegeuk Kim
2026-08-25 17:31 ` Wenjie Qi
2026-08-26 0:11 ` Jaegeuk Kim [this message]
2026-08-26 3:41 ` Wenjie Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao4vRT_SbvNfSUTD@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=qiwenjie@xiaomi.com \
--cc=qwjhust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®