From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E315A1DD0EF for ; Wed, 26 Aug 2026 02:42:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787712142; cv=none; b=cQruuMTuX42WZsijKzM+tOH/8hVyfEErXZKhs2V0BCwvl65FODA/YnL1wYkkH2494+F72lsCLCaNA6SEX/5lhZRvLskgiLKTsjRfCm2oyECZfZ4pSJLdRJb8oPW2bYoUcEAgFglMMAl/sGChC3cKIUEuUv2YAOqZ1bbEl2Ha4WM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787712142; c=relaxed/simple; bh=MK2sz8rhggG8cCbmuFgTlkrX3wHAnXA2sf+rDggNIsY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JATz6iWuxOc6ruTtSXxjt15n+OcuZkoj6ZP3JRTIbRZLGlbQ492AGU76CyCQ4rTC9hVXO1v69MRLiFRp/ISeXFTaLMPajqiScbZAOCJGbGPBTwoMcoaCmMQKCSX1LOPX3SXOjMIHRFsbU4xI8ObTbKfKLTeabkcsye0CQrb72IE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SPCJvolR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SBtGXrnM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SPCJvolR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SBtGXrnM" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67Q07YGr3487512 for ; Wed, 26 Aug 2026 02:42:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=g7YJVDPj8WToA4pt+4ykVGH2 7m0lY/z7+T+UCmN3BYc=; b=SPCJvolRxNsgh7RWZAA8Ea0GlE2FwwseljVsf/dq 3FFvuxZ6W7oifGUl9hReHyein9Hd5pGnvSu6Aq33bFkdb/g8eHsfayq+heMPfYR6 RSU2SE1QII4a5Hc7TvIG+6BObIKI4N7HRqsB5+Tmtk1yQ5WtIt8RB1OPMnwzKEHi HixaysAhUFiBIHUg71wK6Jm07MJ6JD5jyMZX09raRy9iPdBwc0YQkHeNt/B/SzkF xHE0sbi0Lau634x5eF2O/QDnx9PAAId9l58iHwIMCvoeQ3qoArUEBPq+WBAmez0m pC13ZDUv/R47TGHOuXZhifrUCMAMgufDpQGtNI+ZSEuP2A== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g9g4msek1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Aug 2026 02:42:18 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2d04908139bso7698405ad.2 for ; Tue, 25 Aug 2026 19:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787712138; x=1788316938; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=g7YJVDPj8WToA4pt+4ykVGH27m0lY/z7+T+UCmN3BYc=; b=SBtGXrnM15u9hWJoncYTYCAQzFGlqaK1lIb1pRgcvuv4Xs8Xiy3HVWQOgO2aIZmDFC IR00SjrDbSV/hX+Qm1VjyhAMdJdUQSBIZrlHdV2HZtCChL8LRoIcDMWKZosktzXOBljZ KcsVy4IEAa3PofYmy30KroOPGf1M+g/S6PAM5vglNXKgBmnWVuZIos8aacfX9jTe1ZRr BhVkFS0h/y26a+2g7SNhaLYQ5usvK6ZiXUpiorxrDLAe2xJlwhSxXNTdupuA8LMeo5zT 4BmNzTMExDJYT7vak7lGK2ploIv7xPC2Pbad1av+H9qdeFRAJvR/c8MAI04nNeVE84XL ekJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787712138; x=1788316938; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=g7YJVDPj8WToA4pt+4ykVGH27m0lY/z7+T+UCmN3BYc=; b=BjkSl8OFR6/hY1VLzWtprU39ZIoKmrj6+Pigdorv77Ivp7T8IIny5D8q7MC38VSyQQ o0vunrmt2/fciq/sjeXP2k6iYgJ9il23kQp5NZLEY3v61j3mwy3YDTzle5QQ/BOZ4UYF Ih/yWHxreXJ34ucQiT659LmGBgEmkmqlDeVy6Qx5L6i4CTjQdnlxSypqrlTbnIxUy6sZ QKaOyZKwA+jjrfSDf3D+PQuXMYHpW/wIU8ix9002MgqQs72V7hzKlpk1K20dyE6L4DBw GDKe6KTcN6NR5Bn0ZxJGsg5wLoiZoRnDwZ56H7zclnrEWztuD9q4Eo9NGdtNTZpHnbn5 lwMw== X-Forwarded-Encrypted: i=1; AHgh+RrjxzU4TAuXM0LHdw0892ouzFzmKqc3HjtdUjEZpl/BEFmwQ8iWqPpq/tl1gHQ3qzPvK64ppFOwjm46nbg=@vger.kernel.org X-Gm-Message-State: AFuF++lCCZEJgHi6G7WznURvD9ixMjqYHP2HyZZ6fNMnce2F8dLSinnM bSwyoTTVIOSilYrtQKm/YRE95nrzkJJ6Xbou5k942U9Wds4P8Fj0sGnIBIcHjCeqkbsicU/85C7 l9o57/hYPnY4c2y5bIpGSEC0ezg1WS57B7QWTmyXtgakIot/erfVEl0aydoVOlwxg6jA= X-Gm-Gg: AR+sD113AeFRp13/kC2S1MZyREPajhGrmMrdy8Ghs0hmYDWpwDxFNYxslmkGyoLi9qS pz98ZA44JdPOH08hvIhIGazJeIwf10w8LdkWQj4zcFAN1y6qPmWtxjuszZ8Wj/l2MMQPoe3RMKp UGWAIbBGh1ZcdrvWhDh0m0O38fK/XKf0QsVflQcMjCQJs/Yt1cqHgS21fLOEnfX08btNWkC/MTy nMQofqMLL1R3QvzRn3US+PPbHb9J6SkmWIpfXOTASWwghLdiL2zjVBMVJ10bchNFkgL/S5Y8PZ9 IkuEms6KqwV2vWBOUtvZoxDyOo2de4a4R85pE7AKT/ls+Rd6SizdSwiYoQDRkRHxgW49xIYCSnD tiXvdhF+P73uGQWCeDLcVLG2RZDgs9Fx3ou+UtMF5SX0= X-Received: by 2002:a17:903:19ed:b0:2cc:864b:539 with SMTP id d9443c01a7336-2d7079ffa9fmr55064025ad.6.1787712137702; Tue, 25 Aug 2026 19:42:17 -0700 (PDT) X-Received: by 2002:a17:903:19ed:b0:2cc:864b:539 with SMTP id d9443c01a7336-2d7079ffa9fmr55063225ad.6.1787712137255; Tue, 25 Aug 2026 19:42:17 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3283d730c57sm3775785eec.12.2026.08.25.19.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 19:42:16 -0700 (PDT) Date: Wed, 26 Aug 2026 10:42:11 +0800 From: Shawn Guo To: Krzysztof Kozlowski Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Mukesh Ojha , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] dt-bindings: remoteproc: qcom,nord-pas: Add qcom,cluster-root property Message-ID: References: <20260815132541.1575121-1-shengchao.guo@oss.qualcomm.com> <20260815132541.1575121-2-shengchao.guo@oss.qualcomm.com> <20260820-controversial-mussel-from-vega-aaba16@quoll> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260820-controversial-mussel-from-vega-aaba16@quoll> X-Proofpoint-Spam-Info: AW1haW4tMjYwODI2MDAyMSBTYWx0ZWRfX5KVqwuHSJgSZ 1c/MWO9yyTwxdMusipoONuNHCMwsDtXOTh8gF+isV/tV9GuTD3rlfoZr/If4jn+G4+k2JKADwSB k0C5Et1IU6KqejI0BF22UdcvpIl+r0E= X-Proofpoint-ORIG-GUID: zRonsRdu2qSYXVr6WkYQ15pF9RQI501m X-Authority-Analysis: v=2.4 cv=eYgNubEH c=1 sm=1 tr=0 ts=6a8e528a cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=0bSYeviQ84LFTGsDHmkA:9 a=CjuIK1q_8ugA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI2MDAyMSBTYWx0ZWRfXxiegWBKdZzvq PQfuWXGTJNh+MYjcenilvWrSJsu4Fc9pAwdiYUnhCfb0n3RtuZUtY9ye04gcmzsGcOcpohVbiF5 pQzCF647TymMbyyQ6J/NeXKygRxXSuAOS7gQkmqrnMZ5E5reagCTGJxOmWAZYdaIr8mV6kN0rQD DxeV7fBa/EKppOKD54exTkmf0fjLxhMH/lydJGugfMbkT85gnttFTU2C4oJ+1jBCbE6K2e3fPPJ mDvRTijFFGY9zukmwpfWTtGF0m3OC4Nr8NytTE4c6yzjOTHxtmdWzohcdNsRL3H6UmdOSjB8TyR r5DqTI8BUcoZztKLGAcIPNQK4R2jmnVzuVEdDH+ICGaEPsvPF1RB0XuK9s3X6de4SC5yUPQn9rv ZDkX5bZCKVACtprvTbjmzGes5JJ3Cgsp86F3ElZKhDosQglRRIEM6vda6Bebl6uqyYlOSwkqru0 d8a2AyRGYV4+t391lcw== X-Proofpoint-GUID: zRonsRdu2qSYXVr6WkYQ15pF9RQI501m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_07,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 phishscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608260021 On Thu, Aug 20, 2026 at 08:59:48AM +0200, Krzysztof Kozlowski wrote: > On Sat, Aug 15, 2026 at 09:25:34PM +0800, Shawn Guo wrote: > > Document the qcom,cluster-root phandle property used to describe HPASS's > > ADSP0/1/2 cluster relationship. Every member of a cluster carries the > > property, including the instance owning the shared resources, which > > references itself; instances referencing the same node form one cluster > > that boots in order and is torn down as a single unit. > > > > The relationship is described with a phandle rather than by containment > > in a parent node, as ti,k3-r5f-rproc and xlnx,zynqmp-r5fss do, because > > the hardware does not express it by containment either: the three QDSP6SS > > blocks are register-independent, with no shared register window for a > > container node to describe. > > > > Also add the qcom,nord-adsp1-pas and qcom,nord-adsp2-pas compatible > > strings used by the non-root cluster members. > > > > Assisted-by: LLM > > Signed-off-by: Shawn Guo > > --- > > .../bindings/remoteproc/qcom,nord-pas.yaml | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml > > index e90d2953ba69..58d88cb07e52 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml > > @@ -17,6 +17,8 @@ properties: > > compatible: > > enum: > > - qcom,nord-adsp-pas > > + - qcom,nord-adsp1-pas > > + - qcom,nord-adsp2-pas > > - qcom,nord-cdsp0-pas > > - qcom,nord-cdsp1-pas > > - qcom,nord-cdsp2-pas > > @@ -89,6 +91,19 @@ properties: > > maxItems: 1 > > description: The names of the state bits used for SMP2P output > > > > + qcom,cluster-root: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Reference to the Peripheral Authentication Service instance that owns the > > + resources shared across this DSP's cluster. HPASS shares clock/reset/NoC > > + resources between its ADSP0/1/2 QDSP6 instances, and the owning instance > > + (ADSP0) has to boot first to initialize them before ADSP1/ADSP2 can cold > > This feels way too much SW. We design hardware resources in > owner-independent, meaning each device is the owner. Most of Linux > frameworks, including listed clock, reset and ICC, support resource > sharing for multi-owner case. It's my fault. I should have made it clear that the shared HPASS resources (CRM_COMMON clock/reset and the AG_NOC bridge) are not visible to the OS. Instead, they are programmed by TZ, on the owning ADSP's behalf. > If this is not SW related, then I claim that compatible defines whether > services is owner of the hardware or not. Good point! I will drop the property and try to derive from compatibles. > Also, unresponded Sashiko comments. Yes, just wanted to get human/maintainer's view first. Shawn