From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0E542253FC for ; Wed, 26 Aug 2026 03:35:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787715311; cv=none; b=pVWU5r9k21Yaht+qP2CO5iPsvTZyQa4ILOMTJj+ysWh/67ljqkcTuPQ/nSF43XeeYFpUSsPqygF7b3uI5m7nj07+Z8D8iBXaBMjiNOqximDfRi3RgxWvyAPkzp9qB6QYT9kNwRDUyfz7B1NZHM5BbuSoltEa1CxfakHNaccuBKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787715311; c=relaxed/simple; bh=KlZ5r0TGY/d3yFQvd+ac+DNpJPMoDwNE6F2poWE8s1U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YG9fR0B+kYb7LcDn9kGZ2d+UOlQpgaWdhgCaG3ZdziMbV39A4ik5lYykR02QRtmbkXMwKtuTrccjYi87by7uTG8qjIYMllmF7W0FcdCnCiprtMmi0vnydJ7asvr32OuVBMcX5qWMC0+zFllwjCz/imSH3YpiJKDZ4DBoH9z10gU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nT1DRw1K; arc=none smtp.client-ip=209.85.221.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nT1DRw1K" Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-5bf959b820cso428310e0c.3 for ; Tue, 25 Aug 2026 20:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787715309; x=1788320109; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=MDoKigPjvswwl+8EcyWhXKw2z+QvC5L4RMofPPBGe0Q=; b=nT1DRw1K7FxbQmhFWuzCocfSyO3HahVlu2skVR3zq0YYSAj7F4gKSeZLI6iNQsXbzq XLteEdus1vJaB1hCh4naWZvJlIxDqukE7Kz4BXrxXrOqyxa2mlc5SlvUj7xALVK+A6mA I44CPbiuZnRt8emxhFKc7PPVx9b7S/3WQrkmiR8N2t8CYNcVEzGIcjrjjtHa8Y8hrqp5 EAXxazI1iA3/zWKIQvr9q8LJaNYN/MOt5zsEazQvqy8+DtAHrlXyOp2hjhjPHuRWpo6I YlkqV2/LWYuYsahPJ0wwmYmduAQ5mLnjlCPDlYws7rnf7HeLtIb6z6XmO8qGSH7+Of11 QcJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787715309; x=1788320109; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MDoKigPjvswwl+8EcyWhXKw2z+QvC5L4RMofPPBGe0Q=; b=cJNwGpjlk46Ayw305fH5Dmm1xRBJSyjy7vzS8JskMkquRFfbBVuHGXQG/6CZwVcilR MwScurfWR2L3ToU1mmE4KF/yzMOHRRzVSB8HfCoMl3aJo5NX8md5UALRMhpjADZMA+Lk QaWLUdgc1QNNo+U1AGCnAu/79PyzmSsxPaWW5g1nOga8ZnWo9M7yBq93SRnuMx6EYWIu FyDznQQh1YGTy8qVD0sLFMCGZp32z74V2ZWGwJwzjNdbatZb2sbBEB1mX9nDMaf206Tg Jbb+9JTB07e8GztedTGglFrI7N9p+wZBLxwgMiICQNT1UjTaJiGFGJUWVEIR6zffN0so E8oA== X-Forwarded-Encrypted: i=1; AHgh+Rom7ztNzNv7oota4rstKBl+Omp90mrwKvxFSpNWQ12MJkC0b9T2B5JNVp3B/OaZ+dKJ1Su0iilHOD42N3s=@vger.kernel.org X-Gm-Message-State: AFuF++kDvF/1lTWxUSDXk1+fydLX4Xm0kh6FotNOn0McTn9uOHayOoeV yRMWMVk3LbKAOSLJLEAfS31oC1DfWchh7wXBwC8tIEBL+zLVxRh9MKqf X-Gm-Gg: AR+sD13B/nEZVkwVs8UOGtvdeRVufowLDiijV2TIEHM7193SO0UOUOv0owXtKTrgipf E0YZUex4hhtVzO9IaqB2Elafk9tC+PEh0apjXYXDU7IYDQMHUoTMH89EEBmcUIOdLX/sfFXPbW2 skp2eoDCb3ROp0Dh8BMks6KlWLHeSOdZ7qWaGJQHwpFA0K573L1KtWX5ye0gNzHEX8uCn3nBcmn P/MOkG6XBunNzWhOAJVdxlQmzBk7S4pu2LNY/hbY96CA6X5MSTzEbi5DB9Qt2xqhgGtdD2GtCA1 5/fBjQdHvDelJbDG2cSMWWqYKSLtWzLlBMM50umyty9y/Hp+YOdrtk+H4RG7ZrWZS7QymhSaHbn ysOVJvg0nnqITGhIKI0Hl1hvCfdgrUv7TAvl0Qq7XAjhA1braYc7EJwkn0FnO6q2cGru0twRSbp E5CNNGdr2EXzEIyBR0trZqeRpJ+Ysq6jYP8LvnU225uLMlWBeFaIpD8BxYfOyQepip6Ar2 X-Received: by 2002:a05:6122:507:b0:5bf:8c77:e89a with SMTP id 71dfb90a1353d-5c65ba76c6dmr1360903e0c.2.1787715308746; Tue, 25 Aug 2026 20:35:08 -0700 (PDT) Received: from localhost ([2804:30c:97d:e800:9454:1179:18df:ab33]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c660014355sm588803e0c.9.2026.08.25.20.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 20:35:07 -0700 (PDT) Date: Wed, 26 Aug 2026 00:35:49 -0300 From: Marcelo Schmitt To: mdshahid03@gmail.com Cc: Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/3] iio: adc: bcm_iproc_adc: use devm-managed mutex initialization Message-ID: References: <20260825172155.250484-1-mdshahid03@gmail.com> <20260825172155.250484-4-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260825172155.250484-4-mdshahid03@gmail.com> On 08/25, mdshahid03@gmail.com wrote: > From: Mohammad Shahid > > Use devm_mutex_init() to tie the mutex lifetime to the device and > improve debugging when CONFIG_DEBUG_MUTEXES is enabled. > > Signed-off-by: Mohammad Shahid > --- Reviewed-by: Marcelo Schmitt Though note the device driver currently lacks an include to mutex.h. > drivers/iio/adc/bcm_iproc_adc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c > index 1464c60bc83e..9b299e2c3e0c 100644 > --- a/drivers/iio/adc/bcm_iproc_adc.c > +++ b/drivers/iio/adc/bcm_iproc_adc.c > @@ -530,7 +530,9 @@ static int iproc_adc_probe(struct platform_device *pdev) > adc_priv = iio_priv(indio_dev); > platform_set_drvdata(pdev, indio_dev); > > - mutex_init(&adc_priv->mutex); > + ret = devm_mutex_init(dev, &adc_priv->mutex); > + if (ret) > + return ret; > > init_completion(&adc_priv->completion);