From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7D7338B7DB for ; Wed, 26 Aug 2026 08:35:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787733315; cv=none; b=t1FL5wWE1Okm6gMr7MG/BdS/p1oQ36Cp7oBfqEuvDIq1SyiZZ6SYZza9mEiqjmwc5ptfEVHhK95gAMj5bVSDqwh6m4Xa7uX12Z2oXXjjCbjM/rALIHoGnWj8Tw56XVK9jUzDocOQ1hb83/9MiNcyyn1sEWw0C5UDlrPWsbE+7yI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787733315; c=relaxed/simple; bh=Kz168AtLmlRcggGQwFRg/7YFC2pWvXjQBuHjsCPkXSw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hslXlTkSLiUxCRMncTvuBr+Zo+M1zf8jHOejoUeiCYnVBZUFsdiaW176lYB7/cc75kmzDjE83wXCMHGD+tJ8KGcdk348QWyhzBogeHU2mWSIbhyM7pb+k6+iTL9/xMcMyswDNNDpPwe1cUbx33TOF75PJNzQLj4/ahf0wD2L/9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=M+oINuky; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="M+oINuky" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787733314; x=1819269314; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Kz168AtLmlRcggGQwFRg/7YFC2pWvXjQBuHjsCPkXSw=; b=M+oINukyM8Q8G9Mp/ts71VS2cmhyeYJ7KpiOIObRf7l5jPi0JplMcqMl Dic7EJxK22bFsvfA3zklU4WQcGr03d7oLtdYaOpWQNkOALahAVXbQ+RU+ 8I4A8azkTeMUxPwi3G7jvbbCj0lsqWc8//w/DX4qNTaTkiSkcEuYQdMHk ehMAA6XzkrSW+AYy1M/YbVed8JeAY6hSmUnpEF+/TKoZ0+Rct2rjZPKt9 NdZPDnd17+C6nUwPgzSVTFnZGGbBwm/CUjF1aPVTR034E9sqQk+RpiZBO kmCWonYOzvN/UfVTnMCN/c9NAfNMVIvmuwJQULDYVuAgP27Euz1mltvHt A==; X-CSE-ConnectionGUID: r0rVITU9Rm2HqR/X+oLz2g== X-CSE-MsgGUID: vPh6FxXvRr6LpP98mULhmw== X-IronPort-AV: E=McAfee;i="6800,10657,11886"; a="88237342" X-IronPort-AV: E=Sophos;i="6.25,244,1779174000"; d="scan'208";a="88237342" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2026 01:35:13 -0700 X-CSE-ConnectionGUID: k+pPWYKQTD2IpaS0xJ7ZwA== X-CSE-MsgGUID: m0JrqszvQSaDDVkln2MI/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,244,1779174000"; d="scan'208";a="266228480" Received: from ettammin-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.235]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2026 01:35:10 -0700 Date: Wed, 26 Aug 2026 11:35:07 +0300 From: Andy Shevchenko To: Andi Shyti Cc: Andi Shyti , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter Subject: Re: [PATCH v1 1/1] drm/i915/gem: Use simpler versions of min*() Message-ID: References: <20260825093552.4088094-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Aug 25, 2026 at 03:44:40PM +0200, Andi Shyti wrote: > On Tue, Aug 25, 2026 at 11:35:52AM +0200, Andy Shevchenko wrote: ... > > - nr_pages = min_array(((unsigned long[]) { > > - folio_nr_pages(folio), > > - page_count - i, > > - max_segment / PAGE_SIZE, > > - }), 3); > > + nr_pages = min3(folio_nr_pages(folio), > > + page_count - i, max_segment / PAGE_SIZE); > > thanks for your patch, but there is another patch involving (and > fixing) this line of code[*]. You are welcome to join the review. Thanks for pointing this out! Do you prefer my to be rebased on top? Otherwise one can apply this patch first. > [*] https://patchwork.freedesktop.org/patch/746877/?series=172332&rev=1 Note, my patch doesn't change existing behaviour. -- With Best Regards, Andy Shevchenko