From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6540D48BD29 for ; Wed, 26 Aug 2026 22:00:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787781657; cv=none; b=MiBk7GOg2ngN8ei/4oWWeQNpzoZlHp+LGqRzqa9yyuKfioart3uX2VbxxQbv1v3Nh/4qSVbJRLt+6F7IiWkh9YDafc34oP5dZPQK6w2aOk9iImIvDqdUqHWBXC72vrGUxr8S8sfl9yEJxhY6vuv3w97a6kmE4DK/gSlukqEqs0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787781657; c=relaxed/simple; bh=pSMZBCmZdwJl2+Tztwxeju0s8pHDF5EDzUK6p4kLR4M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FIKQ91o1VsrjIAZb0o4GQSI7Rgz+/C2Ql0zEjcYgioHJM8OQS35OQuFmpLTRd5VABzhNQ/CDTUDmANPX6IOatUISnNfdxnex1l2wSMvpiJoLAGdV8Mk13nsCB+duLMi8vkx0JZf6n4I3iptXTy79QbRObj3G66O7rg6G+E/V7KQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=eaRZT37A; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="eaRZT37A" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-8f0e5e36912so7737096d6.2 for ; Wed, 26 Aug 2026 15:00:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1787781652; x=1788386452; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ccSJiEqmW9tfbUwLonoOgEZaq7ANVD+gHAZIRsMNs9E=; b=eaRZT37A6jBytfzoQposHJsFeT+uwM4hm6vGLK3ad0pF6e/5kNVd3nPQUzoCFYXNpb Bz+aqgzHEvmLsHPRsfMQ4jRO/HktmTNolI/I4m4iouFsRWeVHI3ULDZnRQytmvY2icwF gQhkEH/lJFOwiHrxavLBxpG+QgIsDr6JAF6cSYUb56sZzXSNjqyvtP7EZB9BsWMa0qWB uc3+4ituK5VJJ7+QnK0k3Ib5SCMgLX08GeqePxSs+5SQQuxix2586q26oHDrOwnV1mr8 jg0CWZ9XBf4fj+SqqZBF4rG08vjnN+amjCt6dt1bwB0WA43t+8IAXZbC3TFErajjSMD9 TxKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787781652; x=1788386452; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ccSJiEqmW9tfbUwLonoOgEZaq7ANVD+gHAZIRsMNs9E=; b=sdEw9HRg1MY84zoCtVOIOf3j5X6nZCfm+rBGmerfmdnirSJDzyvhBcy+7gt1t4aSvh BdwtYxHarZ/gx+E7d4JhB8iayrxugUZ2F3n9AKHaUEUjvdiAiRig+yIjoPUqK/TmrSHH GgBi610voz7Ue5oq3lEI6m9FrGff+DR9Gd+XPqV4QtqIi83675dqQWB7OO0lPOu/t2J7 zAe6zUKakKf6Z2Mb+UMRnJIRTJo69EEZTif3krQPdVTLVpkdI3ehxzsaf3ajXlM9grXU ltDskMUe/kiIzhL+2Vns8iGoaJ61vj1wZH2fPCF9xbCbBRLGshokTx+48GFDWdjBJkTv db5A== X-Forwarded-Encrypted: i=1; AHgh+RqEXiUjx7PBqeZrWXnFfx8UzQqjKl38BrWrf8z7+WUmwkP6W2pPQX2AN1sQlluWLihI/24xZ/OyD/sFL2o=@vger.kernel.org X-Gm-Message-State: AFuF++lVWFGO6pXoKlCW1Njs/ZJm+UFZ+GLJNanmhTdWhd8yNqlHMqog gQ9b5pnzlXva8TWl+heus5R/Ag2h9sWM7AYNNsqKW1d5BEo5MZ6VSdQrBXmCL2ohK1w= X-Gm-Gg: AR+sD13TIefRJfaZktadk4WTaJoExPN41E25o8LspkWqsv4NChfd1CRvi3X8MuEi5T/ fTIeMtsjv1KKXLm6UoZjs5am/aCsfe/h4dwQTAUj1nXXBvAyB8y3DahrbMGUbLf+nFq7GB04E4N 7GwrbkdqwTzMAc8YGSLkAdW4uzKrR+LNikyvsl+5esLAwRwk+TuRtEj9znVyvhAr1lhon1Jot71 49ckBC8l60UVZMCNvZJfGubJu4dSnn81gDbmidZCf2hL7pAMDHRGjTxzr16a/e0SxhH+RiwLFD0 VP7skZ1kw01N6OnQ2nwjTFAzLVEh3FyNt2niy7hWuID1TlpYuB1N/j+V/6wBF04eVzZ77CoM7J6 24ZwTuMeziz5Ai9UZFvYTiXlzBrVQGsrlporFem+Jx+F25JhyboOxHUN0yTPI0mpTaFh7iN9KiQ t7f+Pxrm/oWPJ+E4Ixuo2tFBs3OQ0+KEXSMTkBzZ59FukQfE8kqzrZUxdfGQ9F3q7ss0aSC/vQA W0ZVr8m45pmhHJjxdo2kMmX2ZQm+K13TqTppCj3dslF X-Received: by 2002:a05:6214:4606:b0:908:9c82:695e with SMTP id 6a1803df08f44-90cc77d3a9bmr140900116d6.0.1787781652321; Wed, 26 Aug 2026 15:00:52 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90cd70287besm991216d6.12.2026.08.26.15.00.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2026 15:00:51 -0700 (PDT) Date: Wed, 26 Aug 2026 18:00:49 -0400 From: Gregory Price To: Christian Loehle Cc: Shuah Khan , linux-kselftest@vger.kernel.org, Rama Krishna Katta , Thomas Gleixner , Gregory Price , Kees Cook , Peter Zijlstra , Andy Lutomirski , Gabriel Krisman Bertazi , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] selftests/syscall_user_dispatch: Skip tests if SUD is unsupported Message-ID: References: <65c35ccbc7db2de2cb600439874e585775362580.1786965107.git.christian.loehle@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65c35ccbc7db2de2cb600439874e585775362580.1786965107.git.christian.loehle@arm.com> On Mon, Aug 17, 2026 at 12:16:10PM +0100, Christian Loehle wrote: > Syscall User Dispatch is unavailable on architectures without generic > syscall entry. Such architectures return -EINVAL for otherwise valid SUD > prctl requests, causing sud_test to report failures. > > This also prevents bad_prctl_param from providing useful coverage. The > unsupported stub returns EINVAL before argument validation, so valid > operations fail and requests expected to fail with EFAULT return EINVAL. > > Probe SUD with a valid disabled configuration at the start of each test > and skip when the kernel returns EINVAL. Preserve failures for unexpected > errors and continue to run the full test on supported kernels. > I suppose we should at least be testing for the EINVAL when not supported, so this makes sense vs skipping the entire suite. > Fixes: 179ef035992e ("selftests: Add kselftest for syscall user dispatch") > Signed-off-by: Christian Loehle Reviewed-by: Gregory Price (Meta)