From: Stafford Horne <shorne@gmail.com>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: Jonas Bonn <jonas@southpole.se>,
kernel-janitors@vger.kernel.org,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
linux-openrisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] openrisc: drop unneeded semicolon
Date: Sat, 15 Aug 2026 07:16:21 +0100 [thread overview]
Message-ID: <aoAENVPTu7xW8LL5@antec> (raw)
In-Reply-To: <20260801191002.1383835-4-Julia.Lawall@inria.fr>
On Sat, Aug 01, 2026 at 09:09:50PM +0200, Julia Lawall wrote:
> When a function-like macro expands to an expression, that expression
> doesn't need a semicolon after it. All uses have been verified to
> have their own semicolons.
>
> This was found using the following Coccinelle semantic patch:
>
> @r@
> identifier i : script:ocaml() { String.lowercase_ascii i = i };
> expression e;
> @@
>
> *#define i(...) e;
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Thank you, this looks fine to me. I have queued it, sorry for delay I have been
away.
> ---
> arch/openrisc/mm/tlb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/openrisc/mm/tlb.c b/arch/openrisc/mm/tlb.c
> index 3115f2e4f..2ee00bf30 100644
> --- a/arch/openrisc/mm/tlb.c
> +++ b/arch/openrisc/mm/tlb.c
> @@ -74,11 +74,11 @@ void local_flush_tlb_all(void)
>
> #define flush_dtlb_page_eir(addr) mtspr(SPR_DTLBEIR, addr)
> #define flush_dtlb_page_no_eir(addr) \
> - mtspr_off(SPR_DTLBMR_BASE(0), DTLB_OFFSET(addr), 0);
> + mtspr_off(SPR_DTLBMR_BASE(0), DTLB_OFFSET(addr), 0)
>
> #define flush_itlb_page_eir(addr) mtspr(SPR_ITLBEIR, addr)
> #define flush_itlb_page_no_eir(addr) \
> - mtspr_off(SPR_ITLBMR_BASE(0), ITLB_OFFSET(addr), 0);
> + mtspr_off(SPR_ITLBMR_BASE(0), ITLB_OFFSET(addr), 0)
>
> void local_flush_tlb_page(struct vm_area_struct *vma, unsigned long addr)
> {
>
prev parent reply other threads:[~2026-08-15 6:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 19:09 Julia Lawall
2026-08-15 6:16 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoAENVPTu7xW8LL5@antec \
--to=shorne@gmail.com \
--cc=Julia.Lawall@inria.fr \
--cc=jonas@southpole.se \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®