From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B1D131A572 for ; Sat, 15 Aug 2026 17:09:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786813761; cv=none; b=OFK15o/dBstb9llYlUM5vmHf5dmsjCdhLxhVdpAw20Vnn5npAr0/zeTEL8SoXfzoue/L2cZp1Lo2HIbJeeTSqpQL5idL9EC6qYxvJ3YqQb+YccF30gxKG1QQfUz00KfDB/30OiAMku/evE7SAvAwy8doJsPF1QpMnEAm4JR3/PA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786813761; c=relaxed/simple; bh=EMOpJ1B+eGp9GhFVzPZ9FXXobnrl//5Du0SDBSY14Zc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=hcsUUAN2zKG0Ms4w2oi0qQLWF98K5Oafu5bVQDv2ffDVj/ghyjyGEz5ONSEhnqq8LRyIK66Sd2MZwMZAPlkhJhAt+tx5k2Mk3u0Mlp8EkuAdxfhG5CmRD+ZhlLsISiGjG8zg4x3ItQMglNGvWixRScOyWJb0R1F2PXRfGR2I1lY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com; spf=pass smtp.mailfrom=googlemail.com; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b=f+t6STbq; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=googlemail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="f+t6STbq" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-c207cb16cf5so280183766b.1 for ; Sat, 15 Aug 2026 10:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20251104; t=1786813758; x=1787418558; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1uJ8iLpdEmJENtbZVZxGqhSaVmBWwKh+XpuL1dopqPE=; b=f+t6STbqHKcS5bO0G0r6QnqdA35pGgu6fs69WYPVPC/UAxRw6FOHMq5oAeoHTuJf2i RVtQVRupe6P9nHDooELRYVXftgOHAXVHOSSIQE/wGw3cTaJU5nGryaXjhoBIWjbfd7oJ QEhOt9eeFSnRaUlWW6GbWkkR+f9xVmOqCRYC53hSysnSvst7qR7h+fP1ooTDYAVfLnGt +lU45ICETcMzXTYnxhwSNEgtlD2ANfYwmhmKFpUQJUfakCaVJvjnKAOZ1YNWAbuQrLKY zKgWJxJeFq06l/8QRo+hcA2q1mm8JXmFAByJZfBxdhQgvsBjI3wvc6oEUaof/nu12dc6 rmOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786813758; x=1787418558; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1uJ8iLpdEmJENtbZVZxGqhSaVmBWwKh+XpuL1dopqPE=; b=NN4svDM7s+QhVWTW5XwFDdBBpBBOVwdy3rvW/m5hYLD98tMZ+ALROAJdMYyY6PtlPh GFJf7zLmThDZ2zgVqxLYbalRuJS3uTOoTxv52H3s472E2gam2sYSAxeBdS5Iuxg6G3Xo RxeBfx9MV1pspRWsJk4h4W4lMI0Snpplz0llhmr9DLZRIy5IKhvvENgLvbP5flTJOZG0 Me8aqQdBXOyUMUX5RwSaqkcLZ2fAIMaM/w6bkP3Z7c1xPc1JlB9++5D+t+4VIdiHFfnM PRs6Huvzgaiob/FRTdiDmSfaTbewqgyQehy+9HUgfnlD5HT2BJNy9U+kqrnxzOBKg1A9 VCUA== X-Forwarded-Encrypted: i=1; AHgh+RpTwIn0U8u/l0XxP4qcmFnvkQZ+P7FGRqe/jQUB3+1G9YGApf+ni4i1cxjEaSt/kPu7Izhu1QLsMK466gM=@vger.kernel.org X-Gm-Message-State: AOJu0YyyN9h2pRBxTj+AItwL7dePZgRH4IoGRAl6rU3c08S6RUCmErF7 gEYuZjxBYQsDizruUO79nNIYTGHYBolriX4grnoXi+0SzGPGJFf7WyOJ X-Gm-Gg: AR+sD13T7GU8HzXcf2zJ+wVufx2XubWxn3YGDN71FYyD0ZlBVpKKWjCUsGC6jAL4QST l7URKoyBZtSgk69qkz++YPqwsI8gkZLjssFxGbWqnbZJHvYUtXwjDOhrnbV/DhpTPvzEXGgVIBY uSuEHmID5R6I5CV7Tr01t/zlwt4rtKSejr5et82jmE767pCA+eOw6am11wcvyK3WecZ3opaZsts bYWVwDMEDwaRP3ollLt8bAs+ivdExVOG+RpzNIAiLEVSbE0Dm3zss5Gi32m7LWycDcFq7t7tGw6 qkJJuCjbDJfkjSHH4wIUnC88vLFZvJfM/uZg81lH0/W2lr5Uud0jlWy5clWuuLUa2UqVHST9f0U V9OldCVpKOxKsNohkKMpeqUsYWMWapnSO/CPMDP48G5ZOOyKclLuLRy7sH4IASQAh4wTaC6AOWe yZk+DHnqtnZCpoHLgN9T9uVzTHpo+YApi2zTgEobCKJt39i/Ly3ytGQ52yzsFW1sMqmepBHYOOF wG1Jpbdmo/8Lj9pZn8= X-Received: by 2002:a17:907:a687:b0:c1f:983f:d8a with SMTP id a640c23a62f3a-c212aa5fbedmr689896466b.24.1786813758191; Sat, 15 Aug 2026 10:09:18 -0700 (PDT) Received: from david.gall (k10193.upc-k.chello.nl. [62.108.10.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c21234c4893sm243662466b.20.2026.08.15.10.09.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2026 10:09:17 -0700 (PDT) Date: Sat, 15 Aug 2026 19:09:14 +0200 From: "David C.C.M. Gall" To: Srujana Challa , Bharat Bhushan , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org Subject: [PATCH] crypto: octeontx - use crypto_memneq() to check HMAC Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline validate_hmac_cipher_null() compares the computed and received HMAC with memcmp(), which short-circuits on the first differing byte and leaks tag-match length via timing. Use crypto_memneq() instead. Because for cipher_null the validated payload is un-encrypted, this valid prefix leak allows for authenticated message forgery. Assisted-by: gregkh_clanker_t1000 Signed-off-by: David C.C.M. Gall --- drivers/crypto/marvell/octeontx/otx_cptvf_algs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/marvell/octeontx/otx_cptvf_algs.c b/drivers/crypto/marvell/octeontx/otx_cptvf_algs.c index 096be42e9d03..70befbdd442b 100644 --- a/drivers/crypto/marvell/octeontx/otx_cptvf_algs.c +++ b/drivers/crypto/marvell/octeontx/otx_cptvf_algs.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -105,9 +106,9 @@ static inline int validate_hmac_cipher_null(struct otx_cpt_req_info *cpt_req) req = container_of(cpt_req->areq, struct aead_request, base); tfm = crypto_aead_reqtfm(req); rctx = aead_request_ctx_dma(req); - if (memcmp(rctx->fctx.hmac.s.hmac_calc, - rctx->fctx.hmac.s.hmac_recv, - crypto_aead_authsize(tfm)) != 0) + if (crypto_memneq(rctx->fctx.hmac.s.hmac_calc, + rctx->fctx.hmac.s.hmac_recv, + crypto_aead_authsize(tfm))) return -EBADMSG; return 0; -- 2.43.0