From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB7B422689C for ; Sun, 16 Aug 2026 03:06:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786849573; cv=none; b=V9GaNAewDvNrndIN/iNxE6DjKJNhWhwPEOxh0lMQdt/6gCS0lg6WQ9OYjhL06AlfnWh7ZyU2YaHJMgQQU16DiViJjqkDa3o1cghrrR6VEUx3HD209vg7IhSw9jzCvO8T5F9wJDnLORV2EyAsROVHq2BB/Ii2w6v9cv2xwN/HMOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786849573; c=relaxed/simple; bh=dtWtM3W+W2Onggp7jWzn4o+vgwbhfXrlgaQ5ekYRTHk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WhGJ39/unuJ8IxIlNjU/0YIXuctvzzm7z5/1MbdeF91yrk26+AvW1OnckMMUczvaEtQvf8FcSi7P3J2BdstqZ6Y7SHNDReIU6Bsrp+evRe9EcgsJqBGFN0AUeLI0k4YcKyosLIkTfzuc3VAn/3rx58zw/mMxiHIrf0Arg+HgMVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=drXHTBTH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="drXHTBTH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B7B71F000E9; Sun, 16 Aug 2026 03:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786849572; bh=060ShLWrJV7mTpS31Y0pwec3LCvS1kdkKYa9G2GHM30=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=drXHTBTHV/2f1sV181figccMGL3UQmT/WeiA2AOYIxuUmlZnegMdgCQhXmY+WdW/d F5jlytu+eJzOtvCMHoybH2dTnW7f0BxmmGz2p4XOf87NoDxohcfsv7pS5YAhKpNi+F vfzBJSifVXnKp9Kbnxzr1A1PUWbwKF+dUbgt2JfLXLTY8S7DH5exAi1Z79FLtWwtA2 GegoagAmILeIkw0DxXcsl7B5geXcOosT/jk6amgROLD8YfayGe76Df34V6TjlqvgW/ xMZAWYZvZactxnxTYo+2l9GUDv+3EAsTPx0o4D73eBgAFCyFtTtWQAGmCaNw5HTQJ4 fcBIBaUwbm4Pg== Date: Sun, 16 Aug 2026 11:06:05 +0800 From: Gao Xiang To: Bingwu Zhang Cc: Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, Bingwu Zhang Subject: Re: [PATCH] erofs: remove erofs_dev_context->rwsem Message-ID: Mail-Followup-To: Bingwu Zhang , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, Bingwu Zhang References: <20260816-erofs-remove-rwsem-v1-1-78b60b855fa6@astrafall.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260816-erofs-remove-rwsem-v1-1-78b60b855fa6@astrafall.org> Hi Bingwu, On Sun, Aug 16, 2026 at 10:00:12AM +0800, Bingwu Zhang wrote: > From: Bingwu Zhang > > devs->tree is only modified in initialization and > destruction code paths and will never be concurrent > with data reading. Thus there is no need to guard > idr_alloc/idr_find with a rwsem. Thanks for the patch. In principle, yes, but it's also no problem to leave it as-is in case some use cases later need adjust the device_info of a dev for example at runtime. Or if it causes any noticeable performance penalty, that will be one reason to drop it now. Thanks, Gao Xiang > > Signed-off-by: Bingwu Zhang