From: Matthew Wilcox <willy@infradead.org>
To: David Sterba <dsterba@suse.cz>
Cc: Yichong Chen <chenyichong@uniontech.com>,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Boris Burkov <boris@bur.io>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] btrfs: retry verity reads for not-uptodate Merkle folios
Date: Mon, 17 Aug 2026 04:07:29 +0100 [thread overview]
Message-ID: <aoJ68S-_9W-14lsA@casper.infradead.org> (raw)
In-Reply-To: <20260723031444.GP10684@twin.jikos.cz>
On Thu, Jul 23, 2026 at 05:14:44AM +0200, David Sterba wrote:
> With that new label the main loop becomes a less readable, previously
> there was just again and out. From a distance the loop likes a big while
> from again: to read_key_bytes, so this may be a good followup cleanup
> (if the end result is reasonable).
I think a better followup patch would be to use read_cache_folio()
(or similar) rather then duplicating that logic in btrfs ...
next prev parent reply other threads:[~2026-08-17 3:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 2:54 Yichong Chen
2026-07-23 3:14 ` David Sterba
2026-08-17 3:07 ` Matthew Wilcox [this message]
2026-07-23 3:15 ` David Sterba
2026-08-17 3:05 ` Matthew Wilcox
2026-08-17 15:56 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoJ68S-_9W-14lsA@casper.infradead.org \
--to=willy@infradead.org \
--cc=boris@bur.io \
--cc=chenyichong@uniontech.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®