From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09CB54B04B6 for ; Mon, 17 Aug 2026 07:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786952938; cv=none; b=Fxg2Sfg014kGQHUiED7cCJXvJEdpFohYdXnr/8NsA1b4hAhbSgI71LfYnn5xei7NLtoWGz6gIlWV91VlaB7FzTUBqLc2dtdqfPnwpxyv2eOM33tO9vspkhLm/QPv0sAc8qIf9m3AJQNK3jRFRGsIShVO+khBCKDUJPyYbWDCJpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786952938; c=relaxed/simple; bh=tr7yZ+KWlFpSeF5lvPC4+cwv8ACoPopjCz9pCqOq4Rg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YPhOpAZ4aQbRpNcdGR0U7T/Vv8cwBHDbrrkgPob4Jrhwq5O3EKvuZiCyk2/vq0d7mHXPNRN6wwHCD+UqSVTOwJFRTXgeUhBw8YPIBTjr9y2n3+9GbGVUmZnBuozOlMqzXJUDnZ2YeGIahg/tMiBCtpwY9akm1O571h8UqTgopUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HBdTldUC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HBdTldUC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 136B41F000E9; Mon, 17 Aug 2026 07:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786952936; bh=viBoymsg9xDAdiX1A6XjLrBvzNgBn+v6VRW83WfvxCQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=HBdTldUCWwl0PpHhUc3ZpuiclKN1kld8sUrBNobMnvvAzb0zx4Y9GZ7AQnLPTdQZM kBfuMQFioU8l2sCHC8LkwqccFvraiNiYsL0scmvLpDXa7Zz/yw7dhzUrJYt4keENQI EdqW38lAKQRXm+iLuJfa46eMcWVFy8ggY4Nld3Pm/G30LshrQBrr3/eszmP+wKRTgT mUpb67U2OCnZs+9WErG3r6ysLAAuvpxNloEO/0Nt1JXYKPHv1rn9erVOyStPd7cW76 uQZq/b3nhiLxp/tQwldT1NbiyA44IeRY/F7oDiwBbwAEMVg+R8lqDgVW5Um7Bp6aqC k+AlNRL4W5zAg== Date: Mon, 17 Aug 2026 15:48:49 +0800 From: Gao Xiang To: Geert Uytterhoeven Cc: Gao Xiang , Linus Torvalds , linux-erofs@lists.ozlabs.org, LKML , SJ Park , Guenter Roeck Subject: Re: [PATCH] erofs: fix EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS on some UP platforms Message-ID: Mail-Followup-To: Geert Uytterhoeven , Gao Xiang , Linus Torvalds , linux-erofs@lists.ozlabs.org, LKML , SJ Park , Guenter Roeck References: <20260812131144.30802-1-xiang@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Hi Geert, On Mon, Aug 17, 2026 at 09:32:51AM +0200, Geert Uytterhoeven wrote: > Hi Gao, > .. > > Thanks for your patch, which is now commit a64d500b0078e16e ("erofs: fix > EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS on some UP platforms") in v7.2. > > > --- a/fs/erofs/Kconfig > > +++ b/fs/erofs/Kconfig > > @@ -134,7 +134,8 @@ config EROFS_FS_ZIP_LZMA > > config EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS > > int "EROFS LZMA default maximum decompression streams" > > depends on EROFS_FS_ZIP_LZMA > > - range 1 NR_CPUS > > + range 1 NR_CPUS if SMP > > + range 1 1 if !SMP > > default 16 > > I have just discovered another oddity: when you have less than 16 > CPUS (including SMP=n), this default value is invalid, and "make > savedefconfig" will always write a line like > > CONFIG_EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS=1 > > to the defconfig file, even if that is the default suggested value. > > Needlessly polluting the defconfig files could be fixed using: > > - default 16 > + default 16 if SMP && NR_CPUS >= 16 > + default NR_CPUS if SMP I guess `default NR_CPUS if SMP && NR_CPUS < 16` would be better, I'm not sure since I'm not handy in Kconfig stuffs. > + default 1 if !SMP > > Thoughts? In principle, that would be better, but may I ask if there is some severe consequences out of one extra line of CONFIG_EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS=1? Since it has been fixed for many times, I hope if it could be improved later if no severe impacts, sigh.. Thanks, Gao Xiang > > > help > > By default EROFS allocates one LZMA decompression stream per CPU. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >