From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26E624B04B6 for ; Mon, 17 Aug 2026 07:49:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786952989; cv=none; b=Y+6taUBeQK2eeQq9HqXtcXJTdE7fFTv96cMmGwj5ky7SBv7ql+nBTdDqqjwCVDpcnDpaRyk1ZXJ0xFXbKMZf26jSkYqVVIhlvmNgKQs1+b+7d5BkzIjYJZOUMmNmdTJ7tQIRO3mvK5gK9Ni5MlNgmHnSShucAJe4yUvqcXeZjbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786952989; c=relaxed/simple; bh=veDe8wc34sDAeRMAIFmAkOOLjF4rUal2oKNggxOEmcI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hnec5pw1J/o9Mh4ysnl298pmuE5hP1MxH9bvf7Qj/Yw2gJVuCPYPn94kPnPg3ObgKs/WcvSww/RGwurvNkvOBmFhogrguxfjQou0zkYjUOL5iiNIDJVEf7fooMejs43buRWNg5ghR49xrzb4uv5e72iZ1kc/IPpnYpEWWj0OH5U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T2svtO9Q; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T2svtO9Q" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4980fe6b3beso26954985e9.0 for ; Mon, 17 Aug 2026 00:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786952986; x=1787557786; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=veDe8wc34sDAeRMAIFmAkOOLjF4rUal2oKNggxOEmcI=; b=T2svtO9QBnK8/077r0wNISGXVkb1nNQ8eut16oc75ZNnBT7Qyqu7L7Edhs1ezufHRP NDZPAYKwhLCUymf+3/abt+0Wx7q5burRjXD1tW8KHINI/RYTtG4qVgT78YSNr5BXWLjA wH8a2eo4ipZ1jX0MDCxiToKpo5r1cwuxr3NoRweF3+dTBW0MNVl+dGRVhUCQZ5/2H0v2 N/7/9M/1fwdkrXlqKyEprOcgNAr03gMwQTalABXwpRfEhdyp0Jcdax6RDOlMGTmenPUX 0bgejeGiEvQAZHbOO6ASukshUtZ3Q1AmKDDuPqZ/uBVAqBvU6WrUBpcoIxrWpmrRu9iZ ep+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786952986; x=1787557786; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=veDe8wc34sDAeRMAIFmAkOOLjF4rUal2oKNggxOEmcI=; b=Xxsx+JhDj78ebmvdX+TYo2ZIRpuKBrCqARlRPZbPgJkshwx6FLMjftDC9jgh+CjJKy fD/tIgVsuReinHj0TQ1LQjwbenSN/LNau7GI5iPF+OpCcr5JzQiqoRfpBuVBmkPvNIm2 A65Y3ppPSwvOb20rDC3qYG/rvdW2ReGIrkSg6sGzEuQAGQeZX3EHju2a6NX11S2OZHuU iou7a9XRLdoo2lrmVdjtZ7Q6jnUl0cbjmbRP3V8dFnJNttgjMglngUEHosDRjyoKn+ht dU0r/zp1F2MvJCHJKDc3l1dnF8cLnZ1TKk50gtgEUMdcR60XhmJzP8QLsgsrf8tnVAOG W9ZQ== X-Forwarded-Encrypted: i=1; AHgh+Ros3kNu9CO8EknsDUVllfAteOV+dowuaIkkkotIZI8ZEf1bCNn61isW+knZeOm3lcUz8eXacWCVgvAcmJ4=@vger.kernel.org X-Gm-Message-State: AOJu0YxyZ4pYN82+WdAk52mZbdZ9EODI17I1fi996z7s2xJHZPOX0MZT PV4xS93RlpUsQXb3TmfKLBpuG57UhyNhsT0j3JE03ZaSZxNenqlpTBDk X-Gm-Gg: AR+sD13nNXM9pHekXQWpdfsMeau0jUySrsM+C8C/4tfHtj5PZjkR5NvCxEsWEg9hNOF uLt/h9rPUCyk1tKBJoY2tNB/y1nW8/DEYr7McnASzCWoftvuYgdt1eo4CPegB13A0cU3atgus3r OlmCCL6fYUKTdYeg2OW6BQdY5qoV0ldnuKmuXUmN5CAlbCbIJ9b1TBFQD05lmBuPFCaLKdsjHIV acLY/iIfvfHuwBN1NPDEVJdQ1V2iKi3vTzmCE4OEFBwHGMBC8yw7XdddT7y7pP4e8/ukxHyEqql IO31WQ86dqeqitr37djd1zqpOLrjGF+wIGrb65tnbx6ezboqTKnngGIx+NR640t41BTFoMA5pEI YejfB6+eialcvplsfXZFJ8gSfitexcKe2zAZiLubDcNoiXEb7aKiHHyDAAyF+UemVH4rDmk6Asl 1xV8H5fiuPnQ7iXWhzmnbpT4i77l34qgB+wD28Cv7Tf9M5bVVIUD0v0BZ8JQ== X-Received: by 2002:a05:600c:ce:b0:499:7f37:cb74 with SMTP id 5b1f17b1804b1-499821546afmr396548255e9.1.1786952986230; Mon, 17 Aug 2026 00:49:46 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:9cf4:43df:e612:817b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a3b896sm1663047f8f.16.2026.08.17.00.49.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 00:49:45 -0700 (PDT) Date: Mon, 17 Aug 2026 10:49:41 +0300 From: Dan Carpenter To: Ivy Lopez Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: cast EEPROM_DEFAULT_DIFF to s8 Message-ID: References: <20260815191030.24989-1-skunkolee@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260815191030.24989-1-skunkolee@gmail.com> On Sat, Aug 15, 2026 at 01:10:30PM -0600, Ivy Lopez wrote: > EEPROM_DEFAULT_DIFF is defined as the bare integer literal 0xFE > (254) but is only ever assigned into s8 (signed char) fields used > to store signed TX power calibration offsets. The implicit > truncation to -2 is intentional. Just change it to: #define EEPROM_DEFAULT_DIFF -2 regards, dan carpenter