From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11FF23FAE1B for ; Mon, 17 Aug 2026 12:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786969390; cv=none; b=YXnROTZNsk4cU9QGkOElI8HFFnZ7R0RLLEB6f36coxOF0SD/T8i8ERig/0f5uazceAClgKFg2gQm3DiJWDpzw9NUz3p1JnJT3DQhXKHla2xFM5OdzjyKgM7Kp5r9O4gNLRDHRX/C+61PIrPYFt3cSS4Djox2JI2huiKQ35OKXjo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786969390; c=relaxed/simple; bh=GhCQaq9lFrcY0li39g6EtAR6RlnHQ5/HJNYNHIhMobc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y5hFFkWq2sieF3qZnL+gEwpXP/P9QFVecT7p+mOeZMeDKsl8gSTewR+gelbL+rLAJuFlrEIFM02KtmWjHaXf/TwlygaCG0JVJ8ofh2i8wX0cLVul86UsckB/sjDBbiWfabJMrO+ZQF7rhLHm3TH5PrsXSGHBbdsLN6LvWvMNS+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p2HWwyJ5; arc=none smtp.client-ip=209.85.161.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p2HWwyJ5" Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-6acc88b9c5fso1683630eaf.2 for ; Mon, 17 Aug 2026 05:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786969388; x=1787574188; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=SLnvYTTSPUm+0I3FjcHEC52RZJltLhF86g6meW9r0Ig=; b=p2HWwyJ59xU64Rqb/Fr/DjQh0EstXvtQ0hqOYmzg6rzAP1d+TCko3Q4/e5YC1owUfQ Vi9qpE6Poo8sxqq52coyYSxH/p+FcHz1AxRmc4XejUCYtc1oUCe4cGVW4fDUZW5aDPrE O0aqd/57PqHwoY7BSuQzcXhPPN7vddj4cdmpWs9GbDVxUhmppCNFUgCMaiWweT768SAU RGEHQBidwjAjigtaPnri8g67tEgiNaevo63jYqO/PgK3v3Ia3THCO/mqSwq5nGGl1MVT 8Aa42Gcr4kv/QwlVY3b1sP0SXgkv3Q9hdVDQiaqbfMbF7XAla6vKgfh4NcG1Vh3N4O3v 28OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786969388; x=1787574188; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SLnvYTTSPUm+0I3FjcHEC52RZJltLhF86g6meW9r0Ig=; b=dklM2iclEshMsqpaclYawz3dn5LSEjWB2VbcPfKnMavqD+MkBMlBrQssyDMqeoInmq UBDTUfxbgIEKHHNJ8mcSeu+yLOXuifCduI7wVtQWigZmyV0g0JASdYL+b2ON+LekLyFe RBYJ9MB+3q3fa4vTw292zBGR3tqBgybZJtMxup7OHgTkHrh7wQNtpl5NGe7bEtgiPf7B cHy8ZVzW7akSIagd+9ZgNhxVITtNmSllwmX13ynmK0NEnX1pB7Ve7z4Z05qhbMQH7InW eGGE7sBDPbMGp51VeMs+fqA/Z/255Rm4MqyqNs1c+aR3tQP4KLlpW1g9rQXzslQzTU26 zesw== X-Gm-Message-State: AOJu0YwQYEfGm7IDxFFzyE4VkUll9Yo1HLnOFMOp8QCAMt5TnXhnzQlR Vy1BI4+xXfHd37ooTIH3Nvrc5/d+TyIOlzcgSWcgLUMpS2Qsy3qJkqWR X-Gm-Gg: AR+sD11zxeQC10yLzvUoLwrYjFmFnAqBB25bAkQoKzkYzydRH9Jpy0zkiOdBl3vN18g e6OhDXd0LRR819MUrcGWfIfwcS3MpYB+laxPov4X03oAtC+cSkw1lPS0hRjoXxIo/yNgpQgQK9p gmV5FW/LwhiCf464X4+ztMWsyMr5kbXYcYZBHmRqsqderCW4iorcBAn/7lTLB5OXogyNkFeDmmN 8gD9E/1Ln/4k2gUk3AE5dUNgELDmxcHndYRRldTStAVP98v4M8I7Lf86eFWI8Zw6y2UqRzsLagF LoGPz3ElJXqFEHXxGqfiJVYu9o0g/EN0EzfDwmVjSwQavksZcp4sluNGpL+GCyr5I72gUqMIBG8 t4JJMXQw1eA+K6xOtlrRtuI8lnfCwSKKRhAUA+rU99Mkh9GPHct9lICXwaDgYBuVLh1sVUI8+gt utWBn5RO2kkOdhMnaFyWU+mvhrhbVx+ug6a707P3u9VcqQDgmVoE1C9zmxCduhDgfP+bWetx2ML Ssh X-Received: by 2002:a05:6820:f021:b0:6b0:3b29:2301 with SMTP id 006d021491bc7-6b0d5dc9c2fmr19175325eaf.0.1786969387659; Mon, 17 Aug 2026 05:23:07 -0700 (PDT) Received: from user ([2405:201:c052:b00b:996d:a87e:1e18:16b5]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f41bf2c916sm1365607a34.9.2026.08.17.05.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 05:23:07 -0700 (PDT) Date: Mon, 17 Aug 2026 17:52:44 +0530 From: Yalagada Pavan Kumar To: syzbot Cc: linux-kernel@vger.kernel.org, malathi.a2000@gmail.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [intel-wired-lan?] UBSAN: shift-out-of-bounds in e100_eeprom_load Message-ID: References: <20260810043438.132082-1-malathi.a2000@gmail.com> <6a795b4a.01d0871a.3a0d52.00a0.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a795b4a.01d0871a.3a0d52.00a0.GAE@google.com> #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c index 464dc2d6cdb5..5165f1d3c98f 100644 --- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c @@ -746,10 +746,12 @@ static __le16 e100_eeprom_read(struct nic *nic, u16 *addr_len, u16 addr) if (!(ctrl & eedo) && i > 16) { u16 len = i - 16; - if (len > *addr_len) + if (len > *addr_len) { *addr_len = 0; - else - *addr_len -= len; + break; + } + + *addr_len -= len; i = 17; } @@ -771,14 +773,14 @@ static int e100_eeprom_load(struct nic *nic) /* Try reading with an 8-bit addr len to discover actual addr len */ e100_eeprom_read(nic, &addr_len, 0); - if (!addr_len || addr_len >= 16) { + if (!addr_len || addr_len > 8) { netif_err(nic, probe, nic->netdev, "Invalid EEPROM address length %u\n", addr_len); return -EIO; } - nic->eeprom_wc = 1 << addr_len; + nic->eeprom_wc = (u16)BIT(addr_len); for (addr = 0; addr < nic->eeprom_wc; addr++) { nic->eeprom[addr] = e100_eeprom_read(nic, &addr_len, addr); @@ -805,14 +807,14 @@ static int e100_eeprom_save(struct nic *nic, u16 start, u16 count) /* Try reading with an 8-bit addr len to discover actual addr len */ e100_eeprom_read(nic, &addr_len, 0); - if (!addr_len || addr_len >= 16) { + if (!addr_len || addr_len > 8) { netif_err(nic, probe, nic->netdev, "Invalid EEPROM address length %u\n", addr_len); return -EIO; } - nic->eeprom_wc = 1 << addr_len; + nic->eeprom_wc = (u16)BIT(addr_len); if (start + count >= nic->eeprom_wc) return -EINVAL; -- 2.43.0