From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 583DF3C37A3 for ; Mon, 17 Aug 2026 08:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786955603; cv=none; b=Z4xFfSMFEWPZU1kQYmATHsZ9ubTDZh4swwH91OLNw8A3rGNUDnKYj0uPsfHS6vG31TO6Ah+HHHxWgc7lmb2JYGfrfrGrObnjqhcOw2Qnqs6Q/anbCo+6tlGAyRr2gkpJ6HqMtCb3UycZyxjKPzc7I8L4ov8KTr5pUqxLrZZDyEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786955603; c=relaxed/simple; bh=OpnS7/jt28x+9isME6FSvisYgJTeYuMNDqPvn4Qdx40=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SOgWm5GL/39mCHRnXDboXAmh9NFpfEwUQbSJcq1iSS7EnX5pErziHPbtY1YPfHFPf6MH7JJKe1+JrvSj/MAO9KOcC9G+ee89SB2galy41qywn53twP2nVsErqBzrSkttvY93GTGo9H+t915daME4Of53Myd9Nogx9aPqh0ApXRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=G7kNEJeV; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="G7kNEJeV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1786955601; x=1818491601; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=OpnS7/jt28x+9isME6FSvisYgJTeYuMNDqPvn4Qdx40=; b=G7kNEJeVDpw2g01rFXQOP60uOI8lWBKQtMeXKfPU2W4nGPmwfLHHW74Y nPOQ0RH2k+iz+WJBfRb8hrtxFrE5qZeF5JZjGGGJeZF/0vguHzlt+AURA 7q2UrqVwMU0fkCX3DOWhhRq0PFeHNK3eHvgnzbKqhm1elCasDp6WGRK+W 068KOm00x09fb6CWYNgBpWPB1lHnvoupXu06rnROP6R3K4GTNLl9JnhOb a+9/flLT/3FFQ4ILqEY/V6+mcKacP49l54BwNo1HN4mwNieS6hOeOSHcq vGLSWi8wlykeC02mjWxBjRCNwj1NrHFl/sN1IuN8VD3E/el2hCryu3jtL A==; X-CSE-ConnectionGUID: 2dmfCHtYTdeuCtg7maZYkg== X-CSE-MsgGUID: OpyUdcX1SlSAHBEbxGHmew== X-IronPort-AV: E=McAfee;i="6800,10657,11877"; a="87445447" X-IronPort-AV: E=Sophos;i="6.25,228,1779174000"; d="scan'208";a="87445447" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2026 01:33:21 -0700 X-CSE-ConnectionGUID: qUZvfxs8RvaakfAXxHBBSA== X-CSE-MsgGUID: 7/T5GzLUT1OQO9KLUDaxaA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,228,1779174000"; d="scan'208";a="261579309" Received: from klitkey1-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.67]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2026 01:33:19 -0700 Date: Mon, 17 Aug 2026 11:33:17 +0300 From: Andy Shevchenko To: Ariel Yu Cc: apw@canonical.com, joe@perches.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] checkpatch: recognize standard SI unit prefixes and symbols Message-ID: References: <010601a000f8aa59-fa0e91fe-a069-4aaf-baa2-79737d25251a-000000@ap-northeast-1.amazonses.com> <010601a006991191-5959d04d-7d19-4128-b488-e51f6f97330e-000000@ap-northeast-1.amazonses.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <010601a006991191-5959d04d-7d19-4128-b488-e51f6f97330e-000000@ap-northeast-1.amazonses.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sat, Aug 15, 2026 at 06:04:49PM +0000, Ariel Yu wrote: > checkpatch flags identifiers containing valid SI units as CamelCase. > > Expand the SI unit ignore patterns to recognize standard Système > International d'unités prefixes (u, m, k, M, G) and unit symbols > (V, A, Hz, Ohm, C, K, s, W, etc.): > > - Allow mixed-case suffixes after the [a-z][A-Z] SI unit core, so > derived units like _uV_per_C or _mV_per_K are no longer flagged. > - Allow mixed-case prefixes in both the two-char and three-char SI > patterns, so identifiers like clock_FREQ_kHz are recognized. > - Add Ohm (with all standard prefixes: uOhm, mOhm, kOhm, MOhm, GOhm) > to the three-char SI unit list. > - Allow mixed-case suffixes after three-char SI units as well. Maybe this way, or maybe some leveled one (first check the multiplier, then validate the SI unit). Whatever, I am okay with this approach. Acked-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko