From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAA333F9A11 for ; Mon, 17 Aug 2026 11:31:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786966267; cv=none; b=cjOA7IF4naesMLVuUdvp5UFARshRnUG1b1bZvgUzsw4lDVeedAjJ4S5FkFHBB4qakvDxYm1/icX76a2RPyfQkxQn788DSUxvN4GPldGyc7r0gOo4k1ZzKwpt4BE5s5D0jS5dwAIj0nY5EjUw0j7ZY5bCDLHcmHqyK/O1qfi7bpA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786966267; c=relaxed/simple; bh=AR68dtwQRw9nHgNspN3l8wJRUkNtm9BeiXIxM2+v8jA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nTAZlZKDiUHjCOeF+3nTUypyKP/AzrX69Wc3ebCIyaWiMt25SbYn1BqPj9/yTzLDR1QigagnfGbwvFH35RTBDU5WFhvN9HSB4GZYQtrt05GAhSm/LTYkX/bfP1XTVgwfL8zuA0i3/BOmEPyT2Q8X8Qwgm1LP7JeTKkNeP7dkrUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=YJUeEmLB; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="YJUeEmLB" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-6acc74fef22so1368951eaf.3 for ; Mon, 17 Aug 2026 04:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1786966263; x=1787571063; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:reply-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=+2zN40Qr1zQYkbtrNrDIo2iBlCzoPv/2VV+3VR92QMU=; b=YJUeEmLBvDfEdeaP0/ADDSWLRFk0WfyJKWoIrxi73JUOuEwfrivfusUt7dEqILXhyQ iuG1nsfmZ1AteG9IFe9t9/ki5OsmsrC2bkLwOZ/hT7mknd94hbOt5JaFEkhnyUp88ugG 6Zlukys6NA1MdNTJP+hESfEJWzWPQuPBVb9182nCYOua0sFRWIimytxzkaJPEvLVG39F CrkavavopOqlVVpIQeR/voeSelNC79BSxWHgMqT7w9z/425jXxotwQZ5fxpOQGjRX5HG lD07i6tGiREwRSmqzzKFA+wh0NByLg1tJp3/cfzZB8amn/b71XM2YpozvtzA85cDMAXC sfPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786966263; x=1787571063; h=in-reply-to:content-disposition:content-type:mime-version :references:reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+2zN40Qr1zQYkbtrNrDIo2iBlCzoPv/2VV+3VR92QMU=; b=rETFUN1bDynENSgavt+NbuMYAcBxj/S5ONUZJy/DXx5ioLIn/Yy8AiZK2QWDCqmixN vB2ijwG0cGJZHqRqbj7shb9r6s8WwtL06T8A5scrwRWaByshIN87hbuoT8bcbZmyFXGG BDlVVyf4tt4LOe6KThQPM6dy4/EklQfLJKSsQ+AtgCaMn18Se94EI66hmfQOMaGqTS7w l9SB7pG94qskfLwwIacPpnsG0ZpvozX/YiBnF/+WsngIYirGJ7xGdiiLHKobtkXUCTHk 9J7iyhwSPXERPfVXViZX6KBNh50bts3f25r+2jFjaSkEw13iiQZN5TuE6C8KW6twbqTL C5fw== X-Forwarded-Encrypted: i=1; AHgh+RoOUeWxueZTKonKtXEJB0WcuMDRF0O2dIEvMFtdLN/P++hA/JZ1nITJXuEkoJ7Olz3O2TZsJqDXsYNTdBs=@vger.kernel.org X-Gm-Message-State: AOJu0YxN6vQghdBzZfzBpB5UOgjsAg6IjA65HBuw3YMTWmUiSL1J3e8R uP5AzrPpb9X8E/e3Dnms0Wqe3PuVd7gsDRd8Sl8bDj4Tnrtd6STN722fvfjkQYG4FHk= X-Gm-Gg: AR+sD10ONQkj8UU0t2e02RcpXtsUbK1HwAIfC85vlJFC02jKqAcyQd94x74wUnIrToi VD3op5Np//hXRMJXK/eCFLpxxaZsJQ887sNGvZJ+TAy6jjLhfbluNfZadF/5Aq3ttAUvdtGsa9l sY2P98BDaCB6EBo5dgibxOzg0YuzaBHdE80zjue09j+5sE9SkwnwfomCReOffOR9pfatiaFMiKh OSk0mmhk4MhaVAYyzzXQvGbd6BqoKtWHMNUkmJlr/FoEiU8GgnB+uWjm4tMNkC1yZYic7P8B/EX wP8WZPdoSdKfoM9NGOpTy6kewgmq3KuEO4qpzioIHIjK//0Ti/WwRyZG+7tHphCY1SvsxBQLnoZ qr73PkLg6xKAfqhpWrtqbV1592dKIcS731K9VQrkOGflrtJdiwNs5hO08/XlOE71sqSlcNKSDV6 FCDacpW9iz/q/lwwXNoJKnNFVwpdWJvdlM0UahFknJK7QNKuaCPoQdybSlHgMqTGXpSq61CGEe1 XHVCs6HjBHtSs3Kc/KKE/rW9IXeZW9LtEp+tV6cQDyk2zx8cDrSPYjJhdDXyqJvLCK/CkibMNez SGrDkHYdVw== X-Received: by 2002:a05:6820:4c11:b0:6ae:3815:ff7d with SMTP id 006d021491bc7-6b0d619b862mr19543254eaf.14.1786966263084; Mon, 17 Aug 2026 04:31:03 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:c4a1:35b4:5ae5:9edc]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-45f22e0d932sm813476fac.16.2026.08.17.04.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 04:31:02 -0700 (PDT) Date: Mon, 17 Aug 2026 06:30:58 -0500 From: Corey Minyard To: phucduc.bui@gmail.com Cc: Rosen Penev , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipmi: si: Handle errors from optional IRQ lookup Message-ID: Reply-To: corey@minyard.net References: <20260817105150.63310-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260817105150.63310-1-phucduc.bui@gmail.com> On Mon, Aug 17, 2026 at 05:51:50PM +0700, phucduc.bui@gmail.com wrote: > From: bui duc phuc > > platform_get_irq_optional() returns a positive IRQ number on success or > a negative error code on failure. For an optional IRQ, -ENXIO indicates > that no optional IRQ is available. Other errors, such as -EPROBE_DEFER > and -EINVAL, should be propagated so that the caller can handle them > appropriately. > > Propagate negative errors other than -ENXIO. The driver works without interrupts, and there may be cases where -EINVAL or -EPROBE_DEFER gets returned due to invalid configuration. This will break those systems. So no. -corey > > Fixes: 39851b7e580a ("ipmi: si: Use platform_get_irq_optional() to retrieve interrupt") > Signed-off-by: bui duc phuc > --- > drivers/char/ipmi/ipmi_si_platform.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c > index bdc481ce1302..04b3e205470f 100644 > --- a/drivers/char/ipmi/ipmi_si_platform.c > +++ b/drivers/char/ipmi/ipmi_si_platform.c > @@ -198,6 +198,8 @@ static int platform_ipmi_probe(struct platform_device *pdev) > io.slave_addr = slave_addr; > > io.irq = platform_get_irq_optional(pdev, 0); > + if (io.irq < 0 && io.irq != -ENXIO) > + return io.irq; > if (io.irq > 0) > io.irq_setup = ipmi_std_irq_setup; > else > -- > 2.43.0 >