From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02BD9409108 for ; Mon, 17 Aug 2026 11:38:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786966683; cv=none; b=TSCzTcUp/LRIeFCoVtFS7rvRZmLSS9mJ0tN9hsGw3PGifuj4vknOeOa2OZN11xDxJZbuNUBAwl1dSf8g26LiN6i3BeImdd0YBhMMJ4snIc4XOxKnsfX+uGg8mH5u9uD2JLJuBI1y7H05KBOGU61Yl5v1cOnbyHROr4fipgsLODs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786966683; c=relaxed/simple; bh=WUzFwifEjNnhDKQKiqR5kHdOMH0k7VkcWt7OKj1/WV8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rKQbRFmJNg6QchFqQV2LO660p6ZoSzL8Hio997LMeA79egySMO5YoYGAJvpPMobzlHHvQ/yXlfVyAA8yxPiR26OaWpO8Aa4XgDqgWuKx9OWWIA6qvXK/nPeyJAZmZmi6oHVErZbIIMFwtY0sZzLe5m7qgN8z+D8Lbt4dpZaBDno= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=JRxAU5f2; arc=none smtp.client-ip=209.85.160.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="JRxAU5f2" Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-45eddb6fdccso517553fac.2 for ; Mon, 17 Aug 2026 04:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1786966680; x=1787571480; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:reply-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=6bqSUVMZelWp4xCieyUGE1YjLn7PE5JpIoA8s2JDI+I=; b=JRxAU5f2d+0L4cPYBu9gz2IOFKcHOxaoBathPQD9HxcolLnvGwGOGS/luG6J0ygDal zsKKRbhKHmPg2v7mdi5ue185qalPbf8HKTBk6eERpbqS73dx8+pBvsc3kPAnAZuvJBnq 6weu60EZ1bZC2n5ymf6GYzAsHC455ueo4YAW9a6PH2ZqlFqLgaeWRTGuwQnFTBCaLT1Q +WGUqj1kblnOCBMRr/uEDoZFXYtd7ZlHHqjEEzpfJhz7gbm8b6bKUrIsg4+qaUC75UUn /C4Blah8MDN7DeSahc8DNb02pr36FyFBkWz6BfC4sXGg05smyDbJ0NtbL2NE1pN9HHPi yZjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786966680; x=1787571480; h=in-reply-to:content-disposition:content-type:mime-version :references:reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6bqSUVMZelWp4xCieyUGE1YjLn7PE5JpIoA8s2JDI+I=; b=RksX5VRhvw2ZoQ9K6mvo4GisQEUvqDVPuAme5P38bP6tOIykhPO8o9fXaPUzZwD6+o jfJxHCZlKpkqAWxq+nMsCobg4meVI4MMdekWJrBIb7oni1GGam+gLgm9QrtSpyyZkfOu 2q8vWduVUe/3qYPvGUV8ugQfR8FfuE0WLoyvpdOmomviZoWZbNtdp0kQNh5cTQJYnksy OPhJleJEvJIUm9TiJYzHIcazRH4mOsjhVKMw8J6zPxLcwnX4CKesjFy2Z0B0EyxhZJZ9 psRWYkU+VEjt5KGabG4VN4t8cLDfDqXVSH74DUay0uo/qRCKU/tD7rTFTK3N5MiADFXb zkiw== X-Forwarded-Encrypted: i=1; AHgh+RrSmJ1M+aHqtj4MLYJfsN6vDYa8diSYAWq9B0SqzaTv+yZEbAEFXcwJzGA1k8eDlruujvo4bbHMuE8SuJw=@vger.kernel.org X-Gm-Message-State: AOJu0YxKpnGdaM/iOwywvHPw0x/5sjviTfd01s05siCF85NbQ1TSVsHd 4VEp8EgffeX+kQmCvo7e3B25uBUmBiX3XfPSRYy/YfREBMYx4YGo+voocLGspgfvfmRWGHG8FnD FD+f1 X-Gm-Gg: AR+sD11bcNbZ70Qma86utShywyONI1lrGa3C2iGIFX/7SbmEbWeeR7+m/0Z5VvE3dXP UV9+2gqeBd3FZQJfK/IXj0SmOP3ph8OQAjtXcT/12V283D+elAd2maud9eNSjwU8D3rTFG5Ove3 mrFUOz50OOEUzKhvg/8QjjIHBInBDyIzm1oUz+lZ0IIBrEHWLoSa3sQ+U8PFdmfX0r+I8O++3hI lnKDdqNCVejCIu5hFPBoMS91mjDtT2ZVnrmwdDSKkFY1LYs04Bsl/f5Zn9rNhXRXgwks6pf6JfM 3CCjQjODx7y9mLqY6Xw1rJNKQbm0aLMrbOIyEGFfqMfYLmpBuqwP3NVPDFsH3QJdXP9AXs1Ohe3 X4LM19pWBuZzquOPce25DidRAwsHe8R84I7SSnKqH/3gcNmrnTShAYzAaxhtpJCJ0ihX897GlGR PgQ8sJxEqofpG/sY3+xOcjKMrSN32RA2Kahq98n6IXyK9TA2hiFyMkjJ+WfS+dFWZl24rrzfExO vpLZOCN+z2ssfCh6+YrsU7oj0n5jYdSq1UWgfK0Q0HbT1I0fe9qwjq8jfFRUGwTLLJUdLxtCWuE rb4hdXz83eK6I858Os8/ X-Received: by 2002:a05:6870:15cb:b0:43b:bb18:affd with SMTP id 586e51a60fabf-45e91d53a4amr20448017fac.8.1786966680499; Mon, 17 Aug 2026 04:38:00 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:c4a1:35b4:5ae5:9edc]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-45f22aea350sm828327fac.7.2026.08.17.04.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 04:37:58 -0700 (PDT) Date: Mon, 17 Aug 2026 06:37:55 -0500 From: Corey Minyard To: phucduc.bui@gmail.com Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] ipmi: bt-bmc: Propagate errors from IRQ configuration Message-ID: Reply-To: corey@minyard.net References: <20260817105041.63224-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260817105041.63224-1-phucduc.bui@gmail.com> On Mon, Aug 17, 2026 at 05:50:38PM +0700, phucduc.bui@gmail.com wrote: > From: bui duc phuc > > Check and propagate the return value of bt_bmc_config_irq() instead of > ignoring errors during probe. > > Signed-off-by: bui duc phuc > --- > drivers/char/ipmi/bt-bmc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c > index a179d4797011..7d3944bda8db 100644 > --- a/drivers/char/ipmi/bt-bmc.c > +++ b/drivers/char/ipmi/bt-bmc.c > @@ -436,7 +436,9 @@ static int bt_bmc_probe(struct platform_device *pdev) > return rc; > } > > - bt_bmc_config_irq(bt_bmc, pdev); > + rc = bt_bmc_config_irq(bt_bmc, pdev); > + if (rc) > + return rc; No, this will break the driver if the interrupt is not available. That function is badly written (it should return the irq and the irq should be set here) but if it encounters an error, it should use the timer. -corey > > if (bt_bmc->irq >= 0) { > dev_info(dev, "Using IRQ %d\n", bt_bmc->irq); > -- > 2.43.0 >