From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76BBD420475 for ; Mon, 17 Aug 2026 13:01:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786971685; cv=none; b=pojr6fgljDZHVYOghfcrBQ9sK2L7PcMbxwXrJtajitng+E0F8KO9yLeIK84XuckRmXJauC5HORkE3wzjYym2pHWp2tYk4XIzPFXTqDmLbNMqUizR0nyNpoQGAeJnhOO41Rawztg1vmQzT4XdBjt+guqJdZ9yrc0rL3D4b9sJ+NI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786971685; c=relaxed/simple; bh=P4wQfrBWUOfgxY5hWzEk8TC9WCkD1gkW4FPK+qCy04Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gbMe2mryJrzsHjXfzSCvw2T6aBihfYrdASbse9KIFMAFQxozou1ds1Xp5ZQJ9aztJY7qo7zAsBOyIDQORBKxdXph4gU+98Xs1lsb6VXj0ZH0PNIrPp/uVsWRrsOrMrV8oQXDs18KthqHZ3hOAsfVXOL3Nv3MR/0FWtG+ppih+Ug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NO8pHZHG; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NO8pHZHG" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38dcbade417so3362734a91.1 for ; Mon, 17 Aug 2026 06:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786971682; x=1787576482; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Pt/tj652A2oLpGz9ZiRJRKyPZerizXNg8HfABWDPXXs=; b=NO8pHZHG6+WpPK/cSZAY1mK+QrLAsxATu60kfIH+Mle0vQuukd4dvHvjc2e6pwui0d dqPDlkjvM46L4dGw2bVWzYI1XuECHZ/CM5tvDwr6qXGXnezlHZEXIibJ44Nsu4zkp+yB w7Gl4McUcvp9hBBZ00rcIP63rdc9TLID5WGYUBSW2j6tQQ6phxDfveYNMjbOCQErfoXf b35d+zhpzGJn4kkLL2n/QPZ0sKPQFroI3dDlWQHCes6kpyVd4G5gVT9IxzUJ4gdBYtnd sHzgayEOaRQtgIHbVuXvi+p6SCIg+h0QJapKPJhJaogJZwjBViK0H9l0s5kwksyKBJ4O jF2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786971682; x=1787576482; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Pt/tj652A2oLpGz9ZiRJRKyPZerizXNg8HfABWDPXXs=; b=Jbvg2hdSPB8CZIETGdICoNYHXqXUYHopDILvOT062c8SbajJKA0LqjyzfOx9gKR29o JF9qVs0vy7wjD6lXdw9lobGGk2ioX0TkoKOJfptc1jcPmRJjskOh2tXhk6rmhKtEDXPH 91io23s16veXmfXhdKt5wD59F5wM1Q9M482AEpU34EgrKHR4lYudbmujB1Tt5dTRlg8h 7Z20Z7R4IZ+cVaqQ22zI7YR3+HKIXQBcbhMk4LYyhd9G319QBS4BrktvU5JMPkafOPdi lmKqDOXdHYM5TeGnpeHf9Frn7GOGq90qzMw/KQy5SOqI/eTgXhhlG/7TzhgcHXMjs4+h qbmQ== X-Gm-Message-State: AOJu0YwPDttCtug2x0lQWzl/3kB8CJ2O5YXWBoFm2T+5YI9CFu9JrioY yObDtqq75WsBQnaueiP/0G96QntHgGWHKaWhL8Eut7uBcsXL1Zr5yqa2 X-Gm-Gg: AR+sD129Xi5aChaaIXXxJsou28+XadsfAZE8IMaFuQ9+nbAdwN73BXHknRr0pEJwJrs 9O/Yg/xExFFWeJk32B2+9Xk1VhPGxEOmgTyNeuXY0Z7HFzXaatS1ZMUFoWCdzyD6gs9dZZ9fAiN LduQxReeci8p4RPudzk9RddA2BPC1Erxq91Fxygmr7VM/ca+dGpPQTVmHncFkeXMIU6JOszv8UB E2FMINDfA5Z/U5Klj2AS3qk335/LO3bX0K0kZ6jUSkcKUea15ztuxo2w2E2lX7lpjAqb2MgGjOs CGwQoDAb5HNlXp/n831qpTYfMgXlR4z+FIadLdtPu4y/nl/wHt6nfoE5vDFj7APnPNvFhPrAGC+ WGzzZCf8GVXyHUwnDRThfjMbts3QyZylCYRn1IRtK2EzX0BSKDUX6TQ4wAXanCBn1i+yURYf8/p 38YAHcZ9nEy1LaInQAPnPr9SY8a5/EJcrxmAQijDd4XwEtUosF6qfVWCq/fy2eWBHzVw== X-Received: by 2002:a17:90b:4986:b0:380:83fc:4315 with SMTP id 98e67ed59e1d1-3955ab8e14emr538424a91.21.1786971681986; Mon, 17 Aug 2026 06:01:21 -0700 (PDT) Received: from user ([2405:201:c052:b00b:996d:a87e:1e18:16b5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14153073befsm5999854c88.7.2026.08.17.06.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 06:01:20 -0700 (PDT) Date: Mon, 17 Aug 2026 18:30:45 +0530 From: Yalagada Pavan Kumar To: syzbot Cc: linux-kernel@vger.kernel.org, malathi.a2000@gmail.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [intel-wired-lan?] UBSAN: shift-out-of-bounds in e100_eeprom_load Message-ID: References: <6a82fff6.dbb3a75c.20434b.005a.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a82fff6.dbb3a75c.20434b.005a.GAE@google.com> #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c index 29960762e64a..5165f1d3c98f 100644 --- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c @@ -744,7 +744,14 @@ static __le16 e100_eeprom_read(struct nic *nic, u16 *addr_len, u16 addr) * complete address. Use this to adjust addr_len. */ ctrl = ioread8(&nic->csr->eeprom_ctrl_lo); if (!(ctrl & eedo) && i > 16) { - *addr_len -= (i - 16); + u16 len = i - 16; + + if (len > *addr_len) { + *addr_len = 0; + break; + } + + *addr_len -= len; i = 17; } @@ -765,7 +772,15 @@ static int e100_eeprom_load(struct nic *nic) /* Try reading with an 8-bit addr len to discover actual addr len */ e100_eeprom_read(nic, &addr_len, 0); - nic->eeprom_wc = 1 << addr_len; + + if (!addr_len || addr_len > 8) { + netif_err(nic, probe, nic->netdev, + "Invalid EEPROM address length %u\n", + addr_len); + return -EIO; + } + + nic->eeprom_wc = (u16)BIT(addr_len); for (addr = 0; addr < nic->eeprom_wc; addr++) { nic->eeprom[addr] = e100_eeprom_read(nic, &addr_len, addr); @@ -791,7 +806,15 @@ static int e100_eeprom_save(struct nic *nic, u16 start, u16 count) /* Try reading with an 8-bit addr len to discover actual addr len */ e100_eeprom_read(nic, &addr_len, 0); - nic->eeprom_wc = 1 << addr_len; + + if (!addr_len || addr_len > 8) { + netif_err(nic, probe, nic->netdev, + "Invalid EEPROM address length %u\n", + addr_len); + return -EIO; + } + + nic->eeprom_wc = (u16)BIT(addr_len); if (start + count >= nic->eeprom_wc) return -EINVAL;