From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FB1E42A141 for ; Mon, 17 Aug 2026 13:29:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786973363; cv=none; b=biRniBebmkQuuwFNBKoW9aeVPklF5OuET7OGmx2JSR54x5A4cuOCwFHnApTC6dQn8PFWxAfBTZnIGrseIlkisc7hULau43DiJvEntNuVNiyl6fLEIOREPChsN+IkCqJsVrEJQhGbDgGlcQ9d05LWmmqPPyMWG5/AYQRa3hLmgfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786973363; c=relaxed/simple; bh=+0Rws5qYqVIW7NwWsmWi/o4ix79UOI8toQnHWkrkhgk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iPE14vCr3lx6H0vF8rSGEMgmdHsPMRVcLyUTNbFr/fx3X1vnMVBgj8qrK/1eplIouE5a6YFq9rLl5l1R62YUyq2CCb/P3Ii0jhN3iKMm6GR/TSBTfQKnEWW8rrNk0iVZSNVXcEAsZBLFNq1+IvP1rosc0F/Cicnp12HbcALRNxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=GPiuWCvF; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="GPiuWCvF" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-4798bea72f9so2196759f8f.1 for ; Mon, 17 Aug 2026 06:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786973360; x=1787578160; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=UnfYmqxVfrOcWeieqowIf9SlkMC6J9el3UG+ajVf3ts=; b=GPiuWCvFLiHQaJFKYhh1WyAl/wsfFKwEG661/hYbhUtwHKKnbiIdv6xNV2Gy2w4V8j 2JISFG2EAcH5dPOgWXAJcK7+zrTTy7Tis8GaVgcSoCHFJy/GdJtc035LeXb4K/OQyKU4 eVPN3FuT6X41cjCPOwDjeN4vKDrM+U+TQVPJOfl8FDRHTB4Ig3kjZsIXnaTsp6W6OuUY Z22ephwFSQ2dd/J2u8Q94TdvXF9cZPY3V20z3Pzx62TeUUldMcf9N+qaaMh7fA3R/4O1 /VnJVGDT5SR4b8HcFpr+gMHWMVWPfmZGHXrt5FxHkrD3p4+ppLZf03BihO3I7YtV82C6 nCeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786973360; x=1787578160; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UnfYmqxVfrOcWeieqowIf9SlkMC6J9el3UG+ajVf3ts=; b=iyOMLhLDd1xxYnsCRI2QTPWssQf72GY80GSv3dLLtBER8qylglAaI9f3toIKAZakep UCMJGMl+LtB0maJQYjhAoLgldyCWV5MvchIxF+moMoCuoSDkizedxTsBizpMBDCLL2ce nsYopTsluwlhSdS8EsQiheW1Ni0deGTeVrddSuub+M6fUNzUPfDCF9C+ATXE3xwZIh5I UoeRnhk4VaWWF2Q/PYQ4Jb7R7YxoliRExf9KqzFlq9YB1BXKXXYfIT3tF4BYKDIthqg0 xcsPo5NiFpOzbnvPfYtMRmIefH7+J5TDWOS+JQ4Xw1ux7OKw+ipSivhFo+L+bLffEhQN MmMw== X-Forwarded-Encrypted: i=1; AHgh+RpO6Nyh+ADxH8Mt83v2w1a0nYjU8ghDryvsM6xA919DtBovlEYB8572zT8beFBLyRHsBDrdEnJAxxasqQ0=@vger.kernel.org X-Gm-Message-State: AOJu0YwVixJF5+4UcC6IBaROyKK3+91O8phyxv+gcEblfPVjN3K8ctz1 GobEzieuwWAKJ08XrkdW44DGJoV8jNAKnSBBUNdmnxlAvNctbu4ip21kv78nZOi9PvE= X-Gm-Gg: AR+sD10fL+xz1rJs7ZhMyPUuR9UFXbbRK68bNqVRUXa+/QOR4oug/9axNRLF8KCnpBM e+rB3QaKlKU+0QbJDRKPe/ldxyPECe+cZjIwDBgLrNZGPMFuhkNI9te54TVE4PqB2dRJJsw6qR2 IeI6GDgmgqR+1SdGav4q6szFA+ZsojH6ToeFWPI2d/ew8MiKzBrk72PFSaalrUBcWm7zxlBpHyn 0Uh2SzZJI7YagBLp62zpOi6yi9t0Oe6gVTpMBgSGOIVQlQPO1Go72i7mRj80aWJ11zEJFTGQIuC hYmLoDlVU7yENEnimhE8XMwLqC3uEqBrksXAZ4nWRkNTcnMCg/nsI5cQYvBI7psQzVxRmdgEt2Z YksZuii/DAVsaRnUPez2eiSpKB1+Z4Nj+RiiiDZobmc6jKztJdZeCe9FLChDZ79Spgz6R2/RIuF pnSZtXfdCgg6kzbxpNqGWYTSrtYinizDFCURjdGzZpeShnsuJ58qc2MgycxgMVO+EfuDsNAls= X-Received: by 2002:adf:f84f:0:b0:47f:eb22:4d9a with SMTP id ffacd0b85a97d-482a90e80aamr58867f8f.22.1786973360523; Mon, 17 Aug 2026 06:29:20 -0700 (PDT) Received: from localhost (109-81-86-48.rct.o2.cz. [109.81.86.48]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5b77f41sm3794755f8f.27.2026.08.17.06.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 06:29:20 -0700 (PDT) Date: Mon, 17 Aug 2026 15:29:19 +0200 From: Michal Hocko To: Song Hu Cc: akpm@linux-foundation.org, audra@redhat.com, bingfangguo@tencent.com, cgroups@vger.kernel.org, hannes@cmpxchg.org, joshua.hahnjy@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, muchun.song@linux.dev, roman.gushchin@linux.dev, shakeel.butt@linux.dev, zhuhui@kylinos.cn Subject: Re: [PATCH] mm: memcg: flush empty per-cpu stock slots on memcg offlining Message-ID: References: <20260817131221.44761-1-husong@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260817131221.44761-1-husong@kylinos.cn> On Mon 17-08-26 21:12:21, Song Hu wrote: > On Mon 17-08-26, Michal Hocko wrote: > > Is there any specific reason why the memcg stays in the cache slot > > without any pages? > > consume_stock() doesn't release the slot when nr_pages hits zero. It > is kept for the next charge of the same task and only gets displaced > by a charge under a different memcg or by CPU hotplug. The problem is > that the offlining drain skips empty slots, so the css reference they > hold is never dropped unless something unrelated displaces them. This doesn't answer my question, really, does it? Is there any good reason for this implementation? Why do we need to drop references remotely when we can do so when the last cached charge is consumed? -- Michal Hocko SUSE Labs