From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B12B73F12C6 for ; Mon, 17 Aug 2026 17:27:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786987657; cv=none; b=vEYmdrgNEQU8ch5NSMjJlck5wcwQ45T656ep2FjGBEcKaLKPiaabHL08WvzgBsphKtXV7EEAS8zE/n4j+QQN9KXU6bt/D2/AUawcEh81KzJFDVds4OijRRosI4ObFXzWWlzVuSzsXs4uWYIV6lZQBNc1ekTeFJoL8WAQTzXqs0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786987657; c=relaxed/simple; bh=FjzBUeXt7KkC1OsziX7jzph75iOnt9FOCjFm+/EJGa4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k/v2ZsuivoMSy5MLMStOoIZ/PVo6G4vlZiKu5rwzh6WZNJALkVIZawzV1xEu3fBxR61RBlFc0kpTuYjEURK5u750Fmgoic2bEM7D1OrSXRSgRzENitHXePdnb0y3TN7sehL1cNvH76bncLA2QZAM//NEpS0N8aWzFtf9HJ5NM+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Th24frw0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Th24frw0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EDA71F000E9; Mon, 17 Aug 2026 17:27:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786987656; bh=ctq0R6ygMT+w8aMTiqyYjr0f9Uv7YPSvV/JndH1xvEw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Th24frw0jFcKHuDZg3UO7g1KT7uq+mOYUNtUNsw9syUFm5Kdy4i12BrpxDSrEw23L 3EqBiajEZwVAxAjwGLDHvNVl7/u6ZQIprzmcE+VKsHUhDL2gcBBbOm3yJRkXNypzbK yTrAwCQMxhjM41wo8tdOX+WXRidz+jW6WRmpxuPgqlAjhVnBonHvorYXPyLDUGHpfo BdN9qLAj7ofjbJH8IAWjcT5Q/Ljtl5yGsnhP7i6EPZqzngCqRLDHlvQy0Qosz3Dniw 6WPgxFBUPsoWnGlj5He2Or0/L3qfT2jq2TipPJs4/Lr945GPZV7ayCLY18jcwvBIJ0 h+Zsrd1I1nUCg== Date: Mon, 17 Aug 2026 18:27:32 +0100 From: "Lorenzo Stoakes (ARM)" To: Lance Yang Cc: Eric Kim , david@kernel.org, riel@surriel.com, liam@infradead.org, vbabka@kernel.org, harry@kernel.org, jannh@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH v2] mm/rmap: synchronize lock and unlock target in anon_vma_clone Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Aug 17, 2026 at 11:07:49AM +0800, Lance Yang wrote: > > > On 2026/8/17 10:34, Eric Kim wrote: > > Currently, in anon_vma_clone(), active_anon_vma is assigned from > > src->anon_vma and is used when unlocking anon_vma after linking > > new AVCs. However, the corresponding lock operation uses > > src->anon_vma directly. > > > > Use active_anon_vma consistently to make the lock/unlock pair explicit. > > > > Signed-off-by: Eric Kim > > --- > > v2: > > - Clarify the commit message to explain that src->anon_vma and > > active_anon_vma refer to the same anon_vma. > > Just a heads-up... since only the commit message changed, the Reviewed-by > tags from v1 still apply, so please carry them over ... Yup, if you're not fundamentally changing the patch you should retain all existing tags like this. FWIW: Reviewed-by: Lorenzo Stoakes (ARM) -- Cheers, Lorenzo