From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60F5F420485 for ; Tue, 18 Aug 2026 08:53:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787043222; cv=none; b=Wmv1jLhTP4Wlnj8rHtque6m2vCH/fDYjHuKu2d+f75fLIs/iptQb/yc1mA+hAsMZ1+D9Lqj7prjIP1ZvRLiGgMKVGrW4RlACZ4yRwew/b0qc2pCRcX6HTvO4HkMK88VjmmnTkGPmpA8jv4C/uKPcLNDiqglL9Vwa06Y05tRo6Fs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787043222; c=relaxed/simple; bh=79RYIFF913FaQlkxpRypw1VybVy1tpFdCTmdzw/Dx70=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DhKgrUikHGr07YfuMRVx0Dol8vR2Edu8MQG9ez9qtAU/ApIJnvYw17nJYO2PgE5rueBdBxvqnnhr4ihsVYQ8UGHdAxz0svs5vjzrnVpJk5mxVQ0muXMz6XkGt7ldxcK8f9KgV2X77NJpz4OXJGTJMufDLU3Li9iv4pS+zQopZmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=a4oq1j/X; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="a4oq1j/X" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47fe377a217so2956477f8f.1 for ; Tue, 18 Aug 2026 01:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1787043219; x=1787648019; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=5mBjzB8/1EWlBo8ixiwD3uUsZbNFlGOVh/ZsCswiezY=; b=a4oq1j/XeFtB+7f6ISzrlS8MVOY869YfpT2sOXji16Jm9pdJsAFMO7siGgQwjsPcPF roS2bWTA/n6rbGrpijUbfrNkPCX883N9lsCIRXWvDdNxev9MyvZ9LYy+q3cl45WXxj/7 YXgFBc3RTnEIR9qXfTr5zFammv/bKeU0gbPqLZiTpC38RQ69PfX2jV1tJBF8G0qr6874 OFX+qnaZEQKDrB5RmtliIz5hysrnuXV2LQbwi0T9Zuj2LGqK3yK1A7obCu60ttX86d8H z0EYuPIkkGrS21tBkqL1cSVj0tH3ajzi17Yg0DYaoDHGe+ZPfzLTbCvDgj64+r5+e5F1 VTZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787043219; x=1787648019; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5mBjzB8/1EWlBo8ixiwD3uUsZbNFlGOVh/ZsCswiezY=; b=FKpUw6qULE/XpBP1Xxhp7QZRdkMfjVoy8dRZJxPG4Ebc+pbyRR+QxL97J6bFi2uRPA wTsIvEihOJl7dVJLxWeo37ty7rceZm0vfobd9stjegEKIgHIcbNaDjABysV2HmWxDqRu pXkIHQJveC2hfuMzDJbYBwlSQDH6GE/GFAkCQwIiOweniZHRZiMLFZhgDDHq5GP7Dj08 hGIpehnYrQn+s4TvTuOx6TVgwmFo2244Sy+MeDTPjNS3rFXp66jCbOoWm1vN8cmQ4tHi 8KFwblBN1ytTxp+RLLsIuDo3kMKAOs5OIkCwbFtYOroD/TMk6la1qm1FpGrjhTCmUwwS rNPA== X-Forwarded-Encrypted: i=1; AHgh+Rpopf0Fd4mfrfKRSE1exmkwkvXj6fFK85276Ba402HE85/kKDxKMK7qWUzidNZ330LPv/cetrLQjVoeYo8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0MkGRjD2jFcHhMx6JZOUDguV90KnkmO7wEIZyqzRUNpsG0M5B GUcs2Ud0z9uOEEfpd1Hvs74P4n6FzaUH7v6UkpnyvUNyV+EdzDHaZUIT8UWR1nBaPtqCM16zs/H 6qY6Dr68= X-Gm-Gg: AR+sD13cGes5tQXYAa5aQMPrBwINGQtCEumJlsrCmKrkNlmF/d1btyepzvXGW4q1AYD aXQgXZWHgGpaqlSYEHc358JJIP1eX6xwWDBHqWzc6oDGVeIChVbOzAq+qqY3LKBwX+BsJmKS6/F yK/YDhVD+Pv6MCw2TL/CVDjNCbO07oM45aOsnXFQFDnG+mAWR740bpCjrQKpbsoy077VpTuzpu5 DCF/0r6yNELlA2Eri+GsD13pCXSYpJnZE+LIa2+hncPZUdk1/PfKpXMhLAAhWaMarO/5YLNlPSS 10hiFRIQayU5IW4oRisCE2lOwm9nfLqnWQz5GNgXk7vjUJyn9gTSkSJh7k9yrt9vSklcHDuqVUn 4JKCycaVwIVf3wEgvDufQ+jlZZaTL+i4OYILeWVRzra9hAmxntVel+ClMzimKRF1ECtMM1AYLGp OWiuIazVFRw+u7wxo367gEHq4MGLglz74aZPCChpL41vdjYvvdaQC5cy4Tq82ylqwTsyjzufJPw dv5R5+xusk/hwLuk9IkoixM1vqnah3ebapOZtNHWq4Rq5AqHgmJYy7ggUa7Y88= X-Received: by 2002:a05:6000:40da:b0:481:5003:c654 with SMTP id ffacd0b85a97d-482a8ff6003mr10697063f8f.7.1787043218545; Tue, 18 Aug 2026 01:53:38 -0700 (PDT) Received: from localhost (p200300f65f01710416869d85a644e839.dip0.t-ipconnect.de. [2003:f6:5f01:7104:1686:9d85:a644:e839]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-482a5b77f41sm9680514f8f.27.2026.08.18.01.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 01:53:37 -0700 (PDT) Date: Tue, 18 Aug 2026 10:53:36 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Sumit Kumar Cc: Manivannan Sadhasivam , Jeff Hugo , mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krishna Chaitanya Chundru Subject: Re: [PATCH v5 3/3] bus: mhi: ep: clients: Add loopback driver for data path testing Message-ID: References: <20260817-loopback_mhi-v5-0-50efc7360b7f@oss.qualcomm.com> <20260817-loopback_mhi-v5-3-50efc7360b7f@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7oc3zz2p7n6vaxev" Content-Disposition: inline In-Reply-To: <20260817-loopback_mhi-v5-3-50efc7360b7f@oss.qualcomm.com> --7oc3zz2p7n6vaxev Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v5 3/3] bus: mhi: ep: clients: Add loopback driver for data path testing MIME-Version: 1.0 Hello, On Mon, Aug 17, 2026 at 03:44:36PM +0530, Sumit Kumar wrote: > diff --git a/drivers/bus/mhi/ep/clients/loopback.c b/drivers/bus/mhi/ep/clients/loopback.c > new file mode 100644 > index 0000000000000000000000000000000000000000..18a92d6a40e0f7de277d155cdb5495d14a60c19d > --- /dev/null > +++ b/drivers/bus/mhi/ep/clients/loopback.c > @@ -0,0 +1,130 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#include > +#include Similar as with my feedback for patch #1, please don't use . Either rely on -> -> , or explicitly include one of the these headers but not . > +#include > +#include > + > [...] > +static const struct mhi_device_id mhi_ep_loopback_id_table[] = { > + { .chan = "LOOPBACK"}, > + {} Again, please add spaces before the closing }. > +}; > +MODULE_DEVICE_TABLE(mhi, mhi_ep_loopback_id_table); Best regards Uwe --7oc3zz2p7n6vaxev Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqEHY0ACgkQj4D7WH0S /k7YBwgAmrxBnCENBhtnqeEuJ1yhX/F/+5dP+2pviuRThhUBDMwsNGw27KtBZEaU S5y/S3T7dEbOQyqg9rGireCNBBpuLilhdPhSU/srmyf6MbjL+KrYL1apHKMzEGF6 mO18Q3h9zTatfoUDTQY8ahqDTX4CoOgBzcEfK8Dc9r/GfkT2CVQhC4EkgqVDJN+T vnlXq8KecLz5ynZM2OVGfHuMCPZi4OGzM8FEzqU1116/67AGYEXhlKbpQfybK0wZ tNVLfVNkoYRmu67Nlu4aC9vvhj27pNkQ8QvvIYViPhA+Qd3VZL8nBcE74WSWB9AR rsjBXwRj1qpzw7VK2WnW4MFO8mKvSg== =0Wif -----END PGP SIGNATURE----- --7oc3zz2p7n6vaxev--