From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57ED5420485 for ; Tue, 18 Aug 2026 08:51:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787043064; cv=none; b=FS9lDgBzyM4r1lFMrUPPQcuxbA3z9o1mryIy/gu80EDSWJ5rE1fA7YMS/Zk0guYPyFRI8tdD5XIe25LEegU8b58CL2WkNz6ZW2hx/rJhYwck+V36lV9hYoHYDE1edzu2AX/bs6j1oZ9Dp9hglwHkamQ2k6B1Mh7EVrFonEpbQoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787043064; c=relaxed/simple; bh=i7pImXw3XlzpdmtRaUE9j4sBqgONJfFhH37MbNZuu1w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gs1jrLx0eLh91HBhi/RZiwPf5d+Hia7loTnHmnXxyYMomO7KrsTgMYt7J+6jYt7YYKJunsWPcXLUexkNTlEkw6Ef1a8NQKRqZBqzdNrNgesyBzKDWnkgRYr+Z9Qj1zm49dU+ytdnp1yGUwCztL26J3Vppyajsby2aDEHIFJ3oDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=fXfjY2Mv; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="fXfjY2Mv" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XwuCqX9TnQYK22XQuTy0J5Z4XyKTmxsVQS4S9N8AH40=; b=fXfjY2Mv0jNfdBNs4jH8af4ETR 3DMxHjxBfw67nU3IlLXw3KaAjLK5HBr3Kh2KFFwJz3xcFpLebIbQEnx6AX0+vqs9J25Pv98lRob+C 6c1bSrlOPt2oR4XONbyZ9VMvv/mJCWm9+ouQO1WXOIOMSunJmwTJOQbIimIsFMChCBqEsieliDz+c X2asfTecb4aJJPY+A7zB7Fkl5I0N1gcJwVEpKqiOfQ5nxHrfDV/IxwAJGe711ZurRx8lnE2735Hg4 0KvvaZHn+BVTB62j9AFKvGC/pQPWPF0KUcVafMTCNotnKgCBYKjIdD/+i3c8M9rVZpAos7lxu7aw8 Ci7+LmrA==; Received: from authenticated-user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1wwFWK-008tFv-0S; Tue, 18 Aug 2026 08:50:08 +0000 Date: Tue, 18 Aug 2026 01:50:00 -0700 From: Breno Leitao To: Andrew Morton Cc: Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , Hugh Dickins , Baolin Wang , Peter Xu , Johannes Weiner , Yosry Ahmed , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v2 0/3] mm, swap: don't spin or flood the console on a bad swap entry Message-ID: References: <20260813-swap-v2-0-4a625ccabdae@debian.org> <20260813133455.3fe770eadcbe640e6f6c46cb@linux-foundation.org> <20260817145337.85c945fbfc7e8165ea016710@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260817145337.85c945fbfc7e8165ea016710@linux-foundation.org> X-Debian-User: leitao On Mon, Aug 17, 2026 at 02:53:37PM -0700, Andrew Morton wrote: > On Mon, 17 Aug 2026 05:21:32 -0700 Breno Leitao wrote: > > > I think only 1/3 should be getting a Fixes: in v3. The message I am > > drowning in is the Bad_offset one: > > > > get_swap_device: Bad swap offset entry 3ffffffc043c5 > > > > 63d8620ecf93b5 ("mm/swapfile: use percpu_ref to serialize against > > concurrent swapoff") added the put_out: label with just the > > percpu_ref_put(), so that arm was silent. The pr_err() landed in v5.19: > > > > So, if I need to update it, I will include: > > > > Fixes: 23b230ba8ac3 ("mm/swap: print bad swap offset entry in get_swap_device") > > Cc: > > OK, so you think that only [1/3] should have cc:stable? Correct, that is my suggestion. The other patches are more improvements than a proper fix, I would say. > > > [2/3] is "no functional change" so ideally it simply wouldn't be > > > present in the series - we should aim for minimal changes when fixing > > > bugs, then leave the cleanups for later. > > > > I need 2/3 to expose the difference in the first place. > > get_swap_device() returns NULL both for a malformed entry and for > > a device swapoff is taking away, so no caller can tell whether the > > failure is worth retrying. > > > > 2/3 adds that distinction and converts the callers, but none of them act > > on it yet, so it is no functional change on its own. > > > > Then 3/3 is the actual fix, now that do_swap_page() can differentiate > > a retry from give up. > > > > Do you want me to squash them? > > If I'm correct above then please send along [1/3] as a separate thing > and I can queue it as a backportable hotfix. Then [2/3] and [3/3] as a > separate two-patch series for 7.3-rcX. ack, I will send [1/3] with the Fixes: tag, and then [2/3] and [3/3] as a new version of this series. Thanks, --breno