From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
Mark Pearson <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Hans de Goede <hansg@kernel.org>,
platform-driver-x86@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Use bool for str_supported() parameter
Date: Tue, 18 Aug 2026 16:34:05 +0300 [thread overview]
Message-ID: <aoRfTdHh6MJqe5hL@ashevche-desk.local> (raw)
In-Reply-To: <58e1e888-b13b-a77f-363a-8e8a9a1f9c4a@linux.intel.com>
On Tue, Aug 18, 2026 at 04:25:21PM +0300, Ilpo Järvinen wrote:
> On Thu, 6 Aug 2026, Thorsten Blum wrote:
>
> > Make str_supported() take a bool, define it inline, and return string
> > literals directly. Use a single inline definition for both debug and
> > non-debug builds.
> > +static inline const char * __init str_supported(bool is_supported)
> > +{
> > + return is_supported ? "supported" : "not supported";
> > +}
>
> This certainly looks something that should be in linux/string_choices.h.
> I'm pretty surprised it isn't already there actually.
>
> Not sure about how to name it though, str_supported_not_supported() a bit
> repetitive. Andy?
Is it part of ABI? Otherwise I would rather see str_supported_unsupported().
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-08-18 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 13:15 Thorsten Blum
2026-08-18 13:25 ` Ilpo Järvinen
2026-08-18 13:34 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoRfTdHh6MJqe5hL@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=derekjohn.clark@gmail.com \
--cc=hansg@kernel.org \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®