From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8B0C45DF44 for ; Tue, 18 Aug 2026 13:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787060395; cv=none; b=TeqyyLBu/zX7xU0yxZ0P33iBVyRur0+RwO+oDoo9E7CnnZLLl0g9ycO8khbBOZ794MZ8xdorHLQlt0/hZMBtfYog/EjQ6dHtev0yfBZZnH/vSMEN/Jyn5J+UMUc/CqDEVM6+z32dIA2Per6KeeERsNE7atmTcertmvfZ1zpZnyE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787060395; c=relaxed/simple; bh=g52TbLKOLRnjzdDqnuarp3D7v4E3YOEi6S8XK1pGiKM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m5z/0vZQH/pnSc9J4YJHrf2VeinJ5KHss1bOmDel6hHNEKtyHdp9YofpFDs33IgamzwoFQnCMmHz0PRCkkCJDMAWU7Q9FI/OFcg4P106J6WLm16c/iap0/vuO3tC5JhOfju1jEKRX/Xc3Qii1qILOUxYg5FO+n9uyh4To+D+1GY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fv1S9COy; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fv1S9COy" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so45182245e9.1 for ; Tue, 18 Aug 2026 06:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787060391; x=1787665191; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=SB8IZ6vjsjyD4oW3JJjsTxZenQi13vbgHnO3UjiHMpQ=; b=Fv1S9COy+7c1biW6Qn/9mOsvzBF+g+E/egDqq47Wtlsui591PxAq3rYhqnTVosC7jX DrErF0Mg5fGf6ffU+/OPdInSqc36dSXHBwYoilK5XCTsSxXntZrJi/Gw8dNBqq2BDJRd iesw9dWl3REXM4tdOCbCPEvNlJWAtteMwECgfJJGa9aGWZd7GXcQBaOkz5I81v2Rml6X NCRbmmJ2BUkqmnG0WaGYhAdeTBIoXT/gaIsN3M6Kw/HTpTQyt5V9/FDi1lnukkXPnVHf fcY/TMq4s6HsAhEsDE0gjuHsOxOi2hPBzgUqIyX7fjKu5n/bGBDDAq00GQlZzFQr8juA oiwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787060391; x=1787665191; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SB8IZ6vjsjyD4oW3JJjsTxZenQi13vbgHnO3UjiHMpQ=; b=H50EUJoZOkR+hTRN2ty1nC3eixja+stU6gKwMT+L9EBlcN7SzHv5EHe8qBjES9VXtq XLo+EZumwFXyAzTdr9SWa9H4bniDaKaUU11Q1N2AgbJvz+QPt+Wl30aiWXfRlUIc9kna Ne57fFPG1sfLxy7UdpAK62ySRKS4xZ8AGZXf9jixpP1+/dhLsTGmTS49KehMfNgAGXVZ p6cdciAIrMeIrBbY6EvJ+PdJrrpE+SwYiNSIfPD4OhpgKECCKA6iKY8BZQ7HVqzaIjlL pgMlq8FhsCL8FBWhXW2+keHPByzdHVoqiRd8/8zv0RD5vMqinz9CnnUkLL1n+S48Mj1J LdNA== X-Forwarded-Encrypted: i=1; AHgh+RqaH/Wkj8xV1cIiBnR8aFC7xZ8jE8tgcgR5Q1JP785axsBjvbpwVkc2fNJLJ6Y2qYylpUPvQYQvX6GedFk=@vger.kernel.org X-Gm-Message-State: AOJu0YwkrMNc2rk0G2WgooLQ2Oar1BZ273xHtLyFKJ+eJ+RzIHoW6TyP wq6huhfyEZY7zDABX7xmEWcmMtb2ebyFuN6AJ1afwlCYRJFI3xnIcSEr X-Gm-Gg: AR+sD129aXy/zvRxWgzdQgQsI8Hyd8PtgOcH9nSE5gtX1ND9GnYsv+K05qKjuPym4+V 4C88TPKQQ6sB7+f4GKQUHnus6dK8rSVbEA8u9/dlB7ZceifLYkSKk4YhsfzuKr+eYRa7VT1LxzC Sz5zolQryoiYTFHAU/TFjG2sUsKuuORsfQk92bQCVE8cWVwBtJA0lJbkDoLxOxZOeqyO8zfk0uf LLbQOQwZTKZQ3XILK7oq1uUEe1XU6M+/PLMt775z/y8nZNnZdz1PgsNrO0qpf9Mn5m3kg2HZnSi fZo53VGNgFWzojiYUNPUjcSO7mfdmWIisvY8wkyapVh9Aw7XhmnicigJTT2MjgI8W2Y/R8BCfhr Kc+7M13jFBOFEulIY9QrugjYyXlTY5vVUyEG+y1AK9bJF2UlkDRmQLGIuH5PEYGuzqdI5DZUxMu s90N7H0NeM4P3SFOXbsh6+nF/FN5I8rmpKIJ9VyK+XxUbG6WUAZ2T+RIkRkhRZiw== X-Received: by 2002:a05:600c:8714:b0:499:49f3:77b1 with SMTP id 5b1f17b1804b1-49987938551mr591057895e9.3.1787060391412; Tue, 18 Aug 2026 06:39:51 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5b7840esm11044133f8f.29.2026.08.18.06.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 06:39:50 -0700 (PDT) Date: Tue, 18 Aug 2026 16:39:35 +0300 From: Dan Carpenter To: Dhanush Muralidharan Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove extern from function declarations in header files Message-ID: References: <20260818131601.96509-1-dhanushmuralidharan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260818131601.96509-1-dhanushmuralidharan@gmail.com> 1) No commit message. 2) No Signed-off-by line. 3) Mixing unrelated changes like this: > -extern u8 rtw_setopmode_cmd(struct adapter *padapter, enum nl80211_iftype networktype, bool enqueue); > +u8 rtw_setopmode_cmd(struct adapter *padapter, enum ndis_802_11_network_infrastructure networktype, bool enqueue); https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter