From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id E4C20468C20
	for <linux-kernel@vger.kernel.org>; Tue, 18 Aug 2026 14:07:32 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1787062054; cv=none; b=bZIuXMAid1rdRjkvJQFeqJmwHof/QXhO13NAmFpRlUJGnQimUvXJ17T9ZLQcPnHfFsUdvYEBpCojmugJcm0/SgfEWadJYnySENwaoQgFKpsYeaU+MsmAtxy5gN8ODi6X0Qvfd0NKL7usCIh5xvkZorDL6vflLezGJmb5fbakm68=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1787062054; c=relaxed/simple;
	bh=0sqtwohSLIumibqmsfO/JhI8IBhQB0YsriVnfH2MrIY=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=IhNq3FfRLaPfSCZbUN2gd0nRnEhJN/Gf4r3F+vao3ZqYfAVJDRgA0jDvKtAKnvvx5/T0KjNRxOSUutgGKbWMKwrXyAEdkEgbMIyIuBSI2+arng2A1wOC7UVs2CgH2ydQt/NqdPiBl8A/PJp5ft1y99o6EX+r9NU5kT1/iZ5KxZw=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=B/ow6Zp0; arc=none smtp.client-ip=217.140.110.172
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="B/ow6Zp0"
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F16B8152B;
	Tue, 18 Aug 2026 07:07:27 -0700 (PDT)
Received: from arm.com (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 632493F85F;
	Tue, 18 Aug 2026 07:07:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss;
	t=1787062051; bh=0sqtwohSLIumibqmsfO/JhI8IBhQB0YsriVnfH2MrIY=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=B/ow6Zp02cKG2P76++iFsGJ6k7yaOTQOK8xrZVon85fmjZmVhaZ9NQtGZ4qPZTEoX
	 JfwIGa8hvFIOJUJzvFjegNEft6us5fqSsEqGAmPLWl0YDshdw7drqJuLSgzgUxTd5P
	 x6LK1qC9ES5qugkoUL869bbTO1dgdzB1eXoGqCds=
Date: Tue, 18 Aug 2026 15:07:26 +0100
From: Catalin Marinas <catalin.marinas@arm.com>
To: James Houghton <jthoughton@google.com>
Cc: Will Deacon <will@kernel.org>, Muchun Song <muchun.song@linux.dev>,
	Oscar Salvador <osalvador@suse.de>,
	Nikos Nikoleris <nikos.nikoleris@arm.com>,
	Linu Cherian <linu.cherian@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	David Hildenbrand <david@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ryan Roberts <ryan.roberts@arm.com>,
	Nanyong Sun <sunnanyong@huawei.com>, Yu Zhao <yuzhao@google.com>,
	Frank van der Linden <fvdl@google.com>,
	David Rientjes <rientjes@google.com>, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org
Subject: Re: [PATCH 03/18] hugetlb_vmemmap: Leave pages partially HVOed upon
 restore failure
Message-ID: <aoRnHjaQ9Y61OB5Q@arm.com>
References: <20260708031129.3503195-1-jthoughton@google.com>
 <20260708031129.3503195-4-jthoughton@google.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260708031129.3503195-4-jthoughton@google.com>

On Wed, Jul 08, 2026 at 03:11:13AM +0000, James Houghton wrote:
> +static const int VMEMMAP_REMAP_INCOMPLETE = 1;

Nitpick: I get it's all within a file but a static const int feels a bit
weird. I'd use an enum or #define.

-- 
Catalin