From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F09C5221F39 for ; Tue, 18 Aug 2026 20:04:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787083445; cv=none; b=bFMNYQBqdTyj4aUuCxHdPXqOTGJliuD2no47iMNt2ZOxOS7rn6Ca6jf7F2OOTaQGIcrfKepd2cUU444D0iugl4KvkP1s8QunozqJ12rfUHLfyobyhF+m4olC7iNZd6Egte0DbdYzAEPMJIH1D6M3nshzSyzVTQDJAFagrzQSGak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787083445; c=relaxed/simple; bh=IMToH6aqBK1v1Q20Qlxiqvz2b3zXH06lv4xXGBwgWsE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KGK1IuPT7DDImsyOGDrtex6ioPee2ucJKGMYdl+jU5HA7S2sgQ2Qr/gGzi9kR4bltEroXpA65u+WWnacellerlzqnMj7bvgXTyYXas+gU4BgZYVEBAAtiQ2a+PmB/gj7fyi2UJItMqfCQhOWYfbITt0hXbh92M3QdEav/HKKon8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Htin19sB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Htin19sB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 860981F000E9; Tue, 18 Aug 2026 20:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787083442; bh=vbCCyg5sm7N31JtWz3P7kk2HB2PMgWsMJFM5NtR7eEA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Htin19sBw5FGl9bXvHD/IAJ1ZNtjWkBpfMGtPQouBX8e6s6kCArPq90vI0JsvTDy5 NWRk2SY/QaN9/9DOYw/FyOfYZVK0o0/5jExtWGKLYYb2YZzXgPj2wPXONP7lOAAn8j sm6grTYWLguT4lT14y9J8fzW2FCHfhPyTI+BznJul0KTQ3V+1yyw/1X3gY+s8JKlUX SUEySbwDFRLjf8rJL7qVjw71Yqq+h/bHTHYK/nYWUxM2ndudUxGhKFUhxHvpb4MBdv hAWsARR6ZguNKXlfS1dosUind7KWRGOxJs3t+JCLTcg+breIX/q3yhZiWro2UV1eBX 1qEK2Cxz6ct4Q== Date: Tue, 18 Aug 2026 20:04:01 +0000 From: Jaegeuk Kim To: Al Viro Cc: Wenjie Qi , chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, stable@kernel.org, qiwenjie@xiaomi.com Subject: Re: [PATCH v2] f2fs: return symlink writeback errors Message-ID: References: <20260810133832.3530016-1-qiwenjie@xiaomi.com> <20260815051820.GA660827@ZenIV> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260815051820.GA660827@ZenIV> On 08/15, Al Viro wrote: > On Mon, Aug 10, 2026 at 09:38:32PM +0800, Wenjie Qi wrote: > > F2FS writes long symlink data with page_symlink() and then flushes the > > symlink mapping to reduce the chance of exposing a broken symlink. > > > > That flush result is currently ignored. If the writeback fails, symlink() > > still returns success even though the symlink is not durable and the same > > operation can already surface -EIO through syncfs(). > > > > Return the writeback error to userspace and skip the dirsync flush once the > > symlink data flush has failed. > > > if (!err) { > > - filemap_write_and_wait_range(inode->i_mapping, 0, > > - disk_link.len - 1); > > + err = filemap_write_and_wait_range(inode->i_mapping, 0, > > + disk_link.len - 1); > > > > - if (IS_DIRSYNC(dir)) > > + if (!err && IS_DIRSYNC(dir)) > > f2fs_sync_fs(sbi->sb, 1); > > - } else { > > - f2fs_unlink(dir, dentry); > > } > > > > + if (err) > > + f2fs_unlink(dir, dentry); > > That looks fishy. At that point you already have dentry hashed and > AFAICS f2fs_unlink() will leave it hashed and attached to the same > inode; sure, memory pressure will eventually evict the sucker, but > until that point any lookups will simply pick it from dcache. Thanks, yeah..it seems we don't need to do f2fs_unlink() at this stage, since IMHO, this code block is a nice-to-succeed as there'll be another chance to flush dirty pages containing the symlink path. IMO, we need to handle the error like this: 1. f2fs_new_inode 2. f2fs_add_link 3. page_symlink -> if it fails, we should unlink and drop the inode 4. flush dirty pages and or checkpoint -> leave as is and wait for writeback again RFC: https://lore.kernel.org/linux-f2fs-devel/20260818200121.2684318-1-jaegeuk@kernel.org/T/#u > > It's not introduced by this patch; the same issue, AFAICS, already exists > in mainline. Why do we even bother with d_instantiate_new() before we > know that everything's fine, nevermind doing that when we already know > the operation has failed? > > Incidentally, is there any reason to add a directory entry before the > inode is set up? Usually that's the last step, and cleanup tends to > be simpler that way; are there f2fs-specific reasons to do it in the > unusual order? I don't think there's a special reason in f2fs to do so. It seems ext4 does it similarily like calling d_instantiate_new() in ext4_add_nondir() after ext4_add_entry()?