From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96EA3277818 for ; Tue, 18 Aug 2026 16:04:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787069042; cv=none; b=oCGkiWUEXAkVtcLTHykklbNv3e1k2SGVR+ULTGRqM1og5A8KK34liz8fscqPOEMkd7ORQhsKsPDsLmCch3D3VhLbzmDd1d2pfN8Wr31txxwv8/88+QODOVqxEPNjWvY531VTyKcd6pynXxHO7e4GYucYbrHcPBaSerw0uyW+LAk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787069042; c=relaxed/simple; bh=yIOVKU/661dJhb8zpkIUgAFqvph5rZrZnYSo4XhSzGs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jkKvm6ql9CI6ygnoBu3OiH54DhP3x0tkp5FvsNEMRP7xjc4xyjMcmox+4/vSzUy8Ng3VZhw9hnHybHCiyRrXwCZ9R3rQKQubr7K1fyNFIuG8S6orNvM/EFzk7m2k3HqNdg4m183UMLr25BMjytc+Bci1URjh6RB3WPUBvsz/lZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H9Dmixdg; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H9Dmixdg" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5aec6360133so30217e87.1 for ; Tue, 18 Aug 2026 09:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787069038; x=1787673838; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=j+g7sibnUXhV3w+7R1/BF67gUhyBqAstSJuKbUpfaSQ=; b=H9DmixdgB8c3MiFA7AAGW1/aOBiitj9ITF0sxvkVZ8k94yopUHXn3gS6tfn3F8RE5i OvJyo891RgHhDyr2RJa1pK40vSpz25VPHXjSyUijZfixUnYSR0nMsB4JGhPdrng0TiYz NR3NanLMdrXNMdhMXh0iYeE7RJBngDYH1RCLWs6UM46SY52czNMQ3NfhT1OSsn+ViNu1 Gi59WSLl3oIxG9446RbtquVTaNztnsNuI4MvqRC7JwhgKqi7JkMhRbdcf3NVrgXjDTB3 eyTsNlPDLb8uQI+Ctq7BPWX87DtkYsiWpcP95fhO01BD1DweRh5lII82dd3kkmRhm8xg SUjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787069038; x=1787673838; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=j+g7sibnUXhV3w+7R1/BF67gUhyBqAstSJuKbUpfaSQ=; b=tSIz2Ye+eSg1mRHjei4avWVqXGk8gm0+OiowOQbbZRWgcV4S7Fy7lfkVzYzfi2GAjt rjIKQANb329tgbUxANLWGH6thRQ3dIv15DyW2HetRPuqlAQDCOllU/C9hZVDX/HIclEo V3ak2wk/Njj0pqaH2Cq3vhfjBc9z3p1/Cj4+mpWPQOeAjY0sfWkXPJaICx+Yty/3VRfJ UJpWtudLRFIfhyb0znDl/Pvqzi+cwPm0LJjSVOz32o1hDyKx0o47LDHvm1TXW93tZgJN Rcl+wv+IPFd0aWKRDPmnlwHwjoTywugXuMQJEUF9mUufO+IMs7OODlSZJjTxEgTTUeUb fV4w== X-Forwarded-Encrypted: i=1; AHgh+RqTT6dhshuc2kbtPci4xbsFud8JSclj9SJuSWAPgTwj0p7XnnpTFWRy04nNL2acZgcUVbxrFe0va6L1CsI=@vger.kernel.org X-Gm-Message-State: AOJu0YxW7LH5BmnbjtFMmKH/1k1yUM5ZlDOb8XM52T+UiA3jzXAKApPI pVvytK5XBDg0UfbQEj1RlPyts5U+wxpx6IJX7NHLTl7uq9ff9sCCwgr1 X-Gm-Gg: AR+sD13/tZynfYHL1MoAVBU0aPmYByvYXDPc2d2vp5Q4ZHROoH9NW9j80ulzA38h47S y8BTYp/Fr4DS9FdOLX00mXuJJaBOCPaOzhqcmCtTGTbo/VyYgclRDjiARMlYvuaOe3tN2TNwA3X NLpGLEcP2UAzSXJADVgCYRzdykQe1U/Z0Tf+LVhi3ExXBKtw/rD4ROGfnSPUuAlI3JqpErx6XA8 FkYb44wpL8p2CSNfmdlTDGXehumHMQRuJGw/pk0z5sLTns9gAOWsvxZ2ikJ9zzZS9NiIl3SRGEu dgKJtJ+cjGPipCiBXBXjCLZMQBW3HZOgpQAuTP9HgGM8pOFcTQkLDwd4VpX2drCoZ5oRzJ2QGA3 dirDzAicGA4FI4dfk9fny9NStFQLSKXbyhg+vOanZSqWPJBGOg2sCXue6A1vtHOVBFPS+JkIDwy RMfVHdmNWbrYVDBwpu7kn5F1T1wSa8tB5i0Fq9gZT+klXQeRjlb31WlOtzhW5upQ/6Lu9It3qaw 5kCD294Z//JALbvQGfGeRI= X-Received: by 2002:a05:6512:8399:b0:5b2:a74d:8c52 with SMTP id 2adb3069b0e04-5b470676388mr2278813e87.18.1787069038185; Tue, 18 Aug 2026 09:03:58 -0700 (PDT) Received: from localhost ([77.237.184.107]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b46cf960fbsm1386270e87.8.2026.08.18.09.03.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 09:03:57 -0700 (PDT) Date: Tue, 18 Aug 2026 19:33:54 +0330 From: Ali Nasrollahi To: Miklos Szeredi Cc: fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fuse: ioctl: fix comparison in fuse_setup_measure_verity() Message-ID: References: <20260813070629.248821-1-A.Nasrolahi01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 26/08/18 10:53AM, Miklos Szeredi wrote: > On Thu, 13 Aug 2026 at 09:07, Ali Nasrollahi wrote: > > > > Clang reports a warning in fuse_setup_measure_verity() in > > fs/fuse/ioctl.c when comparing the `__u16 digest_size` with SIZE_MAX > > minus the size of `struct fsverity_digest`: > > > > warning: result of comparison of constant 18446744073709551611 > > with expression of type '__u16' (aka 'unsigned short') is always > > false [-Wtautological-constant-out-of-range-compare] > > The warning is right: that condition is never going to succeed. So > just remove it? Well, I wasn't sure why it was there in the first place, so I didn't want to change the logic. So I'll send the v2 considering your comment. Thanks, Ali