From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DC96C448BA4 for ; Tue, 18 Aug 2026 17:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787072940; cv=none; b=bixwDJgI/kU8V4TRKQxtcsTo508eVkemtrgfxuQzar2wPKnmmxwYt9GUhYISi1Fi0VaTtiUWZHx2FgnkEjfg5e7ybpxxEMEa8z8yWVRSMWwpGmuRNuoBUSoXVTVHPIekLKZoW7k2SUS9AWm9tZouXl8kdEuUi+o4BiwHbAOblPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787072940; c=relaxed/simple; bh=+NK6o8MGjYbKz6ghgXSTW+obZNqfV8MyVVPimVK7gGY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ntovdcD+nutgIbEw7Hf705EJ6jejDA4k8uxVp9vlrd7mz9Ml4epO/dPiuBnTv4/d7ykbTFJNSVUw7suooq3ciJhAAZYbsVl0STJlE0fWy2y4KrIUxb9YhAVh/zv+vAJarEpH68LCyxohxt16z8rB63h6jXjxrw5ozgRRqzXgrPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=mPM4xC0D; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="mPM4xC0D" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D2F361AED for ; Tue, 18 Aug 2026 10:08:52 -0700 (PDT) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8443D3F763 for ; Tue, 18 Aug 2026 10:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1787072936; bh=+NK6o8MGjYbKz6ghgXSTW+obZNqfV8MyVVPimVK7gGY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mPM4xC0D4Xtp2S+fra+d88Q32MWQARBZ6dXltVqYa6jMQYa/VIWnIYaRbJekw1PdU ctVao2L1B/t5CrBYsaTAd37nqiTC7UEsEXGQ6AT8bt9DoPouCVi3EsSpdzXhIW7FfK KMUKRcUJlVv8+rnwIQlvPbrnQNdxGdiLjGnBH500= Date: Tue, 18 Aug 2026 18:08:45 +0100 From: Liviu Dudau To: Boris Brezillon Cc: Steven Price , Chia-I Wu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 4/9] drm/panthor: Don't update might_have_idle_groups in process_idle_event_locked() Message-ID: References: <20260811-panthor-signal-from-irq-v6-0-12f2ab53d735@collabora.com> <20260811-panthor-signal-from-irq-v6-4-12f2ab53d735@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260811-panthor-signal-from-irq-v6-4-12f2ab53d735@collabora.com> On Tue, Aug 11, 2026 at 01:23:38PM +0200, Boris Brezillon wrote: > By scheduling an immediate tick, we already force idleness re-evaluation, > which gives the scheduler the opportunity to evict idle groups > and schedule onces that have jobs pending. > > Signed-off-by: Boris Brezillon Reviewed-by: Liviu Dudau Best regards, Liviu > --- > drivers/gpu/drm/panthor/panthor_sched.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index 5832dccfc093..baa06731797c 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -1733,8 +1733,6 @@ static void csg_slot_process_idle_event_locked(struct panthor_device *ptdev, u32 > > lockdep_assert_held(&sched->lock); > > - sched->might_have_idle_groups = true; > - > /* Schedule a tick so we can evict idle groups and schedule non-idle > * ones. This will also update runtime PM and devfreq busy/idle states, > * so the device can lower its frequency or get suspended. > > -- > 2.55.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯