From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 663DA309EFC for ; Tue, 18 Aug 2026 22:54:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787093689; cv=none; b=BFdmNZILawvF0sxUbDza/Mfl+Z9eMhzBtW7bK2waXAe1/WGdsbmiXr2WAN9fdlS7CFAqgTtTLKmpDeUSv8Qbn6CBegZ6It70OC8WvD6+xn/t46rd18UAn+syuQRCGbs9pok13acYv65XKwG6H2+a9qXBtKLorpsG63GqfIf1h6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787093689; c=relaxed/simple; bh=6btL7nZ0S1u/4+3eC7ZeMGV5W3QJ8MpeIZr6Im2drno=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ELKf3nhEvFsTFlcoN4+e/5H1Kt976keeq07pCf6yvQiAVqtQyKsdnkoa/uFNz1JAtAPea6uV61aGj8sQY1Mqpur9LNEymtW4BhQZrFHh67DyVdQzKiUpAsuF+dP63VgD1MWSBrQRuyPn+O8TscpTpzk5omacFb63OkTAIo7RwJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=mspdUP8d; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="mspdUP8d" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38e88b60121so389088a91.3 for ; Tue, 18 Aug 2026 15:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1787093688; x=1787698488; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:mail-followup-to:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Gz2RTF0eU9/58HpSEWg5xF4pRvWmWGVnJVKoAZtXolU=; b=mspdUP8dZc83P9DZiYQ7upxxaZdVnc+P5O+l5UCWTaEELuOuMQzI1CTG3sNrjZCiYr W5TwWA2/UT5a/fusKi7s+9X5MYiG6/avhCq10bsBMqjhxD1oggxx1tXyxtNdNAhC0QKE lKw/WhIGCGYXXMrlHdJ4UTkWG2G8YGZ84ANw2qc8SFwj/s72EVyi1hQio+cXlnKecp0u JjL2knFzEwI6Xr5uRRM616wg9e4i9r9HaHyadA4Okt8P4MDomTrSA6zzoTB1pSUf9kpQ Zvp1IvkkwvVeZusut031Ign0Vd8p+JwXqRxGBoCcRLVZ3DCCCL00GTiXAlh03bkNjE4C 5voQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787093688; x=1787698488; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:mail-followup-to:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Gz2RTF0eU9/58HpSEWg5xF4pRvWmWGVnJVKoAZtXolU=; b=XVfcsEc2AT/Z3bYUMJG8bysR/cDDQOkHnFpdeGdFUAF2G7+P6KbkIyPnaWumDi42mc NhZj0tEk+xSru0Nfd8qlR6qs1elbdjk2e3El0erHgOYG10znMa7fxE2BYyVkQd7my/gU YwEj6er2Rs5TT8dpzcAH/Cx3a9vgjg8UkNVrR+be08aAvTV+yyhfDF/XhYVYJBsOHSF5 Z0ccYn3BOTrixiwNmUxWsSQXMrLtRGPxfHlln4hNpcG3NPSFN+lbaLHCHaVGXBxD1p4o 1xDTK7bJ1VdHOzZSIC3eilYo9W7roSxqs34PeEXvVAkkgWZfHLkINge4IjEQncLJfiQX woNg== X-Forwarded-Encrypted: i=1; AHgh+RqhpV/+uglj+15I4qBJ6MyTnJ+88KQbTA0FR+i4NBWkbBV41qM8xm6QhYMlMwS//8263250d2z9lNbdz2Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyIiYwvutS7FmREBlUTFFcU1LJbp/Y9+hrgmPbbS34oJ0exyE+4 KMmg+mi7JjKl0Bj4He4TfJPTc3QB2hUzdP3qrANt1GHkWnQ+QqqFtcKAcaJn4BF1DLE= X-Gm-Gg: AR+sD11yeC0IhLTnEhynhs143o9sd8VhylLT5ELdMRVFUKwf0oDZf56WylAgr9z0dAD S5Q18S1RkXzQ5HjRA/HyyNQIouwlyCos+ivt1bUBqrhHei5Xorx4CJIL+r9SC9RzXTu+y4TWnS/ PJEXUtdqogz3rkBAeD3eNlxhsWJBVsqFhQyd5ISHUPMVKEpkKYp9Mv5I7tu8loG8P9Kptv6vLfk WJ3m4eY7BBBnWIQxAikfgY9DaCtuSjlunzIy1flElbMGEg01ADbHxdG4I85ZOV/1Z79pSKQAlgF bnpP/NEy1SDTlkT7giCwo7CsjYgJwDcIpGtyuZQ1OuSSawKVaTemZaO0Nvv5LdiR9Q+F/4H1E0W ylwBlArOC8ILyDHEKtH1252sT8nqjzzO9z3mlKwj50uLCYo4AlBDlm9H/j8qcEyLBWLAX6d6Vr1 kXxnyNiMmMqOCohmwW+Ivuwc3jPHeZzNADTlMS309UkA== X-Received: by 2002:a17:90b:2241:b0:380:105f:8ffd with SMTP id 98e67ed59e1d1-39581228dbdmr396372a91.16.1787093687536; Tue, 18 Aug 2026 15:54:47 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:4d::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3957fbbe817sm102834a91.2.2026.08.18.15.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 15:54:46 -0700 (PDT) Date: Tue, 18 Aug 2026 15:54:46 -0700 From: Joe Damato To: Michael Chan Cc: netdev@vger.kernel.org, Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , horms@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] net: bnxt: ring the doorbell when SW USO exits early Message-ID: Mail-Followup-To: Joe Damato , Michael Chan , netdev@vger.kernel.org, Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , horms@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260818211540.2991183-1-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Aug 18, 2026 at 03:36:42PM -0700, Michael Chan wrote: > On Tue, Aug 18, 2026 at 2:15 PM Joe Damato wrote: [...] > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_gso.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_gso.c > > index f317f60414e8..3c58b1d94ac9 100644 > > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_gso.c > > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_gso.c > > @@ -223,9 +223,7 @@ netdev_tx_t bnxt_sw_udp_gso_xmit(struct bnxt *bp, > > netdev_tx_sent_queue(txq, skb->len); > > > > WRITE_ONCE(txr->tx_prod, prod); > > - /* Sync BDs before doorbell */ > > - wmb(); > > - bnxt_db_write(bp, &txr->tx_db, prod); > > + bnxt_txr_db_kick(bp, txr, prod); > > The patch looks good to me. But a slightly simpler approach is to > just set txr->kick_pending here. Upon return, the new logic above > will always ring the doorbell for the success case. By doing this, we > don't need to export bnxt_txr_db_kick(). Ah, right. Sorry I missed that; I was rushing too quickly to get this out :) I'll send a v2 tomorrow that simplfies the patch as you suggested. Thanks.