From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E486F3CB2FD for ; Wed, 19 Aug 2026 07:02:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787122945; cv=none; b=p2rDZLGCW4h8ajBymyGufegkCIm+GuCaNI2swarQG+2M9yU3aqh+VCTk41D/AnBGRQwymeRQjhFlaai7zBHHsAd5S3tvYcldAv0bb781s7nweUouAKL/mKtQSOoIwgFmJNtYKUqh5KYc8tXsldmfZSjcjFAfZH4NXtidHwzaOUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787122945; c=relaxed/simple; bh=DABWJkpBGy/B6Chwg3LQiA9sDnH6rH9UYRiyCrtkDos=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c7xOOVjeajE8fzZIp9ioPZInWJ8VXTQsdCsWz9afdgjFOE9Yo+WiBH7HLPGXNIlRlQz69ze75pkfTH17H4NLf4QorJwLkKoo0GhI1zyBeDXutWvoh+IzhJVMO0XHP+7b/jrW139rPKxsGGbOmVpA/9HW/lbLlyCa2qbey+MtNOQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=EwQR/WPt; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="EwQR/WPt" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-49978908b35so4560445e9.0 for ; Wed, 19 Aug 2026 00:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787122942; x=1787727742; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=DKZ7k5xuvKelkXAPGEl7SiL7VHybzzQJ3aLjy7GPMSg=; b=EwQR/WPtDIolAFylE7sXZMVad5i3l0rcKaZuB51A0ypRNf75eFD807B0BE/O8mxd7t iAzS0uy5i7FYp5dIe4fMXUETWf+JulL2P5sQE3ogZzv89uuk/+GFE81jmRHHF/3BBJ1D r4cDAyglUNaLXr/lz5CkqSRorfiAUBk+ir0oDpHZ2sWAgYCmUhsXwPV7HVXXiH04q+qO qQAbxBd+pcq8Cvh2AGPNrAr35hgnTo7m/IwAljGc6PBu36KDe2GiUl7g3n3cSLBQQOvY Y83aqkzAoJrsub/C4JEKZzXqfmcz2P9sBr7cIjjnTLV9+Gj4PWvzPMREGmDXQWWNALT+ SOwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787122942; x=1787727742; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DKZ7k5xuvKelkXAPGEl7SiL7VHybzzQJ3aLjy7GPMSg=; b=K2SqIj9BPnhOlcPCNH3OqOl5ehok8oHaDBkK258AZQ6T/x+dx2MOixR1YgK5Kkak1E 7wx4tPtnB76Cvu46ooZgl7xTZ4kXW9K2fsiaUsFUWZ8XPF7/W5/EXhbMhGoYBRZyhVZP 7CrDMpIu1zMyxCCVXJAavBmlS//8f1KO63qjq9BjD2aVIdSU6FXN01gMHnPF6KqQUduS qK9c3wEPHwR86q1K1QQy362A84e+Q3+hLi0J7xqOUvcaY9xN7iY4INJcdQx+ZF0xKc/7 Z3sL/NVGKeM7ftt8BY43ByqAyPck4oIrDHN4NkS7TD8tevdeivMDR04w6KJ6KcfBH2tW z+rg== X-Forwarded-Encrypted: i=1; AHgh+RqpuCOBe+3tgfMusQw3JfZfnFg/7mKIgbgCKk/3gGGxYBAqpMEyhyvGVaWQaiK8o/yZ5SCq2EE5IdOguG0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzz0BEuJMrWf4VepRv03kJkvn8NbKOgqa7y2ANk2jZsZ1do7KFG z+gaqM3EfkmTTbsX8P3cc/JOBx2+1nbYR6dvMGfIkqlH2/o5S0/3w9GTx3l7VAzaWqU= X-Gm-Gg: AR+sD13I/C3hVQmk/Ln1h0/OzSXbq1we57NxlNAFvi4i44uDMor4vXLuE+6E6ozwVgY r8NRmxqHw2wICMUnl3s6zOLGO013/ZBnOmYw4oxc//JwHrOc9iMFvKjpslNaEZdfM76+Oha1bLP fLkWHXlqTpaeq3lpzOjKCcdhOa5P6ZbaauxQKCayk973sDvCEj5ZoDlTPnIvVByBdtqRDBITxZd WNF/t9nmCs56Jy1GIvS9VAoJf7BH5bToNxKtj60EvrbyvExX3hl+sOOqXcdJzmaQIIOukBAnqUT 6/TqkKSawtAcCaYdUDH6OW3j9dFV2FHp9h12OYUd4bo15gYts1vP1EV7LM6JIxqbU9kNm7Rtzra gq5ykt+LDog+YnhO7Xyt5pgPVjvmsiq6IvsXQNtq7zfjnKrAvMwLzPVpYkwLqF3jiYw4yuA8BkV EHqOU+s9Q89uUNX4K098RunAjAjTtajxSCAvY3+XSS7fXshbaBCuI+46gCrSZYztanBzgC46+F9 A== X-Received: by 2002:a05:600c:37c6:b0:499:8f9f:e9ee with SMTP id 5b1f17b1804b1-499aa173a16mr44660575e9.7.1787122942071; Wed, 19 Aug 2026 00:02:22 -0700 (PDT) Received: from localhost (109-81-87-166.rct.o2.cz. [109.81.87.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499aa0fd7a9sm51540595e9.2.2026.08.19.00.02.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 00:02:21 -0700 (PDT) Date: Wed, 19 Aug 2026 09:02:20 +0200 From: Michal Hocko To: Joshua Hahn Cc: Shakeel Butt , Andrew Morton , Johannes Weiner , Roman Gushchin , Muchun Song , Jakub Kicinski , Meta kernel team , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Joy Chaoyue Xiong Subject: Re: [PATCH] memcg: trim the per-cpu charge stock instead of draining it Message-ID: References: <20260819041747.1111965-1-joshua.hahnjy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260819041747.1111965-1-joshua.hahnjy@gmail.com> On Tue 18-08-26 21:17:46, Joshua Hahn wrote: > On Tue, 18 Aug 2026 12:03:07 +0200 Michal Hocko wrote: > > The idea is sound. I would just not increase the overall stock size in > > the same patch. Fine tuning can be done independently and ideally with > > some numbers. > > Would it make sense to start with MEMCG_STOCK_HIGH := MEMCG_CHARGE_BATCH > > and MEMCG_CHARGE_BATCH := MEMCG_CHARGE_BATCH / 2. That would preserve > > the maximum stock size while preventing all or nothing behavior which is > > indeed suboptimal and pushing charging path to a slower path way too > > aggressively. > > I like this idea and I think you meant { MEMCG_CHARGE_LOW := > MEMCG_CHARGE_BATCH / 2 } right? Correct. Wrong auto-completion on my end. -- Michal Hocko SUSE Labs