From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12B4136897C for ; Wed, 19 Aug 2026 07:55:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787126142; cv=none; b=gEDk3CpXsN6XmPqcxFPF9gpZVe4NAA0VS1TPPI/HE9FLtiiRHfpjvT+gY/118L9wlDX4pAiR5yHAeBK3jeUrPVwS/1LCUyqgn4PcIekvnb9QSwh/bPmftUFodxHfgt0gPJ8NSqUuDpc7m9sCaNcJ6x+EOeNpCmdBx0Pwgko8X48= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787126142; c=relaxed/simple; bh=SaipIOQi0DqyNOoIL+HkPjslGNCfshHC8YuW79QEZRU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B/C7Cmea1u25CEEXsQ12EIXWpKN8T6tFY2ZVoQIa6l8Dcvt2dkYv4PxxH+wNnxUAPKplQE3Afig55Iw/iWTLQYZa5JsvZLOWdG7lZwMBKwoELgjYhT0RtGUNupKOq3kJVlaA3teQaioL96DXUP0n+jq7NznXYY9q+Tr198wEY4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=AydyNV/m; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AydyNV/m" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787126141; x=1818662141; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=SaipIOQi0DqyNOoIL+HkPjslGNCfshHC8YuW79QEZRU=; b=AydyNV/mxejivInraxm2tewpoFYfUcrkZqtq3p+9wSdats4qbAdlnshb Bl0S97jygpQtH4HMlg6SklFq9GSbgIDDeIJGXIAakYt9KJrB2xuP528yS oVf1mytr5IqwDXJTmRlyq3Tj69ic29Yeh7DSa1tLGlj4fQiEARGTCwWZM gL7YFCP/TY2rnmMZx41fwBvs2oGKRBTqkfbr2JSqwTZ4gfzFJDeAfLDc8 BmpqqDWbPFOqzH99si8BRI9JFdFrbjkYtT8+uW7cNDnYcE2aQLilk2QYn IfPxu/70KLNtINWbJjozaWBKMnM40Dttwt3jL8+Lz6Qob++962p/RSc0F g==; X-CSE-ConnectionGUID: W68zyEWpSMmT44Nn0LNN2A== X-CSE-MsgGUID: qnokkfMGQh2ue3hL779KMw== X-IronPort-AV: E=McAfee;i="6800,10657,11879"; a="91502914" X-IronPort-AV: E=Sophos;i="6.25,231,1779174000"; d="scan'208";a="91502914" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2026 00:55:40 -0700 X-CSE-ConnectionGUID: kvgVAoggQYugIk894oVZCA== X-CSE-MsgGUID: /5xDjFMiTDe/A2vqTdKHQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,231,1779174000"; d="scan'208";a="264148719" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.106]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2026 00:55:38 -0700 Date: Wed, 19 Aug 2026 10:55:36 +0300 From: Andy Shevchenko To: Li Jun Cc: andy@kernel.org, geert@linux-m68k.org, fourier.thomas@gmail.com, bhelgaas@google.com, u.kleine-koenig@baylibre.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] auxdisplay: pm: use SIMPLE_DEV_PM_OPS for pm struct Message-ID: References: <20260819033142.2127526-1-lijun01@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260819033142.2127526-1-lijun01@kylinos.cn> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Aug 19, 2026 at 11:31:42AM +0800, Li Jun wrote: > use SIMPLE_DEV_PM_OPS for charlcd_pm_ops,and add the value of > .freeze .thaw .poweroff .restore. Respect English grammar and punctuation. ... > -static const struct dev_pm_ops charlcd_pm_ops = { > - .suspend = charlcd_suspend, > - .resume = charlcd_resume, > -}; > +static SIMPLE_DEV_PM_OPS(charlcd_pm_ops, charlcd_suspend, charlcd_resume); No, see what it says about this https://elixir.bootlin.com/linux/v7.2/source/include/linux/pm.h#L436 Use DEFINE_SIMPLE_DEV_PM_OPS() and the respective pm_sleep_ptr() macro. ... Hint: there are tons of patches like this in the Git history for the last few years, just grep over them to see the examples how this change should look like. -- With Best Regards, Andy Shevchenko